Skip to content

docs(adr): ADR-0061 D5 — dated note: the anonymous publicPicker search model is retired by ruling E (#21180) - #21223

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-21180-adr-0061-note
Oct 1, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
claude/issue-21180-adr-0061-note

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Refs #21180

Docs-only. Adds one dated note to ADR-0061 under its D5 entry (docs/adr/0061-record-search-architecture.md:54). The original sentence says anonymous search "keeps the existing publicPicker model". The note records that this model is retired by the maintainer's ruling E on #21079 (record 5933054144, 「同意E」, 2026-10-01), which reverses the #7467 model. The original text is not rewritten: the diff is exactly two added lines, a blank line and the note.

Tier H. docs/adr/** is a governed surface, so this PR lands only on the maintainer's approval. No seat merges, queues or arms it. The code half (the retirement itself) is the separate PR #21222; this PR carries no closing keyword, so merging it does not close the card.

The note (its links shown as plain references)

Note (2026-10-01) — anonymous search retired. The publicPicker model the sentence above keeps is retired by the maintainer's ruling E on #21079 (comment 5933054144, 2026-10-01), which reverses the #7467 model (declare publicPicker). Anonymous public forms no longer take lookup, master_detail or user fields: the public-form resolve route leaves them off the anonymous rendering unconditionally, the anonymous record-search route GET /forms/:slug/lookup/:field is deleted, and publicPicker is a retiredKey() tombstone under ADR-0087 D2 (immediate retirement). So there is no public/anonymous record search; the rest of D5 stands. The retirement is #21180.

Gates (derived from this diff, head 6b16db083)

dispatch-gates --commands derives 19 families. All 19 ran to exit 0, among them check-adr-links (695 links resolve), check-adr-symbol-anchors, check:adr-anchors, check:pm-governed-merges, check:doc-authoring, check:nul-bytes and check:closing-keyword-parity. One, check:doc-formula-expressions, first refused with exit 3 because formula and lint were not built in this fresh worktree. It ran to exit 0 after the build its refusal prescribed. skip-changeset applies: the diff publishes nothing.

维护者速读(草稿)

改了什么:只在 ADR-0061 的 D5 条目(:54)下追加一条注明日期(2026-10-01)的说明,原文一字不改;差异只有新增的两行。

为什么改:D5 原文写着匿名搜索"沿用现有的 publicPicker 模型"。裁决 E(#21079,「同意E」)已退役该模型,推翻 #7467 的"声明 publicPicker"。不加这条说明,ADR 会继续声明一个已被删除的匿名记录搜索口,下一个读者会据此重建它。

风险与代价(含回滚):纯文档,不改任何代码或行为,不发布任何包。回滚就是删掉这两行。代码那一半(墓碑、删路由、迁移登记)在 #21222,与本 PR 互不依赖,哪个先落都可以。

席位意见:

你要做的:读一遍这条说明,确认措辞准确地记下了裁决 E,然后批准合并;本 PR 属 Tier H,只能由你点。


Generated by Claude Code

…rch model is retired by ruling E

Claude-Session: https://claude.ai/code/session_017VaLJnYwhPsanVCe9dMCJU
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

维护者速读 · PR #21223(ADR-0061 注记,Tier H)

domain:spec 席位 2(session_017VaLJnYwhPsanVCe9dMCJU)· 2026-10-01T18:25Z · 对照 head 6b16db0832 的 diff 校正

改了什么:只在 ADR-0061 的 D5 条目(docs/adr/0061-record-search-architecture.md:54)下追加一条注明日期(2026-10-01)的说明。差异是新增的两行(空行与注记),原文一字未改。

为什么改:D5 原文写着匿名搜索"沿用现有的 publicPicker 模型"。你的裁决 E(#21079 上的记录 5933054144,「同意E」)退役了这个模型,也推翻了 #7467 的"声明 publicPicker"。不加这条注记,ADR 会继续描述一个已删除的匿名记录搜索入口,下一个读者可能照着它重建。

风险与代价(含回滚):纯文档,不改代码和行为,不发布任何包,CI 在该 head 上全绿。回滚就是删掉这两行。注记描述的落地状态来自代码 PR #21222:解析路由无条件去掉 lookup / master_detail / user 字段,删除 GET /forms/:slug/lookup/:field,publicPicker 改为 retiredKey() 墓碑。

席位意见:建议批准。我逐句对过 diff 和裁决原文:

你要做的:读一遍这条注记,直接点合并即可。只点批准的话,由下一任 spec 席位落地。


Generated by Claude Code

@os-zhuang
os-zhuang marked this pull request as ready for review October 1, 2026 23:01
@os-zhuang
os-zhuang enabled auto-merge October 1, 2026 23:01
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit 8dea55d Oct 1, 2026
41 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-21180-adr-0061-note branch October 1, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-user-decision size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants