Skip to content

docs(spec): JobSchema.body's describe says an enabled pull job installs when its pull binds and is refused when it does not - #21708

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-21703-job-describe-pull
Oct 4, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-21703-job-describe-pull

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #21703

Clause-②: no

Built to triage 5977869121 (direction: the card's own one-sentence fix), dispatched under claim 5977933303. One sentence of JobSchema.body's published describe, the reference page generated from it, and one @objectstack/spec patch changeset. No schema, key, export or behaviour change.

Measured first: what install-local does with a pull job at the base

Base 16d241a6af (origin/main when this branch was cut). Install-local is the door after PR #21683.

  • packages/runtime/src/app-artifact-handlers.ts:389-412, collectJobsWithoutBody. A disabled job is skipped (:393, if (job.enabled === false) continue;). An enabled job that declares pull is judged by judgeJobPull(job, bundle) (:397). if (judged.binds) continue; (:398) leaves a binding pull unnamed; otherwise the job is named with pullRefusal = judged.refusal; (:399). A job with no pull and a body is named only when judgeJobBody refuses that body (:401-403). A job with neither is named with no refusal.
  • :457-491, judgeJobPull, the one judge (the binder calls it too, :837). It binds only when no body or handler sits beside the pull (:461), the pull parses (:468), and the artifact declares the named mapping (:475) with a connectorSource (:483); then return { binds: true, mapping }; (:490).
  • packages/cloud-connection/src/marketplace-install-local-plugin.ts:1006-1014. The install route answers 422 VALIDATION_ERROR (UNRUNNABLE_REFUSAL_CODE and UNRUNNABLE_REFUSAL_STATUS, :192-193) whenever unrunnable.jobs.length is non-zero (:1007). A job carrying pullRefusal gets describeUnrunnable's pull clause (:218, :242).

So at the base, an enabled pull job installs when its pull binds. It is refused with the same 422 when it does not, as is a job whose body the declaration refuses. A disabled one is not judged. The old sentence was "os package install therefore refuses an enabled job with no body (a pull job excepted: it is data too)". It reads as "a pull job is never refused", which those lines contradict.

The change

In packages/spec/src/system/job.zod.ts, JobSchema.body's describe, the old clause becomes:

os package install therefore refuses an enabled job with no body. A pull is data too, so an enabled pull job is judged by its pull instead: it installs when the pull binds (it names a mapping the package declares, with a connectorSource) and is refused when it does not, as is a job whose body the declaration refuses.

The parenthesis names the condition an author controls. Code beside a pull stays with the describe's next sentence, "Refused beside pull."

Neighbouring describes, read for any other sentence PR #21683 made false: none, so none is touched.

Readers of the old wording

git grep -n -F over tracked files at the base, for each of these substrings:

job excepted
it is data too
excepted: it is data
pull` job excepted
data too)
job with no `body` (a

Each has two hits: packages/spec/src/system/job.zod.ts:322 and the generated content/docs/references/system/job.mdx:61. No test, gate, skill or hand-written doc matches the old sentence, so nothing else moves. The broader substring refuses an enabled job with no also hits a pending changeset and a test describe title. Both are about the no-body refusal, which is unchanged.

Regenerated with the repo's tooling

  • Before the regeneration: pnpm --filter @objectstack/spec check:generated ran after the describe commit b58c6f819b. 14 of 15 artifacts were current, and check:docs was stale on content/docs/references/**.
  • The regeneration: check:generated --fix rebuilt packages/spec first, regenerated only that artifact, and re-checked it green. The diff is the one table row in job.mdx.
  • No other generated artifact carries the describe.

Changeset

.changeset/21703-job-body-describe-pull.md names '@objectstack/spec': patch, since the describe ships in src/**/*.zod.ts and in the build. It carries Clause-②: no at line start. Text only.

Verification at c31367a1ec (the final commit)

  • pnpm --filter @objectstack/spec build, under os-verify-lock: exit 0.
  • pnpm --filter @objectstack/spec typecheck (tsc, check:scripts-typecheck, check:test-typecheck): exit 0.
  • pnpm --filter @objectstack/spec exec vitest run --project local --maxWorkers=2: 612 files passed. 18185 tests passed, 1 todo.
  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack, with no paths: 3 paths against merge base 16d241a6a, 104 commands. All 104 exit 0.
    • Six first exited 3 (PREREQUISITE NOT MET), because packages outside this diff were unbuilt. They were lint's check:doc-formula-expressions and check:doc-security-posture, check:skill-examples, check:docs-transcript-drift, check:dual-build-cjs-loads and check:lean-entry-closure.
    • A full turbo run build --filter=!@objectstack/docs --concurrency=2 then ran under the lock (72 of 72 tasks). Each of the six exited 0 on rerun, and the record carries the reruns.
    • --ran: 104 derived, 104 run, 0 NOT-MEASURED, 0 UNRUN.
  • ESLint, narrowed to the diff:
    • pnpm exec eslint --no-inline-config --format json over the three diff paths reports 3 files.
    • ESLint's own config matches neither Markdown file ("File ignored because no matching configuration was supplied"). job.zod.ts has 0 errors and 0 warnings.
    • The config never enables type-aware linting: every parserOptions is { ecmaVersion: 'latest', sourceType: 'module' }, and eslint.config.mjs says so at its query-options note. So a string edit in one file moves no untouched file's verdict. The full pnpm lint is left to CI.
  • origin/main has moved one commit since the base (7e0066af7a, tracker citations in spec test files). It touches none of this PR's paths, so the branch was not merged again.

Acceptance notes


Generated by Claude Code

claude added 2 commits October 4, 2026 08:07
…ls when its pull binds and is refused when it does not

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ
…changeset for the pull sentence

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ
@github-actions github-actions Bot added the size/s label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/spec, touching 1 documentable anchor(s).

2 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/concepts/metadata-lifecycle.mdx (via JobSchema (symbol, a top-level const))
  • content/docs/getting-started/quick-reference.mdx (via JobSchema (symbol, a top-level const))
What this run could not see
  • the SDK route bridge reached 54 of 206 client-bound route-ledger rows — the other 152 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 152: 0 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 55 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 97 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 138 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7e0066af7a8e05709dc60096c69bc85e299d0331 → packageMentionDocs.

Which tree this was computed on

This run read content/docs from ffcd45ca25d317616fd803c28e6e86adc05895b4 — the merge of head c31367a1ecd24e9a7c52617875b1ac8acad026a7 into base 7e0066af7a8e05709dc60096c69bc85e299d0331, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin ffcd45ca25d317616fd803c28e6e86adc05895b4 && git checkout ffcd45ca25d317616fd803c28e6e86adc05895b4
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7e0066af7a8e05709dc60096c69bc85e299d0331 c31367a1ecd24e9a7c52617875b1ac8acad026a7 && git checkout -B drift-repro 7e0066af7a8e05709dc60096c69bc85e299d0331 && git merge --no-ff c31367a1ecd24e9a7c52617875b1ac8acad026a7

node scripts/docs-audit/affected-docs.mjs --json 7e0066af7a8e05709dc60096c69bc85e299d0331

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7e0066af7a8e05709dc60096c69bc85e299d0331 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actions github-actions Bot added documentation Improvements or additions to documentation protocol:system tooling labels Oct 4, 2026
@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 4, 2026 09:25
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 4, 2026 09:25
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 4, 2026
Merged via the queue into main with commit 9d91f58 Oct 4, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-21703-job-describe-pull branch October 4, 2026 09:51
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 37192205626 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Console Pin Gate — 失败步骤: Build the Console SPA at the pinned objectui SHA

    ✗ Built console still carries the PUBLISHED @objectstack/spec.
    

↳ 失败原因 是判读的关键:超时(Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言(AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️ 断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError。 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

  • ⚠️ 本次没有可用的聚合签名(日志里没有能解析出测试文件名的 FAIL 行)—— 这不是「没有同签名的其他 PR」,是这一轮没测到。跨 PR 聚合本次不可用,请手工比对其他 PR 的同类评论。
  • ⚠️ 24h 评论账本没读完(超过 5 页仍未读到窗口尽头),所以上面的「不同 PR 数」是下界,不是全量。

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 8 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation protocol:system size/s tooling

Projects

None yet

2 participants