Repository navigation
Revert "ci(test-shards): grade the Test Core split on predicted shard wall and slice the CLI per run (#22415)" - #22435
Merged
objectstack-fleet[bot] merged 1 commit intoOct 9, 2026
Conversation
… wall and slice the CLI per run (#22415)" This reverts commit c64130b. Why: PR #22415 packs about 2000-3000 s of predicted windows onto each whole-package Test Core shard. The dataset's per-package windows were measured on shards carrying about 1,400 s, and under 4-wide concurrency each package's window inflates on the denser shards (objectql 1.84x, plugin-security 1.80x, rest 1.61x, plugin-auth 1.87x). That carries the shard past the "Check this shard's timing drift" step's 1.5x red while the test step itself passes. Red full runs on that partition model: - main push 37894048074 (e02833c; shards 4/6 and 6/6; 6/6 read 3992.4s measured vs 2467.1s predicted = 1.62x) - merge_group builds 37894050587, 37893672824, 37894053453 and 37892033675 The revert restores .github/workflows/ci.yml and scripts/partition-test-shards.mjs byte-for-byte to their content at f05649f, the reverted commit's single parent. A contention-aware redesign is the next round, not a hotfix. Claude-Session: https://claude.ai/code/session_0115N1oNnQS5WqofZ2DzaT3q Co-authored-by: Claude <noreply@anthropic.com>
objectstack-fleet
Bot
deleted the
claude/issue-22075-revert-shard-wall-split
branch
October 9, 2026 08:51
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #22075
Clause-②: no
Reverts PR #22415 (
c64130bafa), made withgit revert --no-edit c64130bafa. Since it landed, full runs onmainand in the merge queue redTest Coreat the step "Check this shard's timing drift", while the step "Run this shard's tests" passes on the same shard. Each red removes a PR from the queue and rebuilds every group behind it.Diagnosis
From the seat's revert-round claim (
6076043190, "Why a revert") and thedomain:servicesseat 2 data note (6076007681) on the card:objectql1.84x,plugin-security1.80x,rest1.61x,plugin-auth1.87x (seat claim). The drift step's red is 1.5x.Red full runs. Each was re-read from the jobs API in this round. In every one, the drift step is
failureand "Run this shard's tests" issuccesson the same shard.mainate02833c240e02833c240628df0ccb0a4aed6e02833c2The drift line from 37894048074,
Test Core (6/6), job 113701465749:The data note's rows: 37892033675 shard 6/6 read 3028.0 s against 1962.3 s (1.54x), and 37893672824 shard 5/6 read 2904.1 s against 1828.0 s (1.59x).
What full runs read before
c64130bafa(the state this restores)mainpush 37888117205 (27a8b33dec): the drift step issuccesson all six shards.Test Core (1/6):1885.9s measured vs 1766.8s predicted across 4 package(s) = 1.07x.Test Core (6/6):2136.1s measured vs 1766.1s predicted across 13 package(s) = 1.21x.mainpush 37883152892 (abd254508b): the drift step issuccesson all six shards. These are the step conclusions from the jobs API; the log lines were not read.successon all six shards.c64130bafa's ownci.ymlcomment records shard 1/6 at 1.07x and shard 2/6 at 0.74x there.Proof
b49b02297d:git diff f05649f6aa HEAD -- .github/workflows/ci.yml scripts/partition-test-shards.mjsprints nothing (0 bytes).f05649f6aa, atHEADand on disk:ci.yml0d2576cbf2,partition-test-shards.mjsa7c6fc76ec.mainis exactly these 2 files, +184/−576.origin/maintouched either file, orscripts/test-shard-timings.json, afterc64130bafa(read again atb9222dc701).node scripts/partition-test-shards.mjs --self-testexits 0:partition-test-shards: self-test OK (72 measured packages -> 72 shard items, 6 shards, max/mean 1.00x <= 1.3x, floor 1739s, bins 1771/1773/1772/1772/1772/1771s, file-level slices: none).The dataset is unchanged since
f05649f6aa.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackatb49b02297d: 58 commands.check:stall-guard-budget(Test Core: cap 20m against budget 45m),check:required-contexts,check:shard-attestationandcheck:nul-bytes.pnpm check:pm-dispatch-gatesprinted✓ dispatch-gates self-test: 2011 cases pass.(1071.5 s). It ran in the background, and its exit code was not captured. The verdict line is quoted instead.PREREQUISITE NOT MET(they read builtdist/, and this diff touches no package):check:dts-closure,check:dual-build-cjs-loads,check:lean-entry-closure,check:sourcemap-no-sources-content.--ranatb49b02297d:✓ dispatch-gates --ran: 58 derived famil(ies) accounted for — 54 run, 4 NOT-MEASURED (⛔ a FLOOR — 4 derived from exit 3; 1 of 58 recorded no exit code).Scope
.github/workflows/ci.ymlandscripts/partition-test-shards.mjs, both restored tof05649f6aa.skip-changeset: rootscripts/and workflows publish nothing.6075708656) no longer applies once this lands, because the change it measured is gone.Acceptance notes
mainruns, per the restoredci.ymlcomment, and 1.07x on 37875522518 and 37888117205. Shards 2–6 read higher before the change; shard 6/6 on 37888117205 read 1.21x. That is green, and under the 1.3x warning. Carrier: the seat's redesign brief for the card's next round.Generated by Claude Code