Repository navigation
docs(changeset): the consumed page-action-row operation changeset no longer says an api row beside the update parses (deliberate correction) - #23524
Draft
objectstack-fleet[bot] wants to merge 2 commits into
Conversation
…longer says an `api` row beside the update parses (deliberate correction) The consumed prerelease changeset said a row with `actionType: 'api'`, `operation: 'update'` and a `patch` parses once `onSuccess` is dropped. The rows now carry ActionSchema's declarative-update rules, which refuse an executor other than `'script'` beside the update at that key. The FROM -> TO first row and the "What an author now sees" closing sentence now name the executor condition. The 18.0.0 GA entry is compiled from `.changeset/pre/` on pre-mode exit, so this is the text that ships. Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz Co-authored-by: Claude <noreply@anthropic.com>
…nsumed-changeset-example
Contributor
Author
Awaiting a person's confirmation ·
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23498
Clause-②: no
What this does
Corrects two sentences of the consumed prerelease changeset
.changeset/pre/23332-page-action-row-operation.mdin place. PR #23494 (merged asad5a7d7c3) made both false. No code, no new changeset, noCHANGELOG.md, nocontent/docs/releases/, no.changeset/pre.json. The frontmatter, theClause-②line, the ADR-0087 registration marker and the BREAKING banner are byte-identical. The diff touches lines 24 and 30 only (+2 / -2).First measurement: the 18.0.0 GA entry is compiled from
.changeset/pre/The card's first step (triage
6171242082) is measured two ways, on1f3ac4f524:@changesets/cli3.0.3.@changesets/read1.0.1readChangesetsreads.changeset/pre/*as idspre/NAME.@changesets/assemble-release-plan7.0.0getRelevantChangesetsdropspre/ids only whilepreState.mode !== "exit".@changesets/pre3.0.0exitPrewritesmode: "exit". So on pre-mode exit, every consumed changeset is an input to the GA release plan.changeset pre exit && changeset versionexited 0. Its own notice said: "Please also review the changesets in the .changeset/pre folder as they will be used as changelogs for the normal versions". The output setpackages/specto18.0.0. ItsCHANGELOG.md## 18.0.0entry (lines 3 to 4266) carried this file's FROM → TO first row at line 3189 and the "What an author now sees" paragraph at line 3195, false sentence included. So the scope does not shrink to the CHANGELOG line.The two sentences, BEFORE → AFTER
onSuccess: the runner performs the write …onSuccess, with no executor key or'script'(besideoperation: 'update'any other executor is refused at that key, D3ui-page-action-row-declarative-update-rules): the runner performs the write …onSuccessparses unchanged.actionType, since besideoperation: 'update'an executor other than'script'is refused (D3ui-page-action-row-declarative-update-rules); withoutonSuccess, and with noactionTypeoractionType: 'script', it parses.Why: the example row names
actionType: 'api'. Since PR #23494, a page action row carriesActionSchema's declarative-update rules, so an executor other than'script'besideoperation: 'update'is refused at the executor key. That holds with or withoutonSuccess. The card's done-line offered two routes: drop the executor from the example, or qualify the sentence. This PR qualifies the two sentences. The quoted refusal text and the example row stay as they were, and the edit stays within the two places the claim names. Nothing about #23332's own semantics changes:onSuccessbeside the update is still refused whatever executor the row names, or none.Every example in the file, parsed against today's
mainA test-free scratch script (not committed) parsed each shape against
packages/spec/dist/uibuilt from1f3ac4f524. The branch's later merge oforigin/mainbrought in nopackages/specchange (0 paths).After this PR, every statement in the file matches these results. The FROM → TO first row's "before" is refused (E1). Its "instead" parses (E4, E6, E9). The "What an author now sees" example gets the quoted
onSuccesstext (E1), and the new closing sentence names its second refusal, atactionType. The row withoutonSuccessand with no or'script'executor parses (E4, E6). The second and third FROM → TO rows match E10, E11, E12 and E4.Check Changesetis red on purpose: DELIBERATE CORRECTION, and a person's confirmation is owedscripts/check-empty-changeset.mjsrefuses a diff that modifies a changeset present on the merge base. Its git pathspec.changeset/*.mdmatches.changeset/pre/too. Measured locally: exit 1,::error file=.changeset/pre/23332-page-action-row-operation.md::. It names the two classes. This PR is the DELIBERATE CORRECTION class: PR #23494 changed the behaviour this pending release note describes. Remedy, per the gate: "do NOT restore it -- say so on the PR and get it confirmed". Nothing here is restored or routed around to turn it green. A person's confirmation of this correction is owed on this PR before it lands, as on the precedent PR #23126. As on that precedent, noskip-changesetlabel is applied: #23126 carried none, and its gate stayed red until confirmed.packages/spec/CHANGELOG.md's18.0.0-next.1entry carries the same sentence. It was true atnext.1, and amending it is the release owner's call. It is not touched here.Gates (run at
578a53d33c)node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 20 commands. All 20 were run, plusnode scripts/check-changeset-fixed.mjs(its roster lives under.changeset/).--ranreconciliation: "20 derived, 20 run, 0 NOT-MEASURED, 0 UNRUN", a DERIVED zero, with every exit code recorded. Exit 0 for all exceptnode scripts/check-empty-changeset.mjs --base origin/main, which exits 1. That is the designed DELIBERATE CORRECTION red above.check-adr-0087-registration --base origin/main: exit 0.check:nul-bytes: OK. A control-byte self-scan of the edited file found no hits.NOT MEASURED locally: the four type-check lanes the derivation names as CI-only. This diff touches no TypeScript.
Acceptance notes
ui-page-action-row-declarative-update-rulesnamed in the new text is the id ofpackages/spec/src/migrations/entries/semantic/18.ui-page-action-row-declarative-update-rules.ts.Generated by Claude Code