Repository navigation
test(dogfood): the authz census records handleI18nRequest at 4, a docblock link; i18n.ts reach is unchanged - #26002
Merged
Conversation
…block link; i18n.ts reach is unchanged
The translations validator added a fourth `{@link handleI18nRequest}` (in
`TRANSLATIONS_CACHE_CONTROL`'s docblock) to packages/runtime/src/domains/i18n.ts
and no handler, route or gate call, so the row's population, reach and
`shouldDenyAnonymous(` control stay 1 / 1 / 1. Only the handler-name control
moves, 3 -> 4, re-read against the file.
Claude-Session: https://claude.ai/code/session_01H98bQgxPLVbpyR6Zsu6SUW
Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对Verdict: ACCEPT at head Checklist
The pin was re-read, not just bumped
Seat's own reading, in a detached worktree at
Gates
Generated by Claude Code |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #25988
Clause-②: no
Metadata-protocol: none
The claim is 6411275777 (seat
domain:devx#1, card threadsession_01H98bQgxPLVbpyR6Zsu6SUW, branchclaude/project-thread-vi44lw, platform-assigned).What changes
main'sDogfood Regression Gate (3/3)has been red on every run that runs it since69fa23d6(#25956), on one assertion of the authz blind-spot census:The census is a measurement pin, so the fourth occurrence was read before it was recorded. One file changes:
packages/qa/dogfood/test/authz-probe-blind-spot.census.ts, thepackages/runtime/src/domains/i18n.tsrow. ThehandleI18nRequestcontrol goes from 3 to 4, and the row's comment names the fourth occurrence and why reach is unchanged. No other row, no total and no derivation rule moves.The fourth occurrence, read
packages/runtime/src/domains/i18n.tsat05f7758fholdshandleI18nRequestfour times:{@link handleI18nRequest}TRANSLATIONS_CACHE_CONTROL's docblock,(see the floor in {@link handleI18nRequest})69fa23d6DomainRoutecall site increateI18nDomainexport async function handleI18nRequest(69fa23d6(the translations validator, Part of #25785) added three module-private helpers to that file (requestHeader,ifNoneMatchHits,translationsAnswer) and the one constant. None of them is anexport async function handle*Requestentry point, it added noDomainRouteprefix, and it added noshouldDenyAnonymous(call. The anonymous floor is still the handler's first statement. So the row's population, reach and gate control are unchanged at 1 / 1 / 1, and the row's own population and reach test stayed green onmainthe whole time. The only reading that moved is the handler-name control, by a docblock link. This is a count change, not a census row change, and nothing here needs a new probe.Sweep of the rest of the census
05f7758fthe census file reads1 failed | 46 passed(the same i18n assertion, nothing else), and with this change47 passed. So no other control, row, total or probe-table reading has moved since69fa23d6or with any later merge up to05f7758f.origin/mainhas since moved toa4eae064(4 commits). In the census-read source directories they touch only two test files (packages/runtime/src/domains/mcp-package-object-discovery.test.ts,packages/runtime/src/stored-metadata-reader-contexts.pin.test.ts), and the census reads neither, so the reading holds there too.Verification
All at head
ed1c5b39, underscripts/pm/os-verify-lock.sh.05f7758f,pnpm exec vitest run test/authz-probe-blind-spot.test.tsinpackages/qa/dogfood):Tests 1 failed | 46 passed (47),AssertionError: control "handleI18nRequest" moved in packages/runtime/src/domains/i18n.ts: expected 4 to be 3.--concurrency=2:pnpm turbo run build --filter=@objectstack/dogfood:Tasks: 67 successful, 67 total,VERDICT command-exit 0.OS_TEST_SHARD=3/3 node scripts/run-with-stall-guard.mjs --log dogfood.log --stall-minutes 10 -- pnpm turbo run test --filter=@objectstack/dogfood:Test Files 97 passed | 2 skipped (99)Tests 990 passed | 14 skipped (1004)authz-probe-blind-spot.test.ts (47 tests)passed inside the shardVERDICT command-exit 0node scripts/check-test-completeness.mjs:OK (1 package(s), 1004 test(s) declared and all 1004 accounted for)authz-conformance.test.ts+ the census (conformance sits in another shard, so it was run on its own):Test Files 2 passed (2),Tests 108 passed (108),VERDICT command-exit 0.pnpm --filter @objectstack/dogfood typecheck:VERDICT command-exit 0.pnpm exec eslint --no-inline-configon the changed file: exit 0.node scripts/pm/dispatch-gates.mjs --commandsderives 52 families on the 1 changed path. 51 exit 0.pnpm check:dual-build-cjs-loadsis NOT MEASURED: it exited 3 (PREREQUISITE NOT MET) because it needs every package'sdist/and only the dogfood closure was built. CI's Lint lane owns it.dispatch-gates.mjs --ran:52 derived, 51 run, 1 NOT-MEASURED, 0 UNRUN.node scripts/pm/check-governed-merges.mjs --branch HEAD: NOT governed, 16 changed lines.@objectstack/dogfoodisprivate, and the diff is one test-support file.skip-changesetis declared with this PR.PR and merge-group CI never run the dogfood legs, so this PR's checks cannot show the fix. The card's acceptance is read on
mainafter landing: the first push run that runsDogfood Regression Gate (3/3), and the next scheduled run. Both run ids will be reported on the card.Acceptance notes
Test CoreandDogfood Regression Gatego red on superseded runs (139 in 51 h, 0 real catches): keep #16157's ruled reading, or decide by the cancel cause the platform records? #22653 ruled on that.Generated by Claude Code