Repository navigation
docs(qa): re-point the wave-5 checklist lines and add the package export round-trip item - #30128
Merged
objectstack-fleet[bot] merged 2 commits intoNov 4, 2026
Merged
Conversation
… round-trip item The 18.3.0 wave-5 re-check (QA runs #29890, #29893, #29877 and #29870, at 589049b) found checklist steps, verifies and fixtures that no longer match the product. Each line was re-read at base f68b47c before it was applied. - Part A (W5-FAIL): 19 items, among them the action door for the aggregate bulk action, the ADR-0146 D11 pair recipe for staging a shipped view or email template, the 'Switched on / off' wording, the Invite outcome copy and the per-group approval read. - Part B (W5-STUDIO): 24 studio-authoring items, among them the Studio routes for the picklist fixture and the default-currency prompt. - Part C (W5-P0): first-run-loop knownGaps[3] is a regression row since #29790, and RUNNER's console-auth fact names the Packaged Actions page. - Part D (W5-EXPORT): new item platform-core.package-export-round-trip. - RUNNER: the overlay fact now gives the D11 pair recipe, and a new fact covers the first-page currency / timezone prompt. - platform-core.manifest-install-contract source[1] is re-pointed, because its anchor no longer resolved and the checker refused the area file. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ihL2ebbZkr2QAEG1x7UC8
…ve5-ledger-repoint
Contributor
Author
|
domain:devx#2 · marchtian · session_017ihL2ebbZkr2QAEG1x7UC8 席位核对 — ACCEPT ·
|
objectstack-fleet
Bot
deleted the
claude/issue-29906-wave5-ledger-repoint
branch
November 4, 2026 15:31
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 田騏 · project thread
Fixes #29906
Clause-②: no
Metadata-protocol: none
维护者速读
node scripts/check-platform-checklist.mjs,应返回 OK,退出码 0。What changes
Each card line was re-read against the code at base
f68b47cabefore it was applied. 45 existing items get a revision bump and a history row that cites #29906; one item is new.POST /api/v1/actions/showcase_task/showcase_recalc_selectionwith{params:{_selectedIds}}./batchis no longer offered as a 400 door.connectorConfigis closed, and run records hold echoed secrets.failedrow after a refused send, the unreachable no-locale branch and?member=.--maxWorkers=1, a field-help variant, and a stock zh confirm specimen (sys_session.revoke_my_other_sessions, read from source only).?mode=drafton a read answers 400.sortthe platform's sortability projection refuses is still sent to the server on fetch (ListView L3186), so the list 400s instead of dropping it; client-side sorting still offers asortable: falseheader #30024), non-default probes,modalSizeand the CEL envelope.sharingModelfor a published fixture object.sys_approval_action.manage_metadatarefusal.indexesandcontextSelectors.select.studio-authoring.first-run-loopknownGaps[3] becomes a regression row (Studio in zh-CN: a new object publishes "successfully" and never reaches the data plane, because its echoed queue column carries a translated label #29673 is fixed by fix(metadata-protocol)!: an object saved back from a translated /meta read stores its source labels, and one the registry would refuse is refused at save and at publish #29790). RUNNER's console-auth fact names the Packaged Actions page; the retired Packaged Automation page now redirects to Studio.platform-core.package-export-round-trip(api + cli, P1, v18.3, active), with 7 acceptance clauses, 5 negatives, source anchors and partial automated pins. Clauses [3] and [6] cite runtime: a disabled package exports as an empty shell (GET /packages/:id/export and the whole-deployment bundle drop its items), so a re-install loses them #29871 and runtime: a package export omits the objectExtensions of a package installed through install-local, so an exported .custom pair loses its extension fields on the second export hop #29872 as fixed: both are closed completed at base, so the clauses state the fixed behaviour and name the card a regression would reopen.viewis overlay-allowed, a bare PUT answers 2xx" fact is replaced by the D11 rule. A package-less write onto a shipped name answers 403 NOT_OVERRIDABLE; the recipe is ensure-customization, then PUT?package=com.example.showcase.customwithoverrides; a fresh name still writes.workspace-timezone-prompt-decline, 'Not now'). This also lands the card's "all page items" fixture line.platform-core.manifest-install-contractsource[1] is re-pointed fromprotocol.ts#assertProtocolCompat, which no longer resolves, toprotocol-package-install.ts#installPackage. The checker refusedplatform-core.jsonat base for this anchor, and this PR edits that file.Overlap with #29819. The
studio-authoring.picklist-bound-selectfixture line (fixtures.requires[0]: the scratch copy and no--compile) lands here, so #29819 should skip it.Lines not applied (6 of the card's 66):
offclause.zh-cn-studio-save-29790, all 4 lines: no ledger item carries this off-clause, so there is nothing to re-point.studio-authoring.org-scope-flowsfixtures.requires[1]: a confirmation, and the ledger already says it. At base a fresh-name package-less PUT still writes and a shipped name answers 403, so no change.studio-authoring.permission-matrix-editor-uxA5: the card says the metadata-admin door draws no object expander on a read-only set. At base,PermissionMatrixEditor.tsxdraws the chevron expander on every object row of that door with no read-only gate, so the reading could not be confirmed and the clause is unchanged.Lines where the code at base differs from the card, applied as the code reads (8):
modalSize: the record modal's form view is the default form, or thecreateform view for a create, not only the "isDefault" form.sys_user.locale, else the deployment default, rather than alwaysen.app-and-nav-propertiessteps[1], not on each page item.Tests
Documentation and checklist only; no product code or test changes. The ledger is validated by
scripts/check-platform-checklist.mjs. Every edit was applied text-level, then re-parsed and deep-compared against the intended object before it was written.Acceptance notes
f68b47cabefore it was applied; the skipped and changed lines are named above.status: activeand its pins. The two clauses the card proposed as failing cite runtime: a disabled package exports as an empty shell (GET /packages/:id/export and the whole-deployment bundle drop its items), so a re-install loses them #29871 and runtime: a package export omits the objectExtensions of a package installed through install-local, so an exported .custom pair loses its extension fields on the second export hop #29872, both closed completed.file#symbolanchor added resolves to a declaration, and no anchor was removed.Verification
node scripts/check-platform-checklist.mjs→ exit 0 (16 areas, 360 items).node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 16 commands, and all 16 ran → exit 0.check:doc-formula-expressionsfirst exited 3 because a prerequisite was not built. I ran the build it prescribes (turbo run build --filter=@objectstack/formula --filter=@objectstack/lint), and the gate then exited 0.--ranreconciliation: 16 derived, 16 run, 0 NOT-MEASURED, 0 UNRUN (a derived zero, from recorded exit codes).origin/mainmerged once before opening (merge97ee2c53).🤖 Generated with Claude Code