Skip to content

docs(qa): re-point the wave-5 checklist lines and add the package export round-trip item - #30128

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-29906-wave5-ledger-repoint
Nov 4, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-29906-wave5-ledger-repoint

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by 田騏 · project thread

Fixes #29906

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

Each card line was re-read against the code at base f68b47ca before it was applied. 45 existing items get a revision bump and a history row that cites #29906; one item is new.

Overlap with #29819. The studio-authoring.picklist-bound-select fixture line (fixtures.requires[0]: the scratch copy and no --compile) lands here, so #29819 should skip it.

Lines not applied (6 of the card's 66):

  • offclause.zh-cn-studio-save-29790, all 4 lines: no ledger item carries this off-clause, so there is nothing to re-point.
  • studio-authoring.org-scope-flows fixtures.requires[1]: a confirmation, and the ledger already says it. At base a fresh-name package-less PUT still writes and a shipped name answers 403, so no change.
  • studio-authoring.permission-matrix-editor-ux A5: the card says the metadata-admin door draws no object expander on a read-only set. At base, PermissionMatrixEditor.tsx draws the chevron expander on every object row of that door with no read-only gate, so the reading could not be confirmed and the clause is unchanged.

Lines where the code at base differs from the card, applied as the code reads (8):

  • held-edit-leave-guard: the card's steps[2] is steps[1] at base.
  • picklist-bound-select: steps[4] names no route, so it is unchanged.
  • report-authoring-options: only steps[2] has a Joined switch; steps[0] is unchanged.
  • modalSize: the record modal's form view is the default form, or the create form view for a create, not only the "isDefault" form.
  • Email locale: the channel names the recipient's sys_user.locale, else the deployment default, rather than always en.
  • Part D [3] and [6] are fixed rather than failing.
  • The Packaged Automation fact is re-pointed to its successor, Packaged Actions, from source.
  • The "all page items" currency line lands as one RUNNER fact plus app-and-nav-properties steps[1], not on each page item.

Tests

Documentation and checklist only; no product code or test changes. The ledger is validated by scripts/check-platform-checklist.mjs. Every edit was applied text-level, then re-parsed and deep-compared against the intended object before it was written.

Acceptance notes

Verification

  • node scripts/check-platform-checklist.mjs → exit 0 (16 areas, 360 items).
  • node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 16 commands, and all 16 ran → exit 0.
    • check:doc-formula-expressions first exited 3 because a prerequisite was not built. I ran the build it prescribes (turbo run build --filter=@objectstack/formula --filter=@objectstack/lint), and the gate then exited 0.
  • --ran reconciliation: 16 derived, 16 run, 0 NOT-MEASURED, 0 UNRUN (a derived zero, from recorded exit codes).
  • origin/main merged once before opening (merge 97ee2c53).

🤖 Generated with Claude Code

… round-trip item

The 18.3.0 wave-5 re-check (QA runs #29890, #29893, #29877 and #29870, at
589049b) found checklist steps, verifies and fixtures that no longer match
the product. Each line was re-read at base f68b47c before it was applied.

- Part A (W5-FAIL): 19 items, among them the action door for the aggregate
  bulk action, the ADR-0146 D11 pair recipe for staging a shipped view or
  email template, the 'Switched on / off' wording, the Invite outcome copy
  and the per-group approval read.
- Part B (W5-STUDIO): 24 studio-authoring items, among them the Studio
  routes for the picklist fixture and the default-currency prompt.
- Part C (W5-P0): first-run-loop knownGaps[3] is a regression row since
  #29790, and RUNNER's console-auth fact names the Packaged Actions page.
- Part D (W5-EXPORT): new item platform-core.package-export-round-trip.
- RUNNER: the overlay fact now gives the D11 pair recipe, and a new fact
  covers the first-page currency / timezone prompt.
- platform-core.manifest-install-contract source[1] is re-pointed, because
  its anchor no longer resolved and the checker refused the area file.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017ihL2ebbZkr2QAEG1x7UC8
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:devx#2 · marchtian · session_017ihL2ebbZkr2QAEG1x7UC8

席位核对 — ACCEPT · domain:devx#2 · Head-sha 97ee2c53e55877706b9635ccee5fa5d690c94a05 · 2026-11-04T15:18Z

  • Shape: 9 files, all under docs/qa/platform-checklist/ (RUNNER.md and 8 area files), +561/−192 (read from the PR's files list). Not a governed path, under 3000 lines, so Tier S landing by the seat. 45 existing items re-pointed (each with a revision bump and history row) and one new item, platform-core.package-export-round-trip.
  • Premise measured: 60 of the card's 66 lines applied, 6 not applied with reasons, 8 applied as the code reads (report 6634141386). Seat spot-checks at origin/main: "Switched on" / "Switched off" is the live state vocabulary (DirectoryPage.stateVocabulary-29705.test.tsx); POST /:id/ensure-customization is mounted (packages/runtime/src/dispatcher-plugin.ts); installPackage lives in packages/metadata-protocol/src/protocol-package-install.ts and assertProtocolCompat is no longer on protocol.ts, so the re-pointed manifest-install-contract source[1] resolves.
  • Gates: every check-run on the head is success (26) or skipped (21); check-expected-skips OK, all 21 skips in main's roster. Local dispatch-gates --commands 16/16 exit 0, --ran reconciled; check-platform-checklist exit 0 (16 areas, 360 items).
  • Accepted deviations: (1) the platform-core.manifest-install-contract source[1] anchor fix was not on the card; it stays here because the checker refused the area file at base and this PR edits that file. (2) permission-matrix-editor-ux A5 is not applied: the code at base draws the expander on every row with no read-only gate, so the card's line is not adopted without a live re-check. (3) The 4 offclause.zh-cn-studio-save-29790 lines have no ledger item to land on.
  • Out of scope: three more stale lines the dev found are filed as checklist: three more stale ledger lines found while re-pointing wave 5 (dataset-editor parenthetical, package-less zh-CN template writes, builtin-apps-nav-render steps) #30129 (finding). The picklist-bound-select fixture line landed here, so checklist: give three Studio items the boot fixtures their steps need (two launch entries, one showcase picklist) #29819 skips it. Skills-docs: n/a, Metadata-protocol: none.
  • Landing: skip-changeset (docs/QA ledger only). Ready, then auto-merge through the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/l skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checklist: re-point the ledger lines the 18.3.0 wave-5 re-check measured as stale, and add an item for the whole-deployment export

1 participant