Repository navigation
fix(app-shell): Studio item header's saved-to note says where the customization lives (#30436) - #30523
Queued
objectstack-fleet[bot] wants to merge 2 commits into
Queued
fix(app-shell): Studio item header's saved-to note says where the customization lives (#30436)#30523objectstack-fleet[bot] wants to merge 2 commits into
objectstack-fleet[bot] wants to merge 2 commits into
Conversation
…tomization lives (#30436) WIP before install/build. Claude-Session: https://claude.ai/code/session_01L6bhgTL7xvsd9AqyDZgX3C Co-authored-by: Claude <noreply@anthropic.com>
Contributor
Author
|
domain:ui#5 · os-sales · session_01L6bhgVwQZbHRRM9CaXeKif 维护者速读
席位核对 — ACCEPT · domain:ui#5 · head
|
objectstack-fleet
Bot
added this pull request to the merge queue
Nov 5, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain:ui#5 · os-sales · session_01L6bhgTL7xvsd9AqyDZgX3C
Requested by Sales · project thread
Fixes #30436
What changes
SavedToCustomizationNote(ui/packages/app-shell/src/preview/savedToCustomization.tsx) takes a new optionalpairIdprop. Given one, it goes on after "Saved to X's customizations" with the publish sheet's second sentence,customizationEnvironmentText(t, pairId)(keypreview.changes.customizationEnvironment, from fix(app-shell): Studio's publish review sheet says a customization lives in this environment's database and moves only byos package export#30435): the changes are kept in this environment's database as items of the pair and reach another environment only throughos package export. It draws as its own span, testid<testId>-environment; the first span and its text are unchanged.StudioDesignSurface.tsx: the four call sites (Interfaces item header, Interfaces navigation editor, Data object header, Automations flow header) pass the pair:customization.pairId, orpairIdOf(customization.base)(the<base>.customid the first save creates) while the base has no pair yet. TwocustomizeNotePairconsts sit beside the existingcustomizeBaseLabellines; the Data object site computes it inline from its owncustomization.DraftChangesPanel.tsxis not touched. No new i18n key.Why
The item header said only where a customization is saved, while the publish sheet also says where it lives and how it moves (ADR-0146 D2). The two now say the same words from the same keys.
Verification
pnpm exec vitest run(fromui/) on the four pillar test files andDraftChangesPanel.test.tsx: 5 files, 91 tests pass. New assertions check the full English sentence namingcom.example.hotcrm.customon all four headers, including before the first save (Customize just clicked), and its absence in the CONTROL case.pnpm --filter @object-ui/app-shell run type-checkpasses;pnpm --dir ui run check:spec-symbolspasses; eslint on the touched files: 0 errors (pre-existing warnings only).dispatch-gates --commandsfamilies run and reconciled with--ran(see the card thread's report).Clause-②: no
Metadata-protocol: none
Human Minimum
packages/specholds no runtime logic.pnpm lintpasses.main, one pull request.packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.🤖 Generated with Claude Code
https://claude.ai/code/session_01L6bhgTL7xvsd9AqyDZgX3C