Repository navigation
docs(spec): say what the optional master did to the cbp-master-detail-required-defaulted notes - #31055
Queued
objectstack-fleet[bot] wants to merge 1 commit into
Queued
docs(spec): say what the optional master did to the cbp-master-detail-required-defaulted notes#31055objectstack-fleet[bot] wants to merge 1 commit into
objectstack-fleet[bot] wants to merge 1 commit into
Conversation
…-required-defaulted notes The protocol-18 conversion and the builder-force docblock still said an explicit `required: false` master is refused by the builder and the parse, and that a live author meets the parse's refusal. After #30940 (ruling A of #30905) the only `master_detail` declared `required: false` is the optional master, kept by the builder and admitted by the parse, and a raw parse reads an omitted `required` as that optional master. Comments only; the conversion's apply and fixture shapes are unchanged. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L9qibzpwEPquNhPcgrrjew
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 171 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
|
domain:spec#1 · os-tesla · session_01L9qibzzqHZdAVqgBAvxXKB 维护者速读
席位意见:可以落地。 席位核对ACCEPT · seat
|
objectstack-fleet
Bot
added this pull request to the merge queue
Nov 6, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tesla · project thread
Clause-②: no
Metadata-protocol: none
Fixes #30977
Claim: 6697140710 · Branch:
claude/project-thread-kujw5c维护者速读
cbp-master-detail-required-defaulted和构建器forceCbpMasterDetailRequired的说明里,还写着「显式required: false的主表会被构建器和解析拒绝」,现在改成按 feat(spec,security): a controlled_by_parent object may declare an optional master #30940 之后的实际规则来写。controlled_by_parent对象唯一的master_detail写required: false是合法的可选主表;旧注释会让下一个改这个转换的人按已经不存在的规则推理。required仍补成true,显式required: false仍不转换。apply与 fixture 形状一字未动。回滚即撤本 PR。skip-changeset。Stale sentences found, and how each was resolved
origin/main81deb54)conversions/entries/18/cbp-master-detail-required-defaulted.ts:56-58required: false… The builder refuses it loudly … an author the builder would have stopped"master_detailit is the optional master (ADR-0055 §1 as amended, #30905 ruling A), kept by the builder and admitted by the parse, so the stored pass keeps it too; beside anothermaster_detailthe builder still refuses it.:66-68ObjectSchema.create()andos lint'srelationship/master-detail-requiredaterror; a raw parse reads the omitted key as the optional master (the field default writesfalsefirst).:110(fixture comment):23-26master_detaildeclaredrequired: true"data/object.zod.tsforceCbpMasterDetailRequireddocblock, closing paragraphmaster_detail… so a raw parse of amaster_detailwithoutrequired: trueis refused rather than forced"master_detailas the optional master, and a raw parse is never forced (it reads an omittedrequiredafter itsfalsedefault). The paragraphs above it already carry #30940's "Read and left as is:
summarystring (:79-82): every clause is still true ("an explicitrequired: false… not converted"), so it did not change, and no printed text moved.migrations/entries/semantic/18.cbp-master-relation-tiers-retired.ts(:50-51,:69-70,:76): its text on an explicitrequired: falseis outdated, but feat(spec,security): a controlled_by_parent object may declare an optional master #30940 added18.cbp-optional-master-admitted, whosereasonsays in so many words that it "supersedes whatcbp-master-relation-tiers-retiredandcbp-master-detail-required-forcedsay of it … everything else they say stands". The D3 record is superseded by a later entry, not edited, and its strings are printed to authors; left for that reason.data/controlled-by-parent-master.tsandconversions/refused-shapes.test.ts: already updated by feat(spec,security): a controlled_by_parent object may declare an optional master #30940; nothing stale.Verification
dispatch-gates --commands: 68 derived, 68 run, all exit 0.dispatch-gates --ran: 68 accounted, 0 NOT-MEASURED. 11 of them first exited 3 (not measured) on a fresh worktree; they went green afterpnpm build, andcheck-plugin-teardown-shape --self-testafter fetching its pinned fixture commit on this shallow clone.vitest run src/conversions src/data/controlled-by-parent-master.test.tsinpackages/spec: 24 files, 842 tests passed.Acceptance notes
apply,summary,surfaceand the fixture objects are byte-identical.skip-changeset).🤖 Generated with Claude Code
https://claude.ai/code/session_01L9qibzpwEPquNhPcgrrjew