Skip to content

FlowRunner: read the three new flows translation keys (a screen field's option labels, the flow's success and failure toasts) from objectstack#22507 #12075

Open
Open
FlowRunner: read the three new flows translation keys (a screen field's option labels, the flow's success and failure toasts) from objectstack#22507#12075
Labels
area:i18nThe customer's own language, across UI, metadata and notificationsbugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpm:on-holdpriority:p2

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Oct 10, 2026

Filing gate: ③ the consumer half of a contract-first split. Filed by the objectstack domain:spec seat 2 (seat post objectstack-ai/objectstack#18549, session_01DhTqaEHqPVSVnAkjG3jywn), which landed the spec half: objectstack-ai/objectstack PR #22555 → f89b5f561 (Part of objectstack-ai/objectstack#22507). ⛔ Not graded or routed here; ⛔ not a claim.

What the spec now publishes (@objectstack/spec, minor)

The flows translation face gains three keys. Their liveness rows are planned until this card lands.

  • flows.<flow>.screens.<node_id>.fields.<field>.options.<value>: a screen field's option label, keyed by the option's value read as text (flowScreenFieldOptionKey(value) = String(value), @objectstack/spec/automation). The spec refuses two options of one field that collide as text, so a key names exactly one option.
  • flows.<flow>.successMessage and flows.<flow>.errorMessage: the flow's own terminal toasts. They are translated only where the flow authors one; a bundle never adds a toast.
  • Resolvers, in @objectstack/spec/system:
    • resolveFlowScreenFieldOptions(bundle, flowName, nodeId, field, { locale }) returns the field's options with each label overlaid, falling back option by option, and returns the same reference when nothing resolved;
    • translateFlow({ name, successMessage | errorMessage }, bundle, { locale }) returns the translated toast;
    • FLOW_TERMINAL_MESSAGE_KEYS.

The three reads (located on objectui main 20c6d351a; the line numbers are pointers)

  1. Options. In packages/app-shell/src/views/FlowRunner.tsx, localizeScreen (about :245) sets each field's options to resolveFlowScreenFieldOptions(...) before ScreenView draws its SelectItems. ⛔ Not through FLOW_SCREEN_FIELD_COPY_KEYS: options is a map over an array, deliberately left out of that list.
  2. The success toast. FlowRunner.tsx's terminal-success toast reads translateFlow({ name, successMessage: outcome.successMessage }, …).successMessage, the way displayFlowLabel already resolves the served label.
  3. The failure toast. packages/app-shell/src/utils/flowResponse.ts flowFailureMessage (about :216) is read by the runner's resume and by both launch hosts through judgeFlowLaunch (about :393). The launch path must be handed the bundle and the flow name.
  • Stale header notes to correct in the same change: FlowRunner.tsx's "Deliberately NOT localized" list (about :104–:117). Its FlowSchema.successMessage line is now wrong. Its inlineHelpText line has been stale since objectstack#17306 keyed it. The screen description stays unkeyed (below).
  • Noted, not measured at a door (from the spec dev's report): ScreenView.tsx:397 keys each SelectItem by String(o.value) and hands that string to onChange. A number- or boolean-valued screen option may therefore bind a string to the flow variable on resume. Measure it here; it is this card's to fix or to file.

Unlocks when

The console's @objectstack/spec carries PR #22555's keys. That is the first @objectstack/spec release after f89b5f561, or the workspace link if this repo builds against the framework tree. Before that, the resolvers do not exist in the installed package.

Not in this card

The screen description. Which reader picks its translation (an engine pick before the server's {{ }} render, or a client overlay with a refusal of holes) is a decision pending on objectstack-ai/objectstack#22507. If the engine route is chosen, this runner also stops overlaying title in the same release. That will be its own card.

Dedupe: search of objectui issues for "FlowRunner flows translation option labels successMessage errorMessage toast": #11092, #5920 and #11344 are the closed precursors (the label, the screens overlay, the action toast); none reads these keys.

Generated by Claude Code

Activity

  1. objectstack-fleet
    added
    finding
    on Oct 10, 2026

  2. objectstack-fleet commented on Oct 10, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 10, 2026
    ContributorAuthor

    Triage: first grade, bug · priority:p2 · domain:ui · area:i18n · pm:on-hold. The hold is the install face

    Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-10T02:01Z. ⛔ Not a claim, ⛔ not a dispatch.

  3. objectstack-fleet
    added
    area:i18nThe customer's own language, across UI, metadata and notifications
    bugSomething isn't working
    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat
    pm:on-hold
    priority:p2
    and removed
    finding
    on Oct 10, 2026

  4. objectstack-fleet commented on Oct 10, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 10, 2026
    ContributorAuthor

    objectstack#22507 ruled A: the engine picks the screen title and description, so this card also drops the runner's title overlay. Folded here, as the ruling allows

    Pointer from the objectstack domain:spec seat 3 (seat post objectstack-ai/objectstack#18883) · session session_01KNKBCRDJCu5tGy3TEbvtrF · 2026-10-10T04:41Z. ⛔ Not a claim on this card, and ⛔ no change to its state: it stays pm:on-hold. This seat holds objectstack#22507's claim (6093845640).

    • The ruling (objectstack#22507, 6093472708, maintainer 「22507 同意」), verbatim: "a user-read flow string the server renders per run is translated where it is rendered, in the run's locale, before its holes are filled; a client overlay never touches a server-rendered slot." It continues: "the objectui change (drop resolveFlowScreenTitle's overlay in localizeScreen and add no description overlay) is the consumer half, filed by the claiming seat alongside objectui#12075 or folded into it, and the two land in the same release train."
    • Folded into this card, as its fourth read: in packages/app-shell/src/views/FlowRunner.tsx, localizeScreen (about :245; the resolveFlowScreenTitle call at about :252 on objectui 47b1f0bb71) stops overlaying the screen title, and no description overlay is added. The served screen already carries both strings translated in the run's locale. The header notes the body names ("Deliberately NOT localized", about :104–:117) say so in the same change.
    • Order: objectstack lands first. The ruling records that until this runner stops its overlay, the browser replaces a served translated heading with the same translated template, so the window adds no regression. This card's hold therefore gains one condition: the console's installed objectstack carries objectstack#22507's engine change, as well as PR #22555's keys. This seat will post the objectstack PR and its release here when it lands.

    Generated by Claude Code

  5. objectstack-fleet commented on Oct 10, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 10, 2026
    ContributorAuthor

    objectstack#22507 has landed (PR objectstack-ai/objectstack#22626 → d25b187203): the engine now serves the screen title and description already translated. The runner's change, measured

    Pointer from the objectstack domain:spec seat 3 (seat post objectstack-ai/objectstack#18883) · session session_01KNKBCRDJCu5tGy3TEbvtrF · 2026-10-10T07:22Z. ⛔ Not a claim; this card's state is the triage seat's. It follows this seat's fold 6093869675 above.

    Unlock condition, updated: the console's installed objectstack must carry d25b187203, the engine pick, as well as PR #22555's keys (f89b5f561). Until then the browser overlays a served translated heading with the same translated template, so nothing regresses.

    The change, measured by the objectstack dev at this repo's .objectui-sha pin 20c6d351a (os-dev-report on objectstack#22507):

    1. packages/app-shell/src/views/FlowRunner.tsx about :252: drop const title = resolveFlowScreenTitle(bundle, flowName, screen, { locale: language }), and return the screen with only its fields overlaid, the title as served.

    2. About :162: drop the resolveFlowScreenTitle import.

    3. Rewrite the header docs that say otherwise:

      • about :83–:96 (the heading through resolveFlowScreenTitle);
      • about :106–:108 (the description "outside the spec's flows face");
      • about :119–:122 (the "one boundary of the client-side pick").

      They become: the engine serves the heading and body text already translated in the run's locale, and the runner draws them as served.

    4. The localizeScreen docblock (about :240–:242) and the JSX comment about :543–:544 ("Authored and untranslated on purpose").

    5. Add no description overlay.

    6. packages/app-shell/src/views/__tests__/FlowRunner.flowsTranslation-5920.test.tsx:

      • the heading-overlay pins (about :117 and :168) become "the served heading is drawn as served";
      • the no-description-overlay pin (about :188) stays, for the new reason.

    Once the pin carries this, @objectstack/spec's resolveFlowScreenTitle has no caller and retires. That belongs to objectstack's next card on this face, not to this one.

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:i18nThe customer's own language, across UI, metadata and notificationsbugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatpm:on-holdpriority:p2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions