Skip to content

fix(types): the six held public blocks refuse the content channels no renderer reads (objectui#10872 batch 5) - #11193

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-10872-held-blocks-children-channel
Sep 30, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-10872-held-blocks-children-channel

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of #10872
Clause-②: yes

Batch 5 of objectui#10872: the content-channel narrowing of the six held public blocks, by the objectui#9256 method. The blocks are action:button, action:icon, action:group, action:menu, element:definition-list and element:repeater, the six arms batch 4 armed by reference (PR objectui#11180). The card stays open for the rest of its remainder: record:line_items, which has no spec row, and the flat-props / envelope-key batch.

The defect

Batch 4 gave each of these blocks an arm, and each arm took BaseSchema's channels as they were.

  • { "type": "action:group", "children": [ … ] } parsed green on both faces: safeValidateSchema (which objectui validate runs) and StrictAnyComponentSchema. The same held on all six.
  • No renderer of the six reads the node's children or body, and SchemaRenderer strips both keys out of the props it spreads. So the child list rendered nothing, and nothing warned at render time.
  • A flat body was already refused (objectui#6771). Its message said "Did you mean body → children", which pointed the author at the key that did nothing.

The change

  • packages/types/src/zod/public-blocks.zod.ts, the six arms only. Each arm declares children as a by-name refusal and restates body with the same guidance. That is two retirementTombstone members fed one neitherContentChannelGuidance string, both kept members: the construct the nineteen objectui#9256 arms already use. There is no new helper and no copy of one. The message names what the block renders instead, which is where the content goes:

    • properties.actions for action:group and action:menu;
    • properties.items for element:definition-list;
    • properties.label and properties.icon for the two buttons, whose label and icon are their whole content;
    • nothing for element:repeater, which has no content channel. Its message says so.

    The module docblock's "The content channels" section is updated to match: its paragraph said these six carry no channel refusal.

  • packages/types/src/__tests__/held-block-content-channels-10872.test.ts (new, 115 tests). It covers both faces:

    • each channel is refused with invalid_type at its own path;
    • the message names the block, the method, and the channel (or says there is none), and never "Did you mean";
    • one string feeds both the issue message and the .describe() metadata;
    • every value is refused;
    • each tombstone is a member of the arm;
    • a positive control per block: its properties node parses on both faces;
    • nested in a page, the block parses without a child list and is refused with one;
    • the installed spec's PageComponentSchema refuses a node-level children on each of the six (see below).
  • Two text follow-ons that the arms made false (see Deviations). In zod-mirror-parity.test.ts, the six EXCLUSIONS reason strings and their comment said "minus the objectui#9256 channel refusals". The matching paragraph in packages/types/src/zod/README.md said "They carry no content-channel refusal".

  • .changeset/10872-held-block-content-channels.md. It declares '@object-ui/types': minor (below).

Zone 2: the PM's mechanism assumptions, each measured

  1. No renderer reads children on the six: CONFIRMED, by a runtime probe per block. This is a one-off probe and was not committed. It ran the real SchemaRenderer against the real registry. Each registered renderer was wrapped so that the schema it receives is a Proxy logging every get / has / getOwnPropertyDescriptor of children and body. Each node was rendered without, and then with, a marker child (element:text).
    • Results, per block: 0 reads of either key; the DOM was byte-identical with and without the child; the marker never rendered; 0 console warnings or errors either way.
    • The states covered were closed and opened (the action:group dropdown and action:menu opened: their items were visible), action:group inline, an empty definition list, and a repeater painting two rows from an adapter.
    • Positive control: page:card with the same child rendered the marker, and its wrapper logged 4 reads. The instrument sees a reader when one exists.
    • A body leg gave the same result: 0 reads, identical DOM.
    • The parser tier's not-a-container warning (objectui#9910) fires on all six. page:card draws none.
    • A second instrument agrees. A TypeScript compiler-API census ran one program for @object-ui/components, where all six register, on a built tree: the workspace dependencies resolved to dist/index.d.ts, with 0 diagnostics in the closure. It listed every .children / .body read in the in-package import closure of the modules that register the six (64 files). That came to 29 reads, all in src/ui/* Shadcn primitives, each destructuring React children from a Radix or HTML props type. There were 0 reads in the six renderers' modules, readProps or the action helpers.
    • The overlap PR objectui#11185, which edits the four action:* renderers, adds no read of either key. Its added lines were grepped on its head 05d9cfdfa, and the body hits there are fetch request bodies in tests.
    • No block is excluded from the narrowing.
    • These readings were taken once, and nothing in the tree re-derives them. The committed pin pins the validator's answer, not the renderers'.
  2. What the installed spec does with a node-level children: it REFUSES it. On @objectstack/spec 17.5.0, PageComponentSchema.safeParse({ type, id, children }) returns unrecognized_keys naming children for each of the six, with the message "Unrecognized key(s) on this page component: children. Before ADR-0089 D3a these were dropped silently …". The same node without children passes. The spec's page component has no node-level children at all. So this is not a second dialect: the tombstones bring objectui's face into line with the spec. The new pin's last block re-reads this from the installed spec, so a spec that starts accepting the key turns red there.
  3. The content channels: PARTLY as guessed. Each 17.5.0 row was read, and none of them declares children or body.
    • action:group and action:menu: the channel is actions.
    • element:definition-list: the channel is items.
    • action:button and action:icon: no child channel. Their content is the label and icon members, and the message names those.
    • element:repeater: no content channel. Its rows print titleField / fields values of the queried record, with no template or slot, and its message says so.
  4. The objectui#9256 construct applies to by-reference arms without a second helper: CONFIRMED. These arms are BaseSchema.extend({ type, properties: propsBag(…) }), the same shape as the nineteen objectui#9256 arms. The same two helpers apply unchanged. neitherContentChannelGuidance's fixed sentence states a TypeScript type-checker measurement, a SchemaRenderer strip and a not-a-container warning. Each of those was measured true for the six, as recorded in item 1.
  5. NAMESPACED_REFUSED_AT_TYPE does not move: CONFIRMED. git diff 37d1662 -- packages/cli/src/__tests__/registered-types-validate-ratchet-10859.test.ts is empty, and that test is green at head. No type joins or leaves refused-at-type. Draft PR objectui#11069's hunks are untouched, and that PR shares no file with this one.

Semver: minor, and why nothing published breaks

minor follows the objectui#9256 narrowing precedent: this repo's version policy forbids major in any changeset. But the narrowing is not breaking against the last release, and that was measured:

  • npm view @object-ui/types gives latest = 17.6.0, the same as packages/types/package.json.
  • The published 17.6.0 dist carries no ActionButtonBlockSchema and no action:button literal.
  • Its own safeValidateSchema refuses every one of the six types, with and without children, with invalid_union at type. A page passes as a control.
  • The batch-4 changesets are still pending in .changeset/, so batch 4 and this batch ship in one release. Across that release the accept set only widens.

This refines the claim's Clause-② reason ("narrows the published accept set"). Clause-②: yes is kept as the claim directs.

Tests and gates, at head 79b4668ae (clean tree), with exit codes captured before any pipe

  • os-verify-lock chain: pnpm --filter @object-ui/types build gives "✓ dist completeness: 1 package(s) complete (136 emitted files verified)".
  • pnpm exec vitest run packages/types/ gives "Test Files 286 passed (286) / Tests 6726 passed (6726)".
  • pnpm exec vitest run over five files gives "Test Files 5 passed (5) / Tests 321 passed (321)". The files are packages/cli/src/__tests__/registered-types-validate-ratchet-10859.test.ts, scripts/__tests__/check-handler-key-read-sites.test.ts, examples/schema-catalog/test/safe-validate-corpus-6318.test.ts, apps/console/src/__tests__/registry-inputs-spec-parity.test.ts and packages/cli/src/__tests__/validate-union-arm-selection.test.ts.
  • pnpm --filter @object-ui/types type-check runs tsc --noEmit, tsconfig.examples.json and tsconfig.test.json. tsc -p tsconfig.test.json --listFilesOnly lists the new pin, and the chain ends with VERDICT command-exit 0.
  • The pnpm --filter '@object-ui/types^...' build step the order names selects an empty closure, because @object-ui/types has no workspace dependency. pnpm answers ERR_PNPM_RECURSIVE_RUN_NO_SCRIPT (exit 1): nothing ran, and that is not a red build.
  • Node gates, all exit 0:
    • node scripts/check-changeset-presence.mjs: "4 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)";
    • pnpm check:control-bytes: OK, 9549 files;
    • pnpm check:new-line-citations: "0 new citation(s)";
    • pnpm check:handler-key-reads: "OK 139 arm(s) … 57 judged";
    • pnpm check:changeset-claims;
    • pnpm check:pending-changeset-literals;
    • node scripts/check-changeset-no-major.mjs;
    • node scripts/check-changeset-overwrite.mjs;
    • pnpm check:installed-pin-claims;
    • pnpm check:spec-symbols;
    • pnpm check:test-path-roots;
    • pnpm check:doc-types;
    • pnpm check:doc-fences;
    • node scripts/check-doc-links.mjs;
    • node scripts/check-type-check-coverage.mjs: "43/43 packages compile their tests";
    • node scripts/markdown-test-inputs.mjs --audit: "107 candidate test files, all adjudicated". This batch adds no markdown reader.
  • The self-scan for control bytes over the five changed files returns 0 lines.
  • ESLint, narrowed: pnpm exec eslint --no-inline-config --format json on the three changed TS files counted 3 files, 0 errors and 2 warnings. Both warnings are no-explicit-any in zod-mirror-parity.test.ts, already there and outside this diff's hunks.
    • Population: the three .ts files in the diff. The other two changed files are markdown.
    • Invariance: eslint --print-config shows no parserOptions.project and no projectService, so linting is not type-aware and this diff cannot move a verdict on an untouched file.
    • The repo-wide pnpm lint is declared to CI.

Ablation (one-off, trap-guarded, via ablation-replace.mjs in objectstack): the whole six-arm region at HEAD (12954 bytes) was replaced by the same region at base 37d1662 (6196 bytes), which is exactly the batch-4 arms.

  • The tool reported: anchor 1 → 0; blob 370bd3e00e51 → da78bcf5a4f5.
  • With the mutation in place, the new pin gave "Tests 66 failed | 49 passed (115)", the direction and count predicted before the run:
    • the 12 children refusals;
    • all 24 message cases;
    • the 12 one-string cases;
    • the 6 every-value children cases;
    • the 12 nested cases.
  • It stayed green, as intended, on the population count, the members (BaseSchema declares both keys), the positive controls, the spec block and the body refusal code.
  • Restore: "blob == HEAD (370bd3e00e51) and git diff HEAD is empty".
  • The pin imports the arms by relative source path, so no dist leg applies.

NOT MEASURED:

  • check:doc-snippets: PRECONDITION NOT MET (exit 2). It needs 34 packages built. This diff edits no fenced block: the two changed lines of packages/types/src/zod/README.md are prose paragraphs outside any fence, so they cannot move that gate's verdict. Declared to CI.
  • check:readme-exports: exit 1, "431 self-import(s) could not be judged", every one because another package's dist is not on disk. It reports 0 findings under packages/types (built) and "0 wrong-path, 0 fabricated". Declared to CI.

In-flight overlap, re-read at this head

  • PR objectui#11125 (head 8f9bb76f6) shares zod-mirror-parity.test.ts. git merge-tree --write-tree of this branch with its head exits 0.
  • PR objectui#11185 (head 05d9cfdfa) shares no file with this PR, and adds no channel read (Zone 2, item 1).
  • PR objectui#11069 (head a11f73347) shares no file with this PR. Its strict-face wiring agrees with this change, because both faces refuse.

Deviations (declared)

  • Surface widened by one file, packages/types/src/zod/README.md, one paragraph and one sentence. They stated the opposite of this change: that these six carry no content-channel refusal. AGENTS.md Add automated testing infrastructure and CI/CD workflows #2 requires a package README to follow the code, and batch 4's claim amendment ratified the same README paragraph as an additive fix. The file is not in this claim's file surface. It sits in commit b4be1d8 together with the census rows and the changeset, so dropping it means reverting that file's hunk, not the commit.
  • zod-mirror-parity.test.ts: only the six rows this batch moves, plus their comment. Text only: the census reads reasons for presence and length, not for content.

Acceptance notes

  • carrier: this card's flat-props / envelope-key batch. Noted, not filed. The spec's PageComponentSchema also refuses a node-level children on the four page: containers (page:card was measured in the same probe: unrecognized_keys, children). objectui accepts one there, and its renderer does read it. That is the node-level spelling of a spec container's properties.children, the same class as the flat keys that batch holds, and it is not this batch's to decide.

Governed surfaces: none. This PR does not touch any governed surface: node scripts/check-governed-queue-guard.mjs --test reports "NOT GOVERNED — 5 path(s) checked".

Implemented in session https://claude.ai/code/session_0122Knsowci76D2rBWReCzzZ.


Generated by Claude Code

… renderer reads (objectui#10872 batch 5)

`action:button`, `action:icon`, `action:group`, `action:menu`,
`element:definition-list` and `element:repeater` took `BaseSchema`'s
channels as they were when batch 4 armed them: a node-level `children`
parsed green on both faces and rendered nothing, and a flat `body` was
refused with a remedy naming `children`.

Each arm now declares `children` as a by-name refusal and restates `body`
with the same guidance (the objectui#9256 construct, unchanged:
`retirementTombstone` fed one `neitherContentChannelGuidance` string).
The message names the block's real content channel inside `properties`
(`actions`, `items`, the label and icon) and says so where there is none
(`element:repeater`). The spec's own page component refuses the same key.

Pinned by held-block-content-channels-10872.test.ts, on both faces.

Claude-Session: https://claude.ai/code/session_0122Knsowci76D2rBWReCzzZ
Co-authored-by: Claude <noreply@anthropic.com>
…six arms' channel refusals (objectui#10872 batch 5)

The zod-mirror-parity EXCLUSIONS rows of the six batch-4 arms, and the zod
README paragraph on them, said the arms carry no content-channel refusal;
both now describe the refusals batch 5 adds. The changeset declares the
narrowing (`minor`, Clause-②: yes) and records why it breaks no published
document: the six arms are unreleased, and in `@object-ui/types` 17.6.0
every node of these types is refused at `type`.

Claude-Session: https://claude.ai/code/session_0122Knsowci76D2rBWReCzzZ
Co-authored-by: Claude <noreply@anthropic.com>
…tui#10872)

`tsc -p tsconfig.test.json` lost the tuple element types through a spread of
`slice(1)`; the cases are now built by destructuring.

Claude-Session: https://claude.ai/code/session_0122Knsowci76D2rBWReCzzZ
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation package: types tests labels Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 14 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/5903-objectgantt-declared-keys.md

  • names packages/types/src/__tests__/zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    ⚠️ The JUSTIFICATION for that parity clause was retired (objectui#9743); the clause itself stands and did not move. As first written it credited the zod-mirror-parity ratchet with a zero-drift reading for this pair — but at that time the ratchet measured three directions and was structurally blind to the MIRRORED-but-undeclared one (objectui#9711), so a zero from it recorded that it had not looked in that direction, not that nothing was there. objectui#9725 landed the fourth direction, and it covers this pair BY NAME: packages/types/src/__tests__/zod-mirror-parity.test.ts registers objectql.zod.ts#ObjectGanttSchema in both its mirror map and its declaration map; assertionMirroredUndeclaredMatchesLedger requires every registered pair's mirrored-but-undeclared key set to equal that pair's MirroredUndeclared ledger entry — never for a pair the ledger does not name — and assertionNoVacuousMirroredUndeclaredMeasurement refuses a measurement that has degenerated to any. ⛔ Read this pair's verdict off that reconciliation, which re-derives it on every run, rather than off any figure written here; when this paragraph was authored, on 2026-09-18, it required no MirroredUndeclared entry for the pair.

.changeset/5928-classname-style-props-rename.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    Where the non-pair is recorded now. zod-mirror-parity.test.ts keys its existing EXCLUSIONS entry — the mechanism that accounts for every exported const with no TypeScript declaration to mirror, each with its stated reason — to ClassNameStylePropsSchema. Named for its own two keys, the const leaves no like-named declaration for a name-derived pairing to reach for.

.changeset/6051-gantt-flat-config-declared-keys.md

  • names packages/types/src/__tests__/zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    ⚠️ The JUSTIFICATION for that parity clause was retired (objectui#9743) — the same retirement objectui#5903's entry carries, for the same clause and the same reason; the clause itself stands and did not move. As first written it credited the zod-mirror-parity ratchet with a zero-drift reading for this pair, at a time when that ratchet measured three directions and was structurally blind to the MIRRORED-but-undeclared one (objectui#9711), so a zero from it recorded that it had not looked in that direction. objectui#9725 landed the fourth direction, and it covers this pair BY NAME: packages/types/src/__tests__/zod-mirror-parity.test.ts registers objectql.zod.ts#ObjectGanttSchema in both its mirror map and its declaration map; assertionMirroredUndeclaredMatchesLedger reconciles every registered pair's mirrored-but-undeclared key set against that pair's MirroredUndeclared ledger entry — never for a pair the ledger does not name — and assertionNoVacuousMirroredUndeclaredMeasurement refuses a measurement that has degenerated to any. ⛔ Read this pair's verdict off that reconciliation, which re-derives it on every run, rather than off any figure written here; when this paragraph was authored, on 2026-09-18, it required no MirroredUndeclared entry for the pair.

.changeset/6150-undeclared-but-consumed-keys.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    ⭐ AMENDED, and the amendment ships in this same release. The TreeViewSchema slice (604476d97) gave the key a zod arm after all — a NAMED REFUSAL (handlerKeyRefusal(key, 'runtime-slot', label)), never a shape — because "no mirror entry" is not neutral under BaseSchema.passthrough(): it meant an authored { "type": "tree-view", "onNodeClick": { "action": "toast" } } parsed GREEN, survived the parse, and reached a call site that expects a function. ⇒ the three clauses this bullet used to carry are no longer true of the code shipping beside it. The key is now a MEMBER of TreeViewSchema.shape and an authored value is refused BY NAME at path onNodeClick; it has LEFT zod-mirror-parity.test.ts's RuntimeOnlyDeclared for that file's KnownDrift; and it is no longer "the first pair to sit there without also sitting in UnmirroredDeclared" — draining it emptied that difference, so RuntimeOnlyDeclared is now a SUBSET of UnmirroredDeclared and the union of the two equals UnmirroredDeclared itself. ⛔ objectui#6152's ruling is untouched by any of this: what the key still does not have, and never will, is a z.function() shape — no serialized document could satisfy one.

.changeset/6175-column-state-persistence.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    Nothing is retired. Both spellings remain declared on DataTableSchema; onColumnReorder stays declared and stays unwired, exactly as the RuntimeOnlyDeclared ledger in zod-mirror-parity.test.ts records it. Which of the two survives is a declared-surface ruling that stays open and is deliberately not settled here.

.changeset/6639-objectgrid-title-mirrored.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    The gain is the typed refusal: the mirror's .passthrough() base was already admitting any title unexamined, and it now enforces the declared string. zod-mirror-parity.test.ts's UnmirroredDeclared ledger records the key as worked off — the ledger's first shrink by repair (97 + 1 mirrored + 23 reclassified is what the seeded "121" now means).

.changeset/7344-handler-string-any-mirrors.md

.changeset/7654-floating-chatbot-trigger-icon-tombstone.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    Every other tombstone in this package pairs ?: never with a retirementTombstone() refusal on the Zod twin. There is no twin here to carry one: FloatingChatbotConfig has no Zod mirror at all, and floatingConfig sits in the UnmirroredDeclared ledger (zod-mirror-parity.test.ts, complex.zod.ts#ChatbotSchema). BaseSchema is .passthrough(), so the whole floatingConfig object rides through unvalidated — before this change and after it. Minting a mirror to host a refusal would be the declared-but-UNMIRRORED axis (objectui#6152), a different defect: a key can be mirrored and inert, or unmirrored and live, and fixing one says nothing about the other. This change does not widen into it.

.changeset/7804-tree-view-handler-slot.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    The pair moves from zod-mirror-parity.test.ts's RuntimeOnlyDeclared to its KnownDrift, which empties the former of the one entry the latter did not also hold — so the two unmirrored ledgers are now in a containment relation, and the cross-ledger figure that recorded their difference states the containment instead.

.changeset/8338-retire-toast-action.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    The parity ledgers drain with it, every figure re-derived by zod-mirror-parity.test.ts's own AST and mirror instruments rather than stepped by hand: KnownDrift 42 entries / 64 keys → 41 / 63 (the entry's whole content, so the entry went too — the ledger's first loss by RETIRING a key rather than by moving either face toward the other), and WiderThanDeclared 23 / 36 / 47 arms, split 6 / 30 / 0 / 11 → 22 / 35 / 45, split 6 / 29 / 0 / 10. The pair itself stays registered, so EXPECTED_MIRROR_PAIRS does not move.

.changeset/8344-node-recursion-point-redirect.md

  • names zod/public-blocks.zod.ts → packages/types/src/zod/public-blocks.zod.ts — edited by this change

    ⚠️ Dated note, 2026-09-28 — a second category module — objectui#10872. Later still in this same release zod/public-blocks.zod.ts joins them as well and imports zod/base.zod.ts too, so both counts in the mechanical note above are two higher, not the one the objectui#10859 note says; the reason the arm cannot be an import is unchanged. The rest of this entry, and that note, are kept as their readings.

.changeset/8572-chatbot-body-retired.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    Why this key and not another. It was the ONE place in this vocabulary where body did not mean "what goes inside this component": zod-mirror-parity.test.ts carried the pair under KnownDrift as "two different meanings of one key", and the same collision was the whole reason chatbot was the single arm of the component union whose output was not assignable to SchemaNode. Both ledger rows move with this change, and the two pins that recorded the old state are INVERTED rather than deleted (see below).

.changeset/9511-record-id-is-a-string.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    ⭐ The declaration alone would not have been enough, and this is the reusable part. A TypeScript declaration does not run at parse time. The hand-written zod mirror is the only face in this repository that can refuse an authored number, so narrowing the declaration without the mirror would have shipped declared !== enforced on a published surface — and zod-mirror-parity.test.ts would have stayed GREEN through it, because that instrument asserts a mirror accepts everything its declaration declares and a mirror left WIDER passes. Both faces moved together for that reason.

.changeset/object-view-unmirrored-keys-7779.md

  • names zod-mirror-parity.test.ts → packages/types/src/__tests__/zod-mirror-parity.test.ts — edited by this change

    Who is NOT affected: every correctly typed document, and every document that never wrote these keys — absent stays valid on all nine. No renderer changed. The parity ledger (zod-mirror-parity.test.ts) records the move: UnmirroredDeclared 14 entries / 96 keys to 14 / 87, the ObjectViewSchema entry re-derived into the SPEC-DERIVED half because the mirror now references the spec in code.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 81778b955 (merge-base with origin/main): 4 file(s) changed outside .changeset/, read against 1796 pending declaration(s) that publish a body (2403 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 330 chunks) 3570.6 KB 3607.4 KB
Main entry chunk (gzip) 149.5 KB 350 KB
Entry file index-Dae8r6kp.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.88KB 6.25KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.17KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 559.46KB 134.18KB
core (index.js) 9.94KB 3.94KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 227.28KB 63.04KB
fields (index.js) 261.19KB 66.27KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.35KB 9.18KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.32KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.58KB 4.90KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.25KB 2.17KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 52.17KB 15.06KB
plugin-charts (index.js) 84.09KB 22.93KB
plugin-chatbot (index.js) 198.22KB 46.97KB
plugin-dashboard (index.js) 138.73KB 37.05KB
plugin-designer (index.js) 215.78KB 44.42KB
plugin-detail (index.js) 234.78KB 62.36KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 172.30KB 44.19KB
plugin-gantt (index.js) 172.43KB 42.85KB
plugin-grid (index.js) 230.25KB 63.22KB
plugin-kanban (index.js) 48.43KB 15.11KB
plugin-list (index.js) 115.82KB 28.67KB
plugin-map (index.js) 22.90KB 7.62KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.04KB 12.21KB
plugin-timeline (index.js) 32.26KB 9.42KB
plugin-tree (index.js) 11.21KB 3.89KB
plugin-view (index.js) 90.43KB 22.76KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 119.55KB 39.23KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 6.17KB 2.73KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 22.61KB 7.40KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 3.83KB 1.49KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 3.19KB 1.62KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.26KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.82KB 7.15KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 79b4668aeada59f27a803fb99d6992d4c8126baa
Local-runs: none

PR objectui#11193 (draft, Part of #10872, batch 5 of the card), base 81778b955, 5 files, +398 / −24. Read: the card body and all 36 comments, the PR body, its file list and the net diff, and the check-runs on the head. Source was read at refs only (git show of the head, of the 17.5.0 spec tag 0f6dcac5e9, and of origin/main history); nothing was built, run or re-run. Judged in isolation from the dispatch order and from the seat's own conclusions.

① Derived judgments

Each accept-set or public-surface change the diff implies, with a verdict.

  1. children on the six arms (action:button, action:icon, action:group, action:menu, element:definition-list, element:repeater): accepted → refused. Before, each arm took BaseSchema.children (base.zod.ts:391, a node or a node list, optional). After, each declares children: retirementTombstone(…) (tombstone.zod.ts:64–66: z.never({ error }).optional().describe(guidance)), so any present value is refused with invalid_type at children, on the tolerant face (safeValidateSchema, so objectui validate) and on the strict face (built over the same arms), and nested inside a page; an absent key stays valid, so every document that never wrote it keeps parsing. RIGHT, on three readings of my own:
    • No renderer reads the channel, by any route. The five renderer files at the head (renderers/action/action-{button,group,icon,menu}.tsx, renderers/basic/data-list.tsx) contain no read of children or body; the only hits are comments about request bodies. readProps (readProps.ts:69–74) merges only the props and properties bags, never the node. The ...rest that action:group (:217–227) and action:menu (:200–210) spread onto their DOM wrapper is derived from the React props, and SchemaRenderer.tsx:2049–2052 strips children and body from those props before spreading. So a node-level children cannot reach a render by a named read or by a spread.
    • The spec refuses the same key. PageComponentSchema at the 17.5.0 tag (page.zod.ts:266–462) is a strictObject whose members are type, id, label, properties, events, style, className, responsiveStyles, visibleWhen, visibility, dataSource, responsive, aria — no children — so a node-level children is unrecognized_keys there on every one of the six. The refusal aligns objectui's face with the spec; it is not a second dialect.
    • No tracked producer is broken. 98 files at the head name one of the six types; the only children keys within six lines of such a node belong to a parent container's list (for instance content/docs/guide/layout.md:546, a flex holding action:button members). None places children on a six-type node.
  2. body on the six: refused → refused, message changed. BaseSchema.body (base.zod.ts:380–386, the objectui#6771 alias refusal, "Did you mean body → children") is restated as body: retirementTombstone(…) with the same guidance string as children. Same code (invalid_type), same path, accept set unmoved; only the text moves. RIGHT: after item 1 the old remedy would send the author to a key the same arm refuses (the batch-3 lesson on record:alert, 5873869262).
  3. The refusal messages name the block's real content channel, checked against the 17.5.0 ComponentPropsMap rows in packages/spec/src/ui/component.zod.ts at 0f6dcac5e9, none of which declares children or body:
    • action:button (row :2836–2886: name, label, icon, actionType, variant, size, visible, disabled, params, description, target, openIn, the api keys, confirmText, …, onSuccess, objectName) → message names properties.label and properties.icon and says there is no child slot. RIGHT.
    • action:icon (:2917–2967, the same family less size, undoable, recordIdField) → properties.icon, properties.label. RIGHT.
    • action:group (:3029–3055: actions, display, location, label, icon, variant, size, visible) → properties.actions. RIGHT.
    • action:menu (:3085–3103: actions, label, icon, variant, size, visible) → properties.actions. RIGHT.
    • element:definition-list (:3136–3166: items of { term, description }, columns, inline) → properties.items. RIGHT.
    • element:repeater (:3208–3248: object, titleField, fields, filter, sort, limit, emptyText, divided; no template and no slot) → "NO content channel". RIGHT.
      The route clauses inside the messages are true to source as well: action-button.tsx reads schema.label / icon / actionType / target / name (:123, :138, :215–222, :386–387); action-group.tsx reads schema.actions / display / icon / label and draws each member itself (:248, :346–365); DefinitionListRenderer and RepeaterRenderer are schema: any renderers reading readProps(schema) and className (data-list.tsx:41–57, :96–186).
  4. Public surface. No export is added or removed. Six exported arms change shape: two members replaced by tombstones, and both members' .describe() metadata is now the one guidance string per block (the pin's one-string cases hold this). PublicBlockComponentSchema, AnyComponentSchema and StrictAnyComponentSchema narrow by exactly item 1. NAMESPACED_REFUSED_AT_TYPE does not move: the ratchet file is not in the diff, and no type literal joins or leaves. RIGHT.
  5. The construct. Per arm, two retirementTombstone members fed one neitherContentChannelGuidance(node, route, renders) string (tombstone.zod.ts:275–282), the construct the objectui#9256 arms above them in the same module already use; no new helper, no copy. RIGHT. One text observation, not a defect of this diff: the helper's fixed sentence says the reading was taken "over one program per workspace package on a BUILT tree", while for these six the dev's census was one program (@object-ui/components, where all six register) plus a runtime probe through the real SchemaRenderer and registry. The conclusion holds (item 1); the sentence over-describes the census breadth by one clause. It is the shared helper's text, outside this batch's surface; recorded for the seat.
  6. The new pin held-block-content-channels-10872.test.ts: 115 tests as declared (1 population, 24 refusal-code cases, 24 message cases, 12 one-string, 12 every-value, 12 member, 12 positive controls, 12 nested, 6 installed-spec cases — counted from the file). It imports the arms by relative source path (no dist leg) and PageComponentSchema from @objectstack/spec/ui, so the last block re-reads the spec's verdict from the installed package. It pins the validator's answer, not the renderers', and its docblock says so. RIGHT.
  7. Text follow-ons. The module docblock's "content channels" section (the paragraph saying the six carry no channel refusal is replaced), the six EXCLUSIONS reasons and their comment in zod-mirror-parity.test.ts (that census reads reasons for presence and a length of 20 characters or more only, :4536, :4568, so the edit is text that cannot move a verdict), and two prose sentences in packages/types/src/zod/README.md. Each stated the opposite of the code at this head; each is now true of it. RIGHT. The diff adds no import to public-blocks.zod.ts, so the pending 8344 changeset's module-count note stays true.

② Semver level

  • Changeset .changeset/10872-held-block-content-channels.md declares '@object-ui/types': minor. RIGHT, on both readings:
    • Against main (base 81778b955) the diff narrows the accept set on six exported arms. This repository's policy (scripts/check-changeset-no-major.mjs: one fixed group; a breaking change ships as minor with the break spelled out) makes minor the arm, as the objectui#9256 precedent .changeset/9256-public-blocks-content-channels.md declared for the same construct. Not patch: batch 3's patch (10872-record-alert-body-remedy.md) was a message-only change with the accept set unmoved; here the accept set moves.
    • Against the last published release, what I could measure is git, not npm: the newest @object-ui/types CHANGELOG section (17.6.0) entered at 34bfd6060 (2026-09-25); public-blocks.zod.ts was created at 6a7f24e92 (batch 1, 2026-09-28); the batch-4 commit e978ed5ea is not an ancestor of 34bfd6060; the batch-4 changeset 10872-held-public-block-arms.md is still pending at the head (no changeset version has consumed it), as are batches 1–3's; and the newest @object-ui/types@* tag in the clone is 17.5.0, older still. So no published or version-bumped state of the package has ever carried an arm for any of the six, and whichever of 17.5.0 or 17.6.0 is latest, every one of the six types is refused at type there (the card body's 418-of-419 reading was taken on that same pre-module state). The changeset's claim that no published version ever accepted a children on these nodes, and that across the release the accept set only widens, is TRUE on this evidence. Not measured by me: the npm registry's latest and any tarball; the "17.6.0 (npm latest)" figure is the dev's. The conclusion does not depend on which of the two is latest.
  • Prose. The body separates the diff's effect against main (a narrowing, "Clause-②: yes (narrowing)") from the release's net effect (a widening), states what moves in observable terms per channel and per block, names the spec's own refusal, and gives a migration. Consistent with the diff. RIGHT.
  • Clause-②: yes (PR body and claim 5907874732): RIGHT. The line answers whether this diff refuses something the repository accepts today; it does, on six exported arms, on both faces, so the at-tier review is owed — and the claim owes it on the changeset face regardless. The dev's refinement (the arms are unreleased; the release nets to a widening) is a semver observation, correctly placed in the changeset body, not a reason to flip the line.
  • Gates on the head: Changeset Bump Policy, Changeset Declaration, Changeset Fixed Group Check, Changeset Overwrite Report and Changeset Claim Re-read are all success. The re-read comment (5908603249) lists 14 pending changesets naming a touched file; I read each quoted paragraph against the diff: 13 are parity-ledger or otherwise unrelated paragraphs this diff does not move, and the 8344 note counts module imports, which this diff leaves unchanged. None is falsified.

③ Boundary flags

Every dev flag (PR body "Deviations" and report 5908656759), answered:

  1. README surface widening (packages/types/src/zod/README.md, +2 / −2 prose outside any fence; not in the claim's file surface). Answered — accepted. The two sentences asserted that the six carry no content-channel refusal, false at this head; AGENTS.md Add automated testing infrastructure and CI/CD workflows #2 (a package README follows its code) applies, and the batch-4 amendment 5905916922 ratified the same paragraph as an additive consumer fix. The hunk is isolated in b4be1d833 as declared. Seat action: ratify in the ACCEPT as batch 4's amendment did; nothing in the diff changes.
  2. zod-mirror-parity.test.ts edited past "only where a row this batch moves forces it" — six reason strings and their comment, text only, no test forced it. Answered — accepted. The six rows ARE the rows whose arms this batch moves; their reasons ("minus the objectui#9256 channel refusals") became false; the census reads reasons for presence and length only (①7), so the edit cannot move a verdict; the region is the batch-4 block the seat granted in 5905916922, and the claim placed PR objectui#11125's holding in the object-form region. The dev's git merge-tree reading against feat(types): the object-form zod mirror declares the members its TypeScript twin declared (objectui#6152, round 1) #11125 (8f9bb76f6, exit 0) is the dev's, not mine. Seat action: ratify together with item 1.
  3. pnpm --filter '@object-ui/types^...' build exits 1 (ERR_PNPM_RECURSIVE_RUN_NO_SCRIPT, empty closure). Answered — not a red. @object-ui/types has no workspace dependency; Test (dist pins), Type Check and Build & E2E are success on the head.
  4. Pin file name (held-block-content-channels-10872.test.ts rather than the suggested …-children-channel-…). Answered — immaterial. It pins both channels, and its name says so.

Dev "NOT MEASURED": check:doc-snippets and check:readme-exports. Answered by the head's check-runs: Doc Snippet Type Check success, README Export Check success.

open_questions in 5908656759: none. Nothing to escalate from the report.

Acceptance note / out-of-scope finding (carrier: this card's flat-props / envelope-key batch): the spec's PageComponentSchema also refuses a node-level children on the four page: containers, while objectui accepts it there and page:card's renderer reads it. Answered — correctly routed, not this batch's. The card's rulings (5862923926, 5866125199, 5906747518) hold that batch as a later, separate one, and this diff does not touch the containers. Seat action: carry it into that batch's order as the node-level spelling of a spec container's properties.children.

Zone 2 assumptions (five, each measured by the dev): every one I could re-read from source holds (①1–3). The runtime probe and the TypeScript census are one-off and uncommitted; the committed pin records the validator's answer, not the renderers', and says so — the objectui#9256 shape.

In-flight overlap, re-read against the claim's serial line: PR objectui#11125 shares zod-mirror-parity.test.ts in a different region (dev merge-tree exit 0, unverified by me); PR objectui#11185 shares no file (it edits the four action renderers; my reading of the head's renderers is ①1); PR objectui#11069 shares no file. Nothing contradicts the claim.

Check-runs on 79b4668ae, read at 2026-09-30T09:57:29Z: 43 runs — 39 success, 3 skipped (dependabot and the two coverage matrix rows, the expected skips), 0 failure, and 1 in_progress: the Test aggregate (started 09:57:19Z), which rolls up the eight Test (shard N/8) runs, all eight of which are success. It had not concluded at this reading; the seat reads convergence separately. Type Check and Spec Main Shape Gate, in progress at my first read, have since concluded success.

PR state: draft, mergeable_state: behind (main moved after the base). A state, not a contract finding.

Implemented-by: claude/issue-10872-held-blocks-children-channel
Reviewed-by: session_0122Knsowci76D2rBWReCzzZ

VERDICT: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation package: types tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants