Skip to content

feat(app-shell,types,i18n,cli): cloud:workspace-timezone-notice names the seeded workspace timezone on the welcome page (objectui#11930) - #11960

Merged
objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-11930-workspace-timezone-notice
Oct 8, 2026
Merged

objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-11930-workspace-timezone-notice

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #11930
Clause-②: yes

The objectui half of objectstack-ai/cloud#2676 step 3. A registered SDUI widget, cloud:workspace-timezone-notice, prints one line on the Cloud welcome page naming the timezone a workspace was seeded with at creation. It reads the additive workspaceTimezoneSeed from the org-scoped GET /api/v1/cloud/environment-entitlements summary, the one cloud:plan-status and the environment list already read. It renders nothing when that field is absent.

File surface. The claim (6057491447) was amended by the seat in 6058827980 (option A), after the dev's stop report 6058785780. The amendment adds packages/app-shell/package.json (sideEffects only), packages/app-shell/src/environment/entitlements.ts, the @object-ui/types arm files and their tests, and one row of the CLI ratchet. It also adds @object-ui/types (minor) to the Clause-② widening. Precedent: 24d3e656 (objectui#10990, cloud:plan-status) touched the same file set.

Every widening, checkable from this body

Spelling note: the platform sanitizer eats angle-bracket fragments, so generics are written in words below ("Record of string to never").

1. Language-pack key — @object-ui/i18n (minor)

One new key, cloudWorkspaceTimezoneNotice.seeded, in all ten packs (ar de en es fr ja ko pt ru zh). Each pack has one interpolation, the i18next placeholder named zone, which is written as ZONE below. No other key was added, changed or removed.

pack value (ZONE = the placeholder zone)
en The workspace timezone was set to ZONE from your browser when the workspace was created. You can change it in Settings → Localization.
zh 工作区时区在创建时已按你的浏览器设为 ZONE,可在「设置 → 本地化」中修改。 (the cloud seat's suggested copy, plus a full stop)
ja ワークスペースのタイムゾーンは、作成時にブラウザーに合わせて ZONE に設定されました。「設定 → ローカリゼーション」で変更できます。
ko 워크스페이스 시간대는 생성 시 브라우저에 맞춰 ZONE(으)로 설정되었습니다. 설정 → 현지화에서 변경할 수 있습니다.
de Die Zeitzone des Workspace wurde beim Erstellen anhand Ihres Browsers auf ZONE festgelegt. Sie können sie unter Einstellungen → Lokalisierung ändern.
es La zona horaria del espacio de trabajo se configuró en ZONE a partir de su navegador al crearlo. Puede cambiarla en Configuración → Localización.
fr Le fuseau horaire de l’espace de travail a été défini sur ZONE d’après votre navigateur lors de sa création. Vous pouvez le modifier dans Paramètres → Localisation.
pt O fuso horário do workspace foi definido como ZONE com base no seu navegador quando ele foi criado. Você pode alterá-lo em Configurações → Localização.
ru Часовой пояс рабочего пространства был задан по вашему браузеру при его создании: ZONE. Его можно изменить в разделе «Настройки → Локализация».
ar تم تعيين المنطقة الزمنية لمساحة العمل إلى ZONE وفقًا لمتصفحك عند إنشائها. يمكنك تغييرها من الإعدادات → التوطين.

The zone is printed verbatim: it is an IANA id, and no Intl call formats it. Each pack reuses its own existing vocabulary for "workspace timezone", taken from its workspaceTimezonePrompt block, and its own word for "Settings". "Settings → Localization" is the Setup nav entry nav_settings_localization (objectstack platform-objects).

2. Newly accepted type — @object-ui/cli (minor) and the validator

  • KNOWN_SCHEMA_TYPES (packages/cli/src/utils/known-schema-types.ts, GENERATED) gains exactly one row, 'cloud:workspace-timezone-notice', so objectui check accepts it. It was regenerated with node scripts/regenerate-known-schema-types.mjs, and --check reports OK. There is no bare workspace-timezone-notice row and no app-shell:-prefixed twin, because the registration is { namespace: 'cloud', skipFallback: true }, the same as cloud:plan-status.
  • objectui validate / safeValidateSchema: AnyComponentSchema now claims the literal (section 4). The CLI ratchet registered-types-validate-ratchet-10859 keeps NAMESPACED_REFUSED_AT_TYPE at 360 and gains the row "counts cloud:workspace-timezone-notice armed — it registered WITH its arm (objectui#11930)".

3. New @object-ui/types exports (minor), with their shapes

  • @object-ui/types/zod (zod/index.zod.ts re-exports from zod/cloud.zod.ts): CloudWorkspaceTimezoneNoticeSchema

    BaseSchema.extend({
      type: z.literal('cloud:workspace-timezone-notice'),
      properties: z.strictObject({}).optional(),   // the widget reads no prop: the only bag accepted is {}
      body: retirementTombstone(CLOUD_WORKSPACE_TIMEZONE_NOTICE_NEITHER_CHANNEL),
      children: retirementTombstone(CLOUD_WORKSPACE_TIMEZONE_NOTICE_NEITHER_CHANNEL),
    })

    The members are the keys the widget reads, and no others. @objectstack/spec has no ComponentPropsMap row for a cloud: widget, so nothing is read by reference. The closed empty bag is the spelling element:divider uses for a node with no prop. Both content channels are refused by name, and the refusal text carries the family-D parser-tier clause that content-channel-parser-tier-clause-10928 pins.

  • @object-ui/types (root, re-exported from cloud.ts): the TS twin, interface CloudWorkspaceTimezoneNoticeSchema extends BaseSchema with members type: 'cloud:workspace-timezone-notice', properties? typed Record of string to never, body?: never and children?: never. Its parity pair cloud.zod.ts#CloudWorkspaceTimezoneNoticeSchema is registered in zod-mirror-parity.test.ts, where EXPECTED_MIRROR_PAIRS goes from 194 to 195.

4. Union members

  • AnyComponentSchema (zod) gains one member, CloudWorkspaceTimezoneNoticeSchema, after CloudPlanStatusSchema. Its accept set widens by exactly that literal. StrictAnyComponentSchema is derived from it, so it follows with no edit. any-component-emit-headroom-11573.test.ts lists the member as an inline arm, and the declaration-size headroom test stays green.
  • AnySchema (TS) gains one member, CloudWorkspaceTimezoneNoticeSchema, after CloudPlanStatusSchema.
  • Nothing that parsed before is refused now.

5. The changeset — .changeset/11930-workspace-timezone-notice.md

Four minor entries and nothing else: @object-ui/app-shell, @object-ui/types, @object-ui/i18n and @object-ui/cli. There is no major (check-changeset-no-major OK).

6. @object-ui/app-shell (minor)

  • It registers the widget, CloudWorkspaceTimezoneNotice, from console/home/CloudWorkspaceTimezoneNotice.tsx. The entry src/index.ts gains one side-effect import beside the CloudPlanStatus.js import.
  • sideEffects (a published contract field) gains ./dist/console/home/CloudWorkspaceTimezoneNotice.js and ./src/console/home/CloudWorkspaceTimezoneNotice.tsx. Nothing else in package.json moved. check:side-effects-array reports that the array "names exactly the 16 module(s) that register at load time".
  • Built-entry declarations, measured: dist/index.d.ts keeps the new side-effect import, so the widget's .d.ts (CloudWorkspaceTimezoneNoticeProps with className?: string, and the component function) is in the declaration closure. exports has only ., so no new name is importable. A walk of the .d.ts import graph from dist/index.d.ts reaches 175 files and not environment/entitlements.d.ts. So the hook's widened result type is package-internal.
  • EnvironmentEntitlementsSummary and EnvironmentEntitlementsState (environment/entitlements.ts) each gain workspaceTimezoneSeed?: string. The hook reads it verbatim, as it reads upgradeUrl. The row-derived and unknown fallback states never carry it.

Behaviour

  • Seed present: one p element, text-sm text-muted-foreground, with data-workspace-timezone-notice="seeded". The node's className / responsiveStyles scope class reaches it. It is text only: no link (cloud#2676 Q2) and no dismissal state.
  • It renders nothing when the summary has no seed or an empty one, while loading, when the request fails (non-OK), when the request rejects, and when the body is not the { success, data } envelope (cloud#1046). It never throws: the hook swallows the failure and falls back to the rows, which carry no seed.

Verification

All of these ran from the worktree root. Heavy runs went through the shared os-verify-lock.

  • After merging main 70e3d77 (merge commit 113443d, no conflict; zod-mirror-parity.test.ts auto-merged):
    • the widget pin, the arm pin, zod-mirror-parity, any-component-emit-headroom-11573 and the CLI ratchet: 5 files, 94 tests passed;
    • regenerate-known-schema-types --check: OK;
    • check:side-effects-array: OK;
    • type-check for @object-ui/types, @object-ui/app-shell, @object-ui/i18n and @object-ui/cli: all exit 0, after building their dependency closures.
  • On 4929b50, before the merge:
    • packages/types/: 360 files, 9615 tests;
    • packages/i18n/: 82 files, 1316 passed and 13 skipped;
    • packages/cli/: 25 files, 370 tests;
    • packages/app-shell/, NARROWED: 27 files, 209 tests. The full package is 1166 files and belongs to CI. The 27 are console/home/__tests__/, environment/__tests__/ and every test that reads the hook, the summary endpoint, cloud:, sideEffects or the barrel;
    • 13 root scripts/__tests__ files that read the touched files: 811 tests.
  • Gates on 4929b50: these were all green: check:control-bytes, check:test-path-roots, check:i18n-keys, check:i18n-drift, check:i18n-dead-keys, check:i18n-designer-parity, check:pending-changeset-literals, check:changeset-claims (report-only), check:readme-exports, check:eager-locale-catalogues, check:sdui-registration-pins (workspace-timezone-notice is present in 1 chunk) and check-changeset-presence. eslint on the 24 touched .ts/.tsx files gave 0 errors. The config is not type-aware, and repo-wide lint is CI's.
  • Reverse checks used ablation-replace in wrap mode, with a trap and absolute paths. Every subject resolves to src, through relative imports and the vitest alias for @object-ui/types/zod, so no dist is involved. Each mutation was restored to the HEAD blob, and the tool proved the restore.
    • A, the widget ignores the seed: 5 of the widget file's 12 tests go red, exactly the seed-present pins (EN, ZH, endpoint, one line, SchemaRenderer). The absent, empty, loading, failed, rejected and bare-body controls stay green.
    • B, the hook drops the field: the same 5 go red.
    • C, the arm leaves the union: 12 go red, including the ratchet's "objectui validate refuses 361 registered namespaced key(s) at type; the pin is 360".
  • First-load bytes: this was measured locally before the merge, from console builds of both sides on one box. eagerGzipBytes is +195 B (+752 raw): i18n-locale-en +63 gz and src +153 gz, and every other chunk is raw-identical. That put 4929b50 at 3307.6 KB against the then-ceiling of 3307.0 KB, with base f3a0488 at 3307.4 KB. main now carries the rollback (3c888c6) and the 5,120 B allowance (1c51e97). The authoritative reading is this PR's Bundle Analysis run, and the report on the card quotes it.

Acceptance notes

  • Localization label. objectstack platform-objects translates the Setup nav label nav_settings_localization only for en, zh-CN, es-ES and ja-JP. A de, fr, pt, ko, ru or ar user therefore sees the English "Localization" in the Setup nav, while this notice names the translated word (Lokalisierung, Localisation, Localização, 현지화, Локализация, التوطين). This is an observation, not filed: no public door gives a wrong answer, and nobody has picked it up.
  • The widget takes className only. The dispatch's suggested props were { properties, className }, but the widget reads no prop, and the arm declares the bag empty.
  • Out of scope, as the card says: the cloud field (cloud#2676 step 2), the welcome-page node (step 4) and the creation half (objectui#11908).

Generated by Claude Code

claude added 5 commits October 8, 2026 10:14
… the seeded workspace timezone on the welcome page (objectui#11930)

The widget reads the additive `workspaceTimezoneSeed` from the org-scoped
entitlements summary through `useEnvironmentEntitlements` and renders one
muted line naming it, or nothing when the summary carries no seed.
Registered as `cloud:workspace-timezone-notice` with its
`@object-ui/types` arm, its `sideEffects` entries, a known-schema-types
row and one copy key in every locale pack.

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
…, its empty states, its arm and its known-type row (objectui#11930)

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
…er's not-a-container warning, as every family-D refusal does (objectui#11930)

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
…ned surfaces (objectui#11930)

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
…-notice

Brings in the eager-budget rollback (3c888c6), the 5,120-byte allowance
(1c51e97), objectui#11895, #11898, #11925, #6152 round 7, #11168,
#11389 and #11923. No conflict; zod-mirror-parity.test.ts auto-merged.

Claude-Session: https://claude.ai/code/session_01CGZy1BGCjdN5cXqL9cnvB8
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 1 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/11573-any-component-emit-headroom.md

  • names packages/types/src/__tests__/any-component-emit-headroom-11573.test.ts → packages/types/src/__tests__/any-component-emit-headroom-11573.test.ts — edited by this change

    packages/types/src/__tests__/any-component-emit-headroom-11573.test.ts reads the declaration's size with the compiler's own counter, fails when it crosses a tenth of the ceiling below it, and lists every member as named or inline.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 7241a81e0 (merge-base with origin/main): 26 file(s) changed outside .changeset/, read against 187 pending declaration(s) that publish a body (190 pending in total). · run

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 336 chunks) 3307.2 KB 3312.0 KB
Main entry chunk (gzip) 71.3 KB 350 KB
Entry file index-CbPiALiz.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 17.97KB 6.62KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.70KB 10.94KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 587.49KB 141.58KB
core (index.js) 10.00KB 3.96KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 240.39KB 67.09KB
fields (index.js) 266.92KB 67.47KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.50KB 11.82KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.86KB 5.00KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.52KB 2.26KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 53.39KB 15.52KB
plugin-charts (index.js) 84.71KB 23.25KB
plugin-chatbot (index.js) 199.63KB 47.46KB
plugin-dashboard (index.js) 144.20KB 38.95KB
plugin-designer (index.js) 231.46KB 48.87KB
plugin-detail (index.js) 248.57KB 65.47KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 176.62KB 45.75KB
plugin-gantt (index.js) 179.17KB 45.07KB
plugin-grid (index.js) 248.06KB 68.79KB
plugin-kanban (index.js) 52.17KB 16.37KB
plugin-list (index.js) 117.58KB 29.37KB
plugin-map (index.js) 27.24KB 9.03KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.10KB 11.81KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.07KB 22.93KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.81KB 3.58KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.25KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 113443d44aa0461c9fb14cc84746cca9b1c997b6
Local-runs: none

Inputs: card #11930 (body and all four comments: claim 6057491447, stop report 6058785780, amendment 6058827980, round-2 report 6059156555), PR #11960 (body, 27-file list, net diff against merge-base 70e3d772), and the 43 check-runs on the head (40 success, 3 skipped: dependabot, Test (coverage), Test (coverage shard); none failed, none in progress; the one legacy status, Vercel, is success). The head is a --no-ff merge of 4929b50d and main 70e3d772, as the round-2 report says. Judged against the card, the amended claim and the precedent 24d3e656 (objectui#10990). No build, test or gate was run here; the spelling of generics below is in words, because the body sanitizer eats angle-bracket fragments.

① Derived judgments

Every accept-set and public-surface change the diff implies, each judged:

  1. @object-ui/types/zod exports CloudWorkspaceTimezoneNoticeSchema (zod/cloud.zod.ts, re-exported from zod/index.zod.ts) — RIGHT. Its members are the widget's read points and no others: type is the literal; properties is z.strictObject({}).optional(), the spelling ElementDividerBlockSchema uses for a node with no prop (verified in public-blocks.zod.ts at the head); body and children are retirementTombstone members whose refusal text names the type and carries the parser-tier not-a-container clause. The widget reads className only, which BaseSchema already carries, so the empty bag is correct, and a zone key in the bag is rightly refused: the zone comes from the summary, never from the page.
  2. AnyComponentSchema gains one discriminated-union member, placed after CloudPlanStatusSchema — RIGHT and strictly additive. The ratchet test's pre-change reading was that this literal was refused at type (361 against the pin of 360 without the arm), so nothing that parsed before is refused now; safeValidateSchema and objectui validate widen by exactly this literal.
  3. StrictAnyComponentSchema follows with no edit — RIGHT. At the head it is a z.lazy over faceWalker(AnyComponentSchema) in strict-authoring-face.ts, a derivation, and the new arm pin exercises the strict face for the bare node, the empty bag, the in-page node and a flat undeclared key.
  4. @object-ui/types (root) exports the TS twin CloudWorkspaceTimezoneNoticeSchema (cloud.ts, via index.ts) and AnySchema gains the member — RIGHT. The twin matches the arm member for member (properties? typed Record of string to never; body? and children? typed never), it is registered as the parity pair cloud.zod.ts#CloudWorkspaceTimezoneNoticeSchema, and EXPECTED_MIRROR_PAIRS moves 194 to 195. The post-merge auto-merge of zod-mirror-parity.test.ts left both rows and the count intact in the net diff.
  5. @object-ui/cli: KNOWN_SCHEMA_TYPES gains exactly 'cloud:workspace-timezone-notice' — RIGHT. No bare workspace-timezone-notice row and no app-shell: twin, because the registration is { namespace: 'cloud', skipFallback: true, category: 'plugin', inputs: [] }, the same options CloudPlanStatus.tsx registers with (compared at the head). The list is generated; the dev's --check read OK on the head and CI Test is green, which carries the derivation test. The ratchet test gains one row and its pin stays 360 — RIGHT: the type registered WITH its arm.
  6. @object-ui/i18n: one key, cloudWorkspaceTimezoneNotice.seeded, in all ten packs — RIGHT. The locales directory at the head holds exactly ar de en es fr ja ko pt ru zh beside index, registry and rtl, and every one of the ten gains the key with the single zone placeholder; no other key moved. The ZH value is the card's suggested sentence plus a final full stop, disclosed in the body; the EN value is the one the widget test pins. check:i18n-designer-parity and check:i18n-drift are the dev's gates and CI Test is green.
  7. @object-ui/app-shell registers the widget through one side-effect import in src/index.ts beside CloudPlanStatus.js, and sideEffects gains the dist and src spellings of the new module — RIGHT; nothing else in package.json moved. The body's "exports has only ." is one subpath short — exports at the head is . and ./styles.css — but the conclusion stands: the stylesheet subpath exports no name, so no new name is importable. The widget's own .d.ts enters the declaration closure through the side-effect import, which is additive.
  8. EnvironmentEntitlementsSummary and EnvironmentEntitlementsState gain workspaceTimezoneSeed?: string (environment/entitlements.ts), and the hook maps data.workspaceTimezoneSeed verbatim — RIGHT, and package-internal as the body says: src/index.ts at the head exports nothing from ./environment/. The derived and unknown fallback states never carry the field, so a failed, rejected or un-enveloped summary degrades to the empty render. The widget's guard (typeof zone !== 'string' || zone === '' renders null) covers absent, empty, loading, failed, rejected and bare-body, which is the card's control case and its no-throw case; the test pins each of those and the seeded EN and ZH lines.
  9. Behaviour against the card: one p element, text only, no link, no dismissal state, the node's className and responsiveStyles scope class reach it — RIGHT, matching the cloud seat's Q2 answer the card quotes. Out of scope stayed out: the diff touches no cloud field, no welcome-page node and no ?timezone= creation path.
  10. The changeset body's observable-terms list restates items 1 to 9 and nothing the diff does not do — RIGHT.

File surface: all 27 files in the net diff are named by the claim 6057491447 or the amendment 6058827980; none is outside. The amendment's "precedent's own file set" is the precedent's set plus the TS-twin files (cloud.ts, index.ts) and the headroom test, which postdate 24d3e656 (objectui#11515, objectui#11573), and the hook's two files, which this widget's read of a new summary field needs; each is named explicitly.

② Semver level

.changeset/11930-workspace-timezone-notice.md declares minor on @object-ui/app-shell, @object-ui/types, @object-ui/i18n and @object-ui/cli, and nothing else — RIGHT, and it matches what the diff publishes: a new registration plus two sideEffects entries (app-shell), two new exported names and two union members (types), one new key in ten published packs (i18n), and a widened accept set of objectui check, with objectui validate widening through the types dependency (cli). Every widening is additive; nothing that parsed, rendered or resolved before changes, so no major is owed, and check-changeset-no-major read OK. The PR body's second line is Clause-②: yes, line-initial, as the claim requires, and the changeset body restates it with the four surfaces. Check-runs Changeset Declaration, Changeset Bump Policy, Changeset Fixed Group Check, Changeset Overwrite Report and Changeset Claim Re-read are all success on the head.

One divergence from the precedent, judged in this PR's favour: 24d3e656's changeset declared patch on @object-ui/i18n and @object-ui/cli, while this PR declares minor on both. The amended claim's own rule is at least minor on each package whose published surface widens, and both of these surfaces widen (published locale keys; a widened accept set), so minor is the right level and the precedent's patch was the looser call.

③ Boundary flags

  • Round-1 open question (6058785780: eleven files outside the claim, options A, B, C) — answered by the seat in 6058827980 with A, before the PR opened. Judged right: the ratchet header forbids raising NAMESPACED_REFUSED_AT_TYPE, so the arm must land with the registration, as 24d3e656 did; option B only reorders the same two halves and C is not viable. The amended surface covers every file in the diff, and the amendment records the @object-ui/types widening under Clause-②, so the review covers all four packages.
  • Narrowed app-shell suite (27 of 1166 files locally, declared) — answered by the head's check-runs: Test (shard 1/8) to Test (shard 8/8), Test, Test (dist pins), Type Check, Lint, Build & E2E and Build Docs are all success.
  • Props shape (className only, against the dispatch's suggested { properties, className }) — right: the widget reads no prop, the arm declares the bag empty, and the renderer's extra props are ignored by the component.
  • PM hypothesis 1 (hook maps field by field; entitlements.d.ts not reachable from the built entry) — confirmed from src/index.ts at the head, which exports nothing from ./environment/.
  • PM hypothesis 2 (no app-shell: twin; namespace comes from the register option) — confirmed from the registration options and the registry pins in the widget test and the ratchet row.
  • Copy — matches the card's suggested ZH sentence (plus the full stop) and names the Setup nav entry nav_settings_localization as "Settings → Localization".
  • First-load bytes — the claim conditioned landing on Bundle Analysis being green on the merge ref: check-run 113291882681 is success, and the budget bot (6059133011) reads the eager closure at 3307.2 KB against the 3312.0 KB budget, PASS. The widget's own delta is +195 B gzipped, measured by the dev.
  • Round-2 deviations (merge commit amended locally before its single push; two wrong-cwd gate runs discarded; a round-2 report posted) — no concern: the head's parents are 4929b50d and 70e3d772, there was no force-push, and the counted gate runs are the worktree-root re-runs. Round 2 lists no open questions.
  • Out-of-scope finding, both rounds (objectstack platform-objects translates the Setup nav label nav_settings_localization only for en, zh-CN, es-ES and ja-JP, so de, fr, pt, ko, ru and ar users see English "Localization" in the nav while this notice names the translated word) — not a defect of this PR and not blocking: the card's acceptance languages, EN and ZH, both have a translated nav label, and the gap lives outside this repo's surface. Escalated to the seat as a candidate carrier on objectstack, with the dev's dedupe words ("Localization nav label untranslated, setup nav translations de fr"); filing is the seat's call.
  • Concurrency named in the amendment (release PR objectui#11600 touches .changeset/; draft objectui#11069 touches another row of the ratchet test) — ordinary; whoever lands second merges main.
  • The PR is still a draft; marking it ready is the seat's act, not this record's.

Implemented-by: claude/issue-11930-workspace-timezone-notice
Reviewed-by: session_01CGZy1BGCjdN5cXqL9cnvB8

VERDICT: PASS


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 8, 2026 12:24
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 8, 2026 12:24
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 45d5853 Oct 8, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-11930-workspace-timezone-notice branch October 8, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants