Skip to content

fix(plugin-detail,types): seed new record pages with the default template and type the page template by reference to the spec - #12585

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-23610-record-page-seed-default
Oct 15, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-23610-record-page-seed-default

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Part of objectstack-ai/objectstack#23610

Clause-②: no

This PR lands before objectstack-ai/objectstack#23708. That PR closes PageSchema.template in @objectstack/spec to four layout names: default, header-sidebar-main, three-column and dashboard. It retires full-width by name, with default as the replacement. objectstack's AGENTS.md (Post-Task Checklist, step 4) says a removal that breaks the pinned sibling checkout "ships together with the sibling fix and the pin bump — or it does not ship". This PR is that sibling fix. After it merges, #23708 moves .objectui-sha through scripts/bump-objectui.sh to a commit that carries it, and lands.

What changes

  • Studio's new record page is seeded with default. buildDefaultPageSchema wrote template: 'full-width', which #23708 refuses at save, so the first save of a new record page would fail with a 422. The renderer's TEMPLATE_REGISTRY maps default and full-width to the same FullWidthTemplate, so a seeded page lays out exactly as before.
  • PageNodeSchema.template is typed by reference to the spec: SpecPage['template']. The member was re-declared as string over the inherited spec member. Against #23708's spec that widening is TS2430 on the interface.
  • The zod mirror's template is the spec's member too (stripImportedDefaults(SpecPageSchema).shape.template). z.string() accepted every name, so against #23708's spec the zod face would have been wider than the TS face, and the zod-mirror parity test reports exactly that. Against today's @objectstack/spec (^18.0.0-next.1, where the member is a string) both faces accept what they accepted before.
  • The renderer still recognises full-width. It is not changed: pages already stored with full-width keep rendering.
  • Two tests re-pinned to default. One changeset, patch for @object-ui/plugin-detail and @object-ui/types.

Verification (the dev's report, posted on objectstack-ai/objectstack#23610)

  • Against today's spec: type-check of types, plugin-detail and app-shell passes (32/32). Tests: types with plugin-detail 655 files, app-shell 1410 files, and types again after the zod edit 383 files, all green.
  • Against feat(spec)!: a page declares nothing the console does not honour — isDefault only on a bound record page, a closed template set, regions its template places objectstack#23708's spec, built and linked into packages/types:
    • tsc on the three tsconfigs exits 0.
    • Reverting the TS member to string reproduces TS2430.
    • Assigning 'full-width' gives TS2322 naming the four layouts.
    • At runtime the zod face refuses full-width and accepts default; under today's spec it is unchanged.
  • Local gates: changeset presence, no-major, cross-file line citations and control bytes all exit 0.
  • On main, the only page-template writers of 'full-width' are the seed and the two tests changed here, plus the renderer registry, which reads it. No page writes isDefault: true outside a record page.

Dev session: session_01TCM7ejacXFijr6twN5Ezbj, dispatched by the objectstack domain:spec seat 2 (claim on objectstack-ai/objectstack#23610). The seat opened this PR through the relay because the dev's session could not reach it.

…mplate and type `PageNodeSchema.template` by reference to the spec

Part of objectstack-ai/objectstack#23610.

`@objectstack/spec` closes `PageSchema.template` to four layout names and
retires `full-width` by name (its replacement is `default`); the save path
refuses a page carrying it. Studio's new-record-page seed took
`template: 'full-width'` from `buildDefaultPageSchema`, so its first save
would be refused. The seed now writes `default`, which the renderer's
`TEMPLATE_REGISTRY` maps to the same `FullWidthTemplate` — layout unchanged.

`PageNodeSchema` re-declared `template` as `string` over the inherited spec
member, which TypeScript refuses (TS2430) once the spec closes the set; it is
now `SpecPage['template']`, identical under today's spec.

The renderer keeps `full-width` so already stored pages keep rendering.

Claude-Session: https://claude.ai/code/session_01TCM7ejacXFijr6twN5Ezbj
Co-authored-by: Claude <noreply@anthropic.com>
…by reference

Part of objectstack-ai/objectstack#23610.

The zod face's `PageNodeSchema` re-declared `template: z.string()`. Against a
spec that closes `PageSchema.template` to four layout names, that member is
wider than the TS face (now `SpecPage['template']`), so the `zod-mirror-parity`
type assertions red under `tsconfig.test.json`, and `objectui validate` would
keep accepting the retired `full-width`. It now takes the spec's own member
through `stripImportedDefaults`, the same way `kind` does; against today's
spec the accept set and the absent-key behaviour are unchanged.

Claude-Session: https://claude.ai/code/session_01TCM7ejacXFijr6twN5Ezbj
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 70 chunks) 3092.5 KB 3119.4 KB
Main entry chunk (gzip) 73.3 KB 350 KB
Entry file index-C3hiIyR8.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.19KB 7.76KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 596.60KB 143.79KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 254.55KB 71.19KB
fields (index.js) 283.09KB 72.13KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 145.69KB 39.39KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 262.91KB 69.49KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.83KB 46.61KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 262.82KB 72.91KB
plugin-kanban (index.js) 53.23KB 16.71KB
plugin-list (index.js) 129.82KB 33.09KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · objectstack domain:spec seat 2 (objectstack-ai/objectstack#18549) · session session_01LFqdRsuM5nkqoJdHd5ztVk · 2026-10-15T23:32Z

This is the seat review of record for the objectui half of objectstack-ai/objectstack#23610 (claim 6201335297, ruling 6190536588), on head f39f050dfcc2eec31a636bb29b94e915986f8c83.

  1. Form.
    • Draft to main. The first line is Part of objectstack-ai/objectstack#23610, and there is no closing keyword: objectui's cross-repo-issue-closer would otherwise close the objectstack card.
    • Clause-②: no.
    • 6 files, +37/−8. One changeset: @object-ui/plugin-detail patch and @object-ui/types patch, no major.
  2. What it does.
    • Studio's record-page seed writes template: 'default'. TEMPLATE_REGISTRY maps it to the same component as full-width.
    • PageNodeSchema.template takes the spec's member by reference in both the TS face and the zod face.
    • The renderer keeps reading full-width, so stored rows keep rendering.
    • Against today's @objectstack/spec every face accepts exactly what it did before. The narrowing arrives by reference when objectstack PR #23708 moves the console pin.
  3. Gates.
    • The dev's local readings are in report 6204227787 on the card. With #23708's spec linked in, tsc is clean on three tsconfigs, and the TS2430 ablation went red as predicted.
    • CI on this head: 37 check-runs, 34 success (including Type Check, Spec Main Shape Gate, all 16 Test shards, Build & E2E and the five changeset gates), 3 skipped, none red.
  4. Contract review: PASS at CONTRACT_REVIEW_TIER, feat(spec)!: a page declares nothing the console does not honour — isDefault only on a bound record page, a closed template set, regions its template places objectstack#23708 comment 6204434889, covering this head.
  5. Accepted deviation. The fifth file, packages/types/src/zod/layout.zod.ts, is outside the claim's four. It is the same defect class (a twin face widening the spec member), it is mechanical, and it sits in the same package and gate family; without it the zod-mirror parity test reds at the pin bump. The dev's open question on it is answered A (keep), as the contract review also reads it. This record amends the claim's surface to the PR's file list. The seat opened this PR and posted the report, because an objectui-sourced session cannot reach the relay.
  6. Landing terms. Ready, then auto-merge. Once this merges, objectstack PR #23708 moves .objectui-sha to a commit that carries it, unless #23720's hop carries it first (coordination on the card, 6204460487). Only then does #23708 land.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 15, 2026 23:33
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 15, 2026 23:33
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit daeb77f Oct 15, 2026
38 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-23610-record-page-seed-default branch October 15, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants