Repository navigation
Conversation
…erver Add a service-chain E2E that runs `bub run` from the Bub 0.6.1 harness environment against an in-process Server and deterministic model fixtures. It covers cross-session recall, capture redaction of known credential values, workspace binding across a resumed session, the capture setting, and the PowerContext tools. A new bub suite and bub-host job run it in CI and refuse to skip without the Bub environment.
Fengzdadi
requested review from
AlexStocks,
PsiACE and
yihong0618
as code owners
November 14, 2026 07:27
AlexStocks
approved these changes
Nov 15, 2026
hidb4ai
approved these changes
Nov 15, 2026
hidb4ai
left a comment
Contributor
There was a problem hiding this comment.
No blocking findings at 8444d21. The real Bub service-chain coverage addresses the integration regression gap without adding runtime database tables or public interfaces. Independently exercised pinned Bub 0.6.1 against the real SQLite Server with controlled model endpoints, checked CI selection and result gates, and confirmed that restoring the framed recall query makes the new recall case fail as intended.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
No tracking issue. Bub had no real-host service chain; this PR adds one. Its recall case guards the fix for #2487 (#2488).
Rationale for this change
The Bub plugin tests in
e2e/bub/tests/call the hooks with hand-builtbub.hooks.interceptionobjects. Theharness-validationjob type-checks and unit-tests the replay harness but never starts a Bub turn, and the Harbor replay uses real models outside CI. Nothing ran Bub's own framework against a Server. As a result, #2487 (Bub's channel frame in the recall query) only surfaced through manual runs.What changes are included in this PR?
tests/e2e/test_bub_service_chain.pyruns the realbub runCLI with the plugin discovered through itsbubentry point.e2e/bub/.venv, whichmake harness-syncbuilds. Each case gets an isolatedHOME/BUB_HOME.HostModelFixtureserves both Bub's model and the Server's generation model.powercontext[client]. The split also mirrors a deployment, with the host process on one side and the Server on the other..env. Bub loads the nearest.envfrom its working directory upward. Without the empty file, a run under a checkout would pick up that checkout'sPOWERCONTEXT_BUB_*values.integrations/bub/README.mdand the evaluation integration docs:PowerContext host-supplied contextlabel.POWERCONTEXT_BUB_SCOPE_IDtakes precedence, and no workspace path reaches the Server.capture_eventsoff stops capture and flush only. Recall keeps running.powercontext.remember,powercontext.search, andpowercontext.contextreach the bound Scope, not the default.bubsuite andbub-hostjob inmaster.ymlrunmake harness-sync, then run the cases withPOWERCONTEXT_TEST_BUB_HOST=1.bub.logon failure..github/ci-paths.tomlselects the suite for changes to the Bub plugin, the harness lock, the test, the shared wire fixtures, and the shared runtime.tests/test_ci_changes.pycovers the new selection rows.integrations/capabilities.tomllists the new test as Bub evidence. The only test listed before, the workload catalog, runs none of Bub's declared capabilities, and this test runs all of them. Editingmaster.ymlalready selects full CI, so the manifest edit adds no CI cost.Are there any user-facing changes?
No. This PR changes tests and CI only.
How was this change tested?
uv run pytest tests/e2e/test_bub_service_chain.pyagainst real Bub 0.6.1 on macOS: all 5 cases pass.Each mutation below was applied to the plugin, the cases were run, and the mutation was reverted:
render_capture_eventredactioncapture_eventscapture_eventsWith
POWERCONTEXT_TEST_BUB_HOST=1and no Bub environment, all 5 cases error. Without the variable, they skip.A parent
.envthat sets a bogusPOWERCONTEXT_BUB_SCOPE_IDand turns capture on leaves all 5 cases passing. Without the workspaces' empty.env, the settings case fails.The workspace-path assertion searches decoded request strings, so JSON escaping cannot hide a Windows path.
make check,make harness-check, anduv run pytest tests/test_ci_changes.py tests/test_ci_pipeline.py tests/test_integration_manifest.pyall pass.The diff was reviewed twice before submission:
.envcould reach Bub, and a comment described the frame bug.bub runtimes out, the path check also covers resolved paths, the settings case no longer pins the exact capture event sequence, Bub no longer inherits proxy variables, and the log upload skips pytest's*currentlinks.POWERCONTEXT_SERVER_*variables from the runner's environment. CI sets none of them.AI usage statement
Claude Code (Claude Opus 5.5) wrote the test, the CI wiring, and this description, and ran the local verification.