chore(scripts): remove the broken installer - #398
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
scripts/install.shrather than repairing it — a repaired script would still have nothing to install. The replacement, written against published and pinned artefacts, is #397 (target: before 1.0).Why not repair it
Every source it installs from is unpublished, checked today:
curl -sSL https://odal-node.io/install.sh404— the facade does not serve ithttps://odal-node.io/docker-compose.yml404, and with no--failit saves the 404 page asdocker-compose.ymlghcr.io/odal-node/*:latestcargo install odal-cliwhencargoexistsodal-cliis not on crates.io — whoever registers the name runs code on every machine following the installerreleases/download/latest/odal-<os>-<arch>404— no GitHub Release exists, andreleases/download/latest/is not a valid URL shapeAnd what it would have run, had the fetches worked:
.envlacksDATABASE_APP_PASS,DATABASE_POSTGRES_PASSand the admin credentials, which compose requires via${…:?}—docker compose upfails at interpolation. It writesPORTwhere compose mapsNODE_PORT, so--portbreaks the health poll, and it still writes the deadJWKS_URL/JWT_*variables.env_file: ../.envand bind-mounts../ops/bootstrap/*— so from~/.odal/it reads~/.env, and Docker creates empty directories for the missing mounts, so Postgres role provisioning silently never runs.odal_sk_…as "API Key". The node never issued it; it authenticates nothing.What changes
scripts/install.sh— deleted.scripts/README.md— was entirely about the installer (and described ascripts/docker-compose.ymland aninstaller/directory that do not exist); now says whatscripts/holds and points installers atOPERATOR-SETUP.mdand Rebuild the one-click installer once the images and CLI are public (pre-beta) #397.justfile— the comment claiming "the installer path was never affected" was false (see above); it now namesodal up, which does pass--env-fileitself..gitattributes,CONTRIBUTING.md— stop naming the script.OPERATOR-SETUP.md— "or download a release" removed; there is none.CHANGELOG.md—### Removedunder[0.14.0], since this lands before the tag.No behaviour change: nothing in the workspace, CI or the images referenced the script.
Merge order
After #394. That PR adds one line to
install.sh; this deletes the file, so rebasing ontomainafter it merges is a modify/delete conflict resolved by keeping the deletion.Verified
just checkgreen on this branch. Noinstall.shreference remains outside the changelog entry.