Repository navigation
Conversation
Benchmark report
|
1 similar comment
Benchmark report
|
kubaplas
force-pushed
the
feature/addressable-entity
branch
from
August 10, 2026 12:23
85994d1 to
4fc5202
Compare
Benchmark report
|
Benchmark report
|
Benchmark report
|
casper-client: published 5.0.1 (2026-03-16) requires casper-types ^7.0.0, so the update-casper-types-to-7 branch is no longer needed. The API it was pinned for is present in the release - the workspace compiles and the full test suite passes against it. casper-contract-schema: published as 0.7.0, so its [patch] line is removed and it resolves from crates.io. The workspace requirement moves 0.6.0 -> 0.7.0 in step; without that the patch would have silently dropped out of the graph. The remaining five casper-node crates stay patched. Re-checked against crates.io on 2026-09-14: casper-engine-test-support is still 8.1.1 and casper-contract still 5.1.1 (both requiring casper-types ^6), unchanged for 14 months. casper-event-standard stays patched too - it needs casper-contract on wasm32, so publishing it against casper-types 7 would give consumers two incompatible casper-types at once. Also records the failure mode found while doing this: when a patched crate's version stops satisfying the requirement, cargo only warns and silently uses the crates.io copy instead, pulling in a duplicate casper-types. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`upgrade_contract` forced the lazy package migration and only then looked up the version to disable. The legacy package record is readable right up until the migration converts it, and no wasm API can read a migrated package, so that ordering threw away the one moment the authoritative value is available and left the account named key as the only source. Reading first prefers the package record itself and falls back to the named key for packages already migrated or installed in addressable-entity mode. This does NOT by itself let a contract installed before Odra 3.0.0 be upgraded after the switch. Such a package has no `odra_noop` entry point, so the forced migration reverts; migrating it out-of-band first avoids that, but then the legacy record is already gone and there is no named key to fall back to. A fix needs a way to migrate without `odra_noop` - e.g. an optional upgrade argument naming a safe entry point to call instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Benchmark report
|
Merged
Contributor
Author
|
Follow-ups for this PR, collected from a review of the branch (state as of 2026-10-13): Base
Dependencies
Upgrades across the AE switch
Tests
API
Docs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus migration tooling and tests.