Repository navigation
Covers: draw them wide (16:9) for the full-width band - #25
Merged
Merged
Conversation
The meeting page shows its cover as a full-width band, and a square cover showed only its middle third there (the user, on a real meeting). Every new cover.jpg is now the largest centred 16:9 crop of what the engine answered, at most 1536 px wide, never upscaled; a dropped-in cover.png still bypasses normalize. Older square covers still show; New Cover redraws one wide. - CoverImageFile: integer 16:9 crop (a wider source loses columns, a taller one rows), aspectWidth/aspectHeight/aspect public, read-back checks the exact target size. - Engines: OpenRouter aspect_ratio 16:9; the OpenAI-compatible body asks 1536x1024 (the one landscape size OpenAI's own image models take, any multiple of 16 for Flux); Codex is asked for "1536x1024, landscape". - Prompt: "A wide 16:9 cover illustration", the characters close together in the centre with open background to both edges, so the picture reads as a banner and as a square thumbnail cut from its centre. Scene prompt revision 5 reshapes only the first paragraph. - MeetingCoverTile asks the thumbnail cache for size x 2 x aspect px on the long side, so the 56 pt centre square keeps 2x pixels. CoverHeroGeometry is unchanged: a 1,400 pt pane shows the middle 51 % of the cover's height. - Paid look test (two rounds, OpenRouter + Codex) recorded in the design §10 landscape addendum; CHANGELOG and CLAUDE.md updated.
…that stops swift test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cover.jpgis now the largest centred 16:9 crop of the engine's answer, at most 1536 px wide, never upscaled. Older square covers still show; New Cover redraws one wide.aspect_ratio: 16:9, the OpenAI-compatible body1536x1024, Codex "1536x1024, landscape".MeetingCoverTilesizes its thumbnail by the short side, so the centre square keeps 2× pixels.docs/plans/2026-09-24-meeting-illustrations.md§10 landscape addendum, with the two-round paid look test.Test plan
swift buildandswift build --package-path appin the branch worktreeswift teston CI (this Mac has Xcode 27 with Command Line Tools 26.6, so the Testing macro and framework disagree and the tests cannot compile locally;mainfails the same way)