Repository navigation
Re-baseline the particle_render_10k budget to the CI reference toolchain (2.0 → 3.0 ms) - #86
Merged
Merged
Conversation
… reference toolchain (2.0 -> 3.0 ms)
…windows + ci:macos labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Every merge to master since M2-PART-02 (PR #83) has failed the merge-lane CI
Linux x64 (clang++)job on theparticle_renderbudget gate (ParticleRenderBudget.TenThousandParticles) — and the unfilteredlaige-render_testsentry that contains the same suite.The gate platform is the CI reference lane (Clang 18.1.3, CMake Debug, ubuntu-24.04 shared runner), where the 10k-particle declare pass measures 1.91–2.68 ms mean (worst backend), consistently above the 2.0 ms bar:
bdb323b)2f2c5a9)4f81866)This is a calibration gap, not an engine regression: the 2.0 ms bar was set from local-machine runs (1.07798 ms canonical g++ 16.2.1 -O0, 1.18578 ms local Clang 23.1.1 -O0) and never verified with margin on the CI reference toolchain (runner Clang 18.1.3, not local 23.1.1, on a shared runner) — the exact lesson the M2-ISO-02 rebaseline recorded. The
declareParticlespath is unchanged since M2-PART-02, and theLinux x64 (g++)lane passed the same gated workload on the same commit.The revision (methodology §5, the M2-ISO-02 rebaseline precedent)
budgets.json:particle_render_10ktarget 2.0 → 3.0 (44% above the latest recorded reference-lane value 2.07786, 12.0% above the worst observed reference-lane mean 2.67853);measured1.07798 → 2.07786 (latest recorded CI reference value, worse backend, run 37850579155).docs/benchmarks/baselines/m2-particle-render-budget-rebaseline.md(the eleventh baseline; supersedesm2-particle-render.mdas the latest recorded value) + baselines index entry.docs/api/particle_render.mdBudget bullet,src/laige-render/README.md, roadmap change log.depth_sort_10kprecedent). No engine code, workload, or test change — budget + docs only (methodology §1: no regression occurred; this is a gate-margin calibration on the reference toolchain).Verification
ctest -R particle_renderPASS onbuild,build-clang,build-release,build-shared;ctest -R budget_harnessPASS (17-entry pin + well-formedness of the updatedbudgets.json).Linux x64 (clang++)job (the PR lane runs Windows/macOS only — M0-CI-01); expected to PASS: the new 3.0 ms bar covers every observed reference-lane mean with ≥ 12% margin.