Repository navigation
Fix the linux-asan CI lane: the font entry missed the detect_leaks=0 list - #89
Merged
Merged
Conversation
…list The font entry's 'Font*' filter also matches the FontSdf* suites added by M2-TEXT-03, so it now runs the FontSdfSmoke offscreen GL smoke. It was not on the LAIGE_ASAN block's detect_leaks=0 list, so it inherited the job-level ASAN_OPTIONS with detect_leaks=1 and LeakSanitizer aborted it on the process-lifetime EGL display vendor state (2026-10-11 CI run 38097683448: 464 bytes in 7 allocations, every stack through createHeadless/submit). Add font to the block (the replacement environment already carries LAIGE_TEST_FONT_PATH), give the entry the same 120s timeout as the same-shaped text_items/font_sdf entries, and update the two stale comments. In-run ASan/UBSan error detection stays fully active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The$(font) ctest entry uses $ (--gtest_filter=Font*) (M2-TEXT-01). The $(FontSdf*) suites added by M2-TEXT-03 match that wildcard, so the entry now also runs $ (FontSdfSmoke) — the offscreen GL smoke that creates a headless EGL context.
The entry was not on the$(LAIGE_ASAN) block's $ (detect_leaks=0) list, so it inherited the job-level $(ASAN_OPTIONS) with $ (detect_leaks=1) and LeakSanitizer aborted it on the process-lifetime EGL display vendor state at process exit. The 2026-10-11 merge run (38097683448) shows exactly this: 464 bytes in 7 allocations, every stack allocated through $(createHeadless) (eglInitialize) or the smoke's $ (submit) draw.
Every other entry whose suites can create that context (gl_context, render_thread, sprite_draw, render_counters, text_items, font_sdf, and the unfiltered laige-render_tests entry) was already on the list, which is why they passed in the same run.
Changes (tests/laige-render/CMakeLists.txt only)
In-run ASan/UBSan error detection stays fully active — only the at-exit vendor-state leak check is disabled for this entry, exactly like the other render entries.
Verification