Repository navigation
Move >30 s CI suites to label-gated jobs (ci:slow:*) - #97
Merged
Merged
Conversation
Measured on the latest master run 38312355303 (2026-10-12): every ctest entry that exceeded 30 s in a lane moved out of the main job into a dedicated job of its own (one job per suite per lane), gated by a repo label in the PR lane (ci:slow:sim, ci:slow:render, ci:slow:particle, ci:slow:zero-alloc, ci:slow:ecs-stress, ci:slow:bench-50k) and by a workflow_dispatch checkbox in the merge lane. The main jobs' ctest excludes the moved entries (-E) and the slow jobs select theirs (-R), so every entry runs exactly once per gated run and never ungated. Slow set: laige-sim_tests + laige-render_tests (gcc/clang/asan/tsan), particle_render (gcc/clang/tsan; 28.84 s on asan stays in the main asan job), zero_alloc + ecs_stress (asan/tsan; under 30 s on gcc/clang), laige_bench_render_50k_fpx16/_fp32 (gcc/clang). No entry exceeds 30 s on windows/macOS (worst: laige-sim_tests 27.11 s on macos-intel), so those jobs keep the full suite unchanged. Timeouts: the main Linux jobs revert to 10 min (the gcc/clang 45-min and tsan 30-min caps existed only for the moved suites); the slow suite jobs carry 20 min, the bench jobs 30 min. Milestone gate: a milestone-gate PR MUST carry ALL six ci:slow:* labels so every slow job runs and passes before merge (AGENTS.md section 5, new 'Slow CI suites and the milestone gate' subsection; the labels were created via the GitHub API). The PRD section 14 Perf row and the roadmap change log were updated in this change. No engine code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Measured on the latest master run 38312355303 (2026-10-12, all 11 jobs green), every ctest entry that exceeded 30 s in a lane has been moved out of the main job into a dedicated job of its own (one job per suite per lane). The new jobs run only when gated:
The main jobs' ctest excludes the moved entries (-E) and the slow jobs select theirs (-R): every entry runs exactly once per gated run, never twice, never ungated.
Per-lane evidence (run 38312355303, seconds):
No entry exceeds 30 s on windows/macOS (worst: laige-sim_tests 27.11 s on macos-intel), so those jobs keep the full suite and are unchanged.
Timeouts: the main Linux jobs revert to 10 min (the gcc/clang 45-min and tsan 30-min caps existed only for the moved suites); the slow suite jobs carry 20 min, the bench jobs 30 min.
Milestone gate (AGENTS.md §5, new subsection): a milestone-gate PR MUST carry ALL six ci:slow:* labels so every slow job runs and passes before merge; after the gate merges, a workflow_dispatch on master with all six checkboxes re-runs the slow matrix. Note: a label added after a run is created never re-triggers the run, so the labels must be on the PR before the run starts.
Docs updated in the same change: AGENTS.md §5, PRD §14 Perf row, roadmap change log. No engine code change — only the two workflows and the three docs.
CI validation (GitHub runs a PR's workflow from the merge commit, i.e. the PR's changes applied on base, so this PR's own runs validate the new PR-lane workflow):