Repository navigation
refactor(kommand)!: halve the command executor API with context parameters - #20
Merged
Merged
Conversation
…ameter Replace the KommandExecutorContext wrapper with a top-level context(CommandContext) Argument.invoke(), and collapse the paired (sender) / (sender, ctx) executor overloads into one. BREAKING CHANGE: KommandExecutorContext is removed. Import net.bladehunt.kotstom.command.invoke to call arguments, and use the (sender) executor lambdas. Kommand.defaultExecutorAsync no longer takes an (unused) scope parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every command executor builder came in two overloads,
(sender)and(sender, ctx), and argument access required wrapping theCommandContextin aKommandExecutorContextvalue class just to putArgument<T>.invoke()in scope. Kotlin 2.4 stabilized context parameters, which are built for exactly this.Now
CommandContextis passed as a context parameter, andarg()is a top-levelcontext(CommandContext)function. Executor DSL usage looks the same:syntax(value) { sender -> sender.sendMessage(value()) }Twelve executor functions are now six, and the wrapper class is gone.
Breaking changes
KommandExecutorContextis removed. To call arguments, importnet.bladehunt.kotstom.command.invoke.(sender, ctx)executor overloads are removed.Kommand.defaultExecutorAsyncloses itsscope: CoroutineScopeparameter. It was ignored before, andcontext: CoroutineContext = MinestomDispatcheris what actually applied.Testing
compileTestKotlinand:example:compileKotlinpass.KommandTestpasses (3/3).