Repository navigation
fix(extension): stop shipping Point helpers Minestom already provides - #21
Merged
Merged
Conversation
Point now defines asVec() and asPos() itself, so the KotStom extensions were unreachable. Vec.roundToBlock() used the BlockVec(Point) constructor, which Minestom marks for removal; it now delegates to asBlockVec() and is deprecated in favor of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minestom's
Pointnow hasasVec(),asPos()andasBlockVec()as members. Kotlin always picks a member over an extension, so KotStom'sPoint.asVec()andPoint.asPos()could never be called, and everypoint.asVec()was already running Minestom's version. Separately,Vec.roundToBlock()used theBlockVec(Point)constructor, which Minestom marks@Deprecated(forRemoval = true), so it would stop compiling when Minestom removes it.Point.asVec()andPoint.asPos(). Behavior doesn't change: Minestom's members return the same values, and also skip the copy when the point is already aVecorPos.Vec.roundToBlock()now callsasBlockVec(), and is deprecated withReplaceWith("asBlockVec()")so users get a one-click migration.Pos.roundToBlock()stays as is, since it keeps yaw and pitch.Testing
compileKotlin,compileTestKotlinand:example:compileKotlinpass, and the threePointExtcompiler warnings are gone.