Repository navigation
feat(coroutines): add SchedulerDispatcher for any Minestom scheduler - #28
Merged
Merged
Conversation
…ny Minestom scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MinestomDispatcherintoabstract class SchedulerDispatcher, which runs coroutines and counts tick-based delays on anyScheduler.MinestomDispatcheris now the instance forSchedulerManagerand still looks the manager up lazily, so it's safe to reference beforeMinecraftServer.init().Scheduler.asCoroutineDispatcher()andSchedulable.asCoroutineDispatcher()(entities, players, instances).withContextbetween them doesn't add a tick.Lifecycle-bound scopes (
player.launch {}etc.) are intentionally out of scope; see the design review on the dead-owner/lifecycle problems.Note:
SchedulerextendsExecutor, so this shadows kotlinx'sExecutor.asCoroutineDispatcher()forScheduler-typed receivers. That's intended: ours counts delays in ticks.Verification
MinestomDispatcherTest: 5/5 pass. The new test checks that a custom scheduler's delay only advances when that scheduler ticks, and covers dispatcher equality.