Repository navigation
refactor: consolidate the DAO oracle harness (#380 part 4) - #393
Merged
Merged
Conversation
Replace the copy-pasted per-suite scripts with one shared harness in oracle/windows-dao: dao.py (runner, VM transport, spec expansion, reports), Common.ps1, Native.ps1 (JSON operations), Observe.ps1 (complete readback), structure.py (raw decoder), keys.py, compare.py, generate.py and one spec per suite in suites/. Storage lifecycles keep a small module on the same runner; the twelve byte-model suites live in registry/ on structure.py and dao.py. Archive-only suites are retired to tag oracle-archive-2026-09.
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oracle/windows-daointo one runner (dao.py) that dispatches to typedregistry/(byte-model, driven bycrates/jet3/examples/*_candidate.rs) andsuites/(spec +module) suites, replacing the former per-suite script collection.oracle/windows-dao/scripts/down to the protocol-inventory tools (build_v1_2_inventory.py,protocol_validation.py,validate_protocol_v1_2.py); deletesacquisition/,dev-tools/,scripts/dao-check.py,scripts/windows-dao-ps.py, and all superseded per-suite tests, keeping onlytests/test_harness.pyandtests/test_protocol_validation.py.Common.ps1Cell-Valuenow uses a unary comma for binary/long_binary (DAO previously raised error 3421 from unrolledbyte[]), andNative.ps1New-Indexnow defaultskindto ordinary.oracle/windows-dao/README.mdwith a current suite table and an archive table (EXP-0241–0298, the retired 0299–0311 per-suite scripts, and the registry transport) pointing at tagoracle-archive-2026-09(9638d38) where every old path still exists.docs/LOCAL_WINDOWS_VM.md,TOOLING.md,justfile(windows-dev-ps→dao *args), andsupport-matrix.jsonevidence paths for the new layout.Final replay (EXP-0312)
Ran on revision
da77f4cc4d4ded702c936e07006563ad2685f04fagainst x86 DAO 3.6 (dao360.dll03.60.9765.0, SHA-2564cc28a5be8dc7425a4c4c1ef275ca392f18be35d70232e777dce6d9f3b4d79ac), Windows NT 10.0.20348, en-US/ANSI 1252. All 19 suites, run dirs undershared/checks/20260924-oracle-harness/final-2/{a,b,c}(private, not committed).c21×2 recorded failure), 26 accepted, 4 refused, 6 rust-only editsprepare:ValueError: Compact candidate continuation placement— same as main (Rust example output changed after EXP-0247)generate:Catalog(Page(Read(LimitExceeded { kind: TotalReadBytes, requested: ByteCount(536870927), maximum: ByteCount(536870912) })))— same as mainBoth pre-existing failures are unrelated to this consolidation and remain open.
text-propertiesrecords one intentional behavior change since EXP-0300: Nordic-collation cases x03/x04 were Rust-refusal controls there, but Rust has accepted Nordic text-property edits since EXP-0310, so they're now paired DAO edits with structure comparison skipped.Main advanced during this replay (#389 parser layout → #390/#391 write-internals and creation-API refactors → #392 test-only changes). This branch was rebased onto each in turn; none touch
oracle/.scripts/golden-check.sh 430a6cbon the rebased tree reports 1,923 files, 1,923 identical, 0 differ, confirming #390/#391 are behavior-preserving, so the replay above (run atda77f4c, before the rebases) was not repeated. Seedocs/PROVENANCE.mdEXP-0312 for the full record.Retired suites
Everything in the README archive table rows 0241–0298 is retired, including
row_overflow_lifecycle,fixed_text_index_lifecycleandempty_value_lifecycle(rows 0262–0267), which had Rust examples but no kept runner. Their original scripts and results remain at tagoracle-archive-2026-09.Line counts
oracle/windows-daoplus the two rootscripts/files: 30,525 → 11,942 linesoracle/+scripts/(excluding the untouchedprotocol/v1_2/and.gitignore): 183 → 67Test plan
just ready(fmt, clippy, tests, docs, source size, support matrix, Python checks) passesscripts/golden-check.sh 430a6cbconfirms behavior-preservation across the rebases onto refactor: consolidate parser write internals (#380 part 3a) #390/refactor: simplify the creation API and parser errors (#380 part 3b) #391🤖 Generated with Claude Code