Skip to content

refactor: consolidate the DAO oracle harness (#380 part 4) - #393

Merged
oglassdev merged 3 commits into
mainfrom
cleanup/oracle-harness
Sep 24, 2026
Merged

oglassdev merged 3 commits into
mainfrom
cleanup/oracle-harness

Conversation

@oglassdev

Copy link
Copy Markdown
Owner

Summary

  • Consolidates oracle/windows-dao into one runner (dao.py) that dispatches to typed registry/ (byte-model, driven by crates/jet3/examples/*_candidate.rs) and suites/ (spec + module) suites, replacing the former per-suite script collection.
  • Retires oracle/windows-dao/scripts/ down to the protocol-inventory tools (build_v1_2_inventory.py, protocol_validation.py, validate_protocol_v1_2.py); deletes acquisition/, dev-tools/, scripts/dao-check.py, scripts/windows-dao-ps.py, and all superseded per-suite tests, keeping only tests/test_harness.py and tests/test_protocol_validation.py.
  • Fixes two harness bugs found while porting to the shared VM transport: Common.ps1 Cell-Value now uses a unary comma for binary/long_binary (DAO previously raised error 3421 from unrolled byte[]), and Native.ps1 New-Index now defaults kind to ordinary.
  • Rewrites oracle/windows-dao/README.md with a current suite table and an archive table (EXP-0241–0298, the retired 0299–0311 per-suite scripts, and the registry transport) pointing at tag oracle-archive-2026-09 (9638d38) where every old path still exists.
  • Updates docs/LOCAL_WINDOWS_VM.md, TOOLING.md, justfile (windows-dev-ps → dao *args), and support-matrix.json evidence paths for the new layout.

Final replay (EXP-0312)

Ran on revision da77f4cc4d4ded702c936e07006563ad2685f04f against x86 DAO 3.6 (dao360.dll 03.60.9765.0, SHA-256 4cc28a5be8dc7425a4c4c1ef275ca392f18be35d70232e777dce6d9f3b4d79ac), Windows NT 10.0.20348, en-US/ANSI 1252. All 19 suites, run dirs under shared/checks/20260924-oracle-harness/final-2/{a,b,c} (private, not committed).

Suite Outcome vs accepted
indexed-boundary, indexed-rows, wide-rows matched
numeric-indexes matched (7200s timeout; only ever timed out at 900s on the old per-suite runner)
index-trees, practical-lifecycle, index-capacity, creation-tables matched
storage-preservation matched: 54 lifecycle + 18 refusal pairs
storage-churn matched: 76 pairs
one-to-one-creation matched: 18 creations
one-to-one matched: 48 accepted + 14 residue
relationship-forms matched: 1 creation, 41 accepted, 9 refused, 3 residue, 1 rust-only, 105 reader
locale-updates matched: 60 accepted + 12 residue + 6 continuations
text-properties matched: 40 creation pass (+ known c21 ×2 recorded failure), 26 accepted, 4 refused, 6 rust-only edits
multiple-long-values, long-value-lifecycle matched
definition-chains fails at prepare: ValueError: Compact candidate continuation placement — same as main (Rust example output changed after EXP-0247)
allocation-lifecycle fails at generate: Catalog(Page(Read(LimitExceeded { kind: TotalReadBytes, requested: ByteCount(536870927), maximum: ByteCount(536870912) }))) — same as main

Both pre-existing failures are unrelated to this consolidation and remain open. text-properties records one intentional behavior change since EXP-0300: Nordic-collation cases x03/x04 were Rust-refusal controls there, but Rust has accepted Nordic text-property edits since EXP-0310, so they're now paired DAO edits with structure comparison skipped.

Main advanced during this replay (#389 parser layout → #390/#391 write-internals and creation-API refactors → #392 test-only changes). This branch was rebased onto each in turn; none touch oracle/. scripts/golden-check.sh 430a6cb on the rebased tree reports 1,923 files, 1,923 identical, 0 differ, confirming #390/#391 are behavior-preserving, so the replay above (run at da77f4c, before the rebases) was not repeated. See docs/PROVENANCE.md EXP-0312 for the full record.

Retired suites

Everything in the README archive table rows 0241–0298 is retired, including row_overflow_lifecycle, fixed_text_index_lifecycle and empty_value_lifecycle (rows 0262–0267), which had Rust examples but no kept runner. Their original scripts and results remain at tag oracle-archive-2026-09.

Line counts

  • Code (py/ps1/cs/sh) in oracle/windows-dao plus the two root scripts/ files: 30,525 → 11,942 lines
  • Non-protocol JSON: 27,144 → 2,653 lines
  • Files in oracle/ + scripts/ (excluding the untouched protocol/v1_2/ and .gitignore): 183 → 67

Test plan

🤖 Generated with Claude Code

Replace the copy-pasted per-suite scripts with one shared harness in
oracle/windows-dao: dao.py (runner, VM transport, spec expansion, reports),
Common.ps1, Native.ps1 (JSON operations), Observe.ps1 (complete readback),
structure.py (raw decoder), keys.py, compare.py, generate.py and one spec
per suite in suites/. Storage lifecycles keep a small module on the same
runner; the twelve byte-model suites live in registry/ on structure.py and
dao.py. Archive-only suites are retired to tag oracle-archive-2026-09.
@oglassdev
oglassdev merged commit 3fe1fd6 into main Sep 24, 2026
10 checks passed
@oglassdev
oglassdev deleted the cleanup/oracle-harness branch September 24, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant