Repository navigation
refactor: generate DAO candidates through jet3-cli requests (#380 part 6) - #394
Merged
Merged
Conversation
…t --layout
create and mutate accept --max-allocation-bytes, --max-work-units, --max-chain-depth and --max-encoded-bytes after --input; row cells accept {"long_value": [...]}; inspect --layout reports each table's row locators, stored bytes, long-value payloads and references, and index definitions and trees. Existing requests and outputs are unchanged.
Registry suites describe their Rust candidates as ordered jet3-cli request recipes (oracle/windows-dao/recipes.py) built with the run's frozen CLI. Rust reader receipts come from jet3-cli validate and inspect --layout; refusal receipts from the CLI results. golden-check builds the same recipes plus the archived candidates' recipes (scripts/golden_recipes).
Their recipes now live in the oracle registry modules and scripts/golden_recipes; the indexed-boundary test fixture moves under crates/jet3/tests/support.
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last cleanup item of #380. The 39
crates/jet3/examples/*candidate programs and their*_support/directories are gone. Every DAO suite now builds its candidates fromjet3-clicreate/mutate requests.Approach
candidates(spec)method. It returns image recipes of the form{file, from, steps}.oracle/windows-dao/recipes.pyruns those recipes throughjet3-cli. Steps can be a request, limits,locate(a row locator lookup, optionally in another image), an expected refusal, or a small byte edit. The byte edit is used for the wide-row damage cases.jet3-cli inspect --layout.common.reader()loads that output, and each suite adapts it to its existing receipt shape. Self-validation still goes throughcommon.validate.prepare_continue) are also built through recipes.scripts/golden-check.shnow builds onlyjet3-cli. It runsscripts/golden_corpus.py, which applies the creation/mutation recipes inscripts/golden_recipes/plus every registry suite's candidates, together with the existing CLI types/schema/mutate corpus.crates/jet3/tests/support/indexed_boundary.rs.tools/validate_contract.pypasses) and the suite specs (theexamplekey is removed).inspect --layout. The parser crate's public API is unchanged.CLI additions
Existing requests produce the same behavior and output.
mutateandcreatetake the--max-allocation-bytes,--max-work-units,--max-chain-depthand--max-encoded-bytesflags after--input. They set the write resource budget. The allocation and chain-budget refusal suites need these.{"long_value": [bytes...]}cell passes raw long-value bytes, so the caller-supplied-header refusal can be expressed.inspect <file> --layout [--table <name>]reports:crates/jet3-cli/tests/{inspect,mutate}.rs.Byte identity (base 3fe1fd6 examples vs HEAD recipes)
SHA-256 of every database the base examples produced (from the golden corpus's
gen/andmut/directories), compared with the recipe-built corpus:The HEAD corpus has 328 databases, and none of them lacks a base counterpart: the extra five are repeated fixtures. With
JET3_ROW_OVERFLOW_CAPTURESset, the opt-in row-overflow recipes match as well: 42/42 identical.Offline replay against retained DAO runs
The retained 20260924-oracle-harness outboxes were replayed without the VM. For each suite, the regenerated candidate images and continuation images were byte-compared with the retained ones, and
evaluatewas re-run:Golden-check corpus
scripts/golden-check.sh HEAD(base == head): 8,047 files, 8,047 identical, 0 differ, in 32s.Failures that already exist on main
Both were converted as-is, with the same bytes and the same failure. They are not fixed or hidden here.
definition-chains: prepare still fails with "Compact candidate continuation placement". All 6 candidate images are identical.allocation-lifecycle: still fails withfield update failed: Catalog(Page(Read(LimitExceeded { kind: TotalReadBytes, requested: ByteCount(536870927), maximum: ByteCount(536870912) }))). All 4 images are identical, and the receipt adapter matches the old Rust receipts.Checks
just ready: passed. It covers fmt, clippy, tests, docs, source size, the support matrix, and the Python checks, including 20 oracle unit tests.dao.py listenumerates all 19 suites.Size
crates/jet3/examples/: removed 47 files and 9,410 lines.🤖 Generated with Claude Code