Repository navigation
Draw every titled screen's name in the ink colour - #53
Merged
Merged
Conversation
The hero title and the title docked into the bar were the screen's accent on web, Calendar and Completed on Android and iOS, and the docked title on Android lists, while Settings, Guide and the Android list hero were already ink. Titles are ink everywhere now; the colour stays in the disc, its wash and the add button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every titled screen now draws its name in the ink colour, in the hero block and in the bar it docks into. The screen's own colour stays in its disc, the wash behind the glyph and the add button.
Before this the same word was drawn three ways: accent-coloured on the web and in Calendar and Completed on Android and iOS, accent-coloured only when docked on Android lists (their hero was already ink), and ink on Settings, Guide and Sweep.
text-foregroundon the shared title type class, so the heroh1, the docked copy and the measuring span cannot drift apart.accentColoris gone frompageCollapse, which only used it for the title.titleColorarguments on Calendar, Completed and the list toolbar; the defaults areonBackground.TodoTimelineTitleLabelreadscolors.onSurfaceitself, and the Calendar bar's two title copies do the same.docs/ARCHITECTURE.md.No user-facing behaviour changes, so no How-To guide topic.
Verified here: web lint, 2094 web tests, web build, and the Android compile plus unit tests. Not verified here: iOS (no Xcode on this host; the macOS CI is the check) and how any of it looks on a device.
Not in this PR: the shared bar rule (back, search, one primary action, overflow menu). Reading the code showed it moves Summarize and Sweep behind an extra tap and drops the web's deliberate one-tap Select all, so it needs its own decision and PR.