Repository navigation
Give every list bar the same buttons in the same order - #55
Merged
Merged
Conversation
Summarize, then Select, then the screen-specific buttons, then Edit list: a pencil for owners and the people glyph labelled Members for everyone else, on web, Android and iOS. The phones' ellipsis opened the settings sheet directly, so it promised a menu that was not there. The web's separate Select all button is gone; Select all lives inside selection mode on all three, as it already did on the phones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every list screen's top bar now has the same buttons in the same order on web, Android and iOS: Back, Search, Summarize, Select, then the screen-specific buttons (Sweep on Overdue, Reset on a reusable floater list), then Edit list.
users-round) labelled "Members" for everyone else, on all three. Android and iOS used an ellipsis that opened the settings sheet directly, so it promised a menu that was not there. No new icon assets; the new "Edit list" label is translated in the 9 locales on Android and iOS, and the unused "More options" string is gone.enterSelectionWithAlland its two tests). Select all lives inside selection mode on all three platforms, as it already did on the phones.docs/ARCHITECTURE.md. No How-To guide change: the guide already describes Select all inside selection mode.Verified here: web lint, 2092 web tests and the web build; Android compile and unit tests.
lintDebugfails on a clean checkout too (existing errors, none in these files). Not verified here: iOS (no Xcode on this host; the macOS xctest job is the check) and how it looks on a device.Not in this PR: Select on the web's floater lists. The web's bulk selection is built on scheduled-todo rows and endpoints, so floaters need their own bulk actions first.