Stand the bar icon upright - #3
Closed
spencerbull wants to merge 1 commit into
Closed
spencerbull wants to merge 1 commit into
spencerbull wants to merge 1 commit into
Conversation
The globe glyph in the bar was leaned over by the earth's obliquity via WidgetButton.textRotation. The shell draws bar glyphs with native text rendering at about thirteen pixels, and the glyph's lattice does not survive being turned off the pixel grid: it came out as a dotted blob. Qt's other render types were tried on the same glyph at the same angle on a GPU scenegraph and none resolved the graticule, so the icon stands upright. The hero globe in the panel is drawn, and keeps its lean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The globe in the bar rendered as a dotted blob rather than a globe.
Panel.qmlleaned the bar glyph over by the earth's obliquity, passingtextRotation: Solar.AXIAL_TILT(23.44 degrees) toBarIconButton. The shell draws bar glyphs throughOpticalGlyph, which usesText.NativeRenderingat about thirteen pixels. Native rendering assumes pixel-aligned text, and the globe glyph (U+F0AC) is a lattice of roughly one-pixel lines, so turning it off the pixel grid shreds it. Every other icon in the bar is upright and crisp.Both components are identical in the packaged shell (
/usr/share/omarchy/shell/Ui/), so this is what every install shows, not something particular to a dev shell.The fix
The bar icon stands upright: the
textRotationline is gone, and the comment in its place says why. The hero globe in the panel keeps its lean; it is drawn on aCanvasand large enough to carry it.The README said "The sidebar icon carries the same tilt, via
WidgetButton.textRotation." It now says the icon does not, and why.Why not keep the tilt another way
Two alternatives were rendered and set aside:
BarIconButton.iconComponentwould let the plugin supply its ownTextwithText.QtRenderingorText.CurveRendering. Rendered at the same size and angle, QtRendering came out colour-fringed and CurveRendering had a smoother outline, but neither resolved the graticule. At thirteen pixels the lattice does not survive the rotation under any of Qt's renderers; native rendering is only the worst of them.MiniGlobeas the bar icon. Below 22 pixels it draws the graticule alone, which at bar size reads as a crosshair in a circle, and its filled disc is heavier than the glyph icons beside it.Verified
GraphicsInfo.apilogged alongside the grab. An earlier pass underQT_QPA_PLATFORM=offscreenwas discarded: that platform falls back to the software backend, which ignoresrenderTypeand paints all text through QPainter, so it cannot distinguish the render types.scripts/check-manifest.shpasses andtests/run --offlinepasses (11 node checks, the currency table, 6 QML tests). Nothing in the suite covers the bar icon, so these show only that nothing else moved.