You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bash syntax checks passed for every changed script
bin/omarchy commands --check: 469 commands passed
git diff --check: passed
independent package and integration reviews: passed with no blocking security or logic findings
The repository-wide shell suite still has 14 baseline/environment-sensitive failures also present without this change; the new BCM43602 suite passes within that run.
Independent review (AI-assisted, Claude). Read the detector, the install leaf, the migration and the test; ran the QA set in an Ubuntu 24.04 arm64 container.
Overall
The shape matches the existing linux-t2 integration exactly (offline list entry, PCI/DMI-gated leaf in install/hardware/apple/, limine-entry-tool.d drop-in, migration that reruns the leaf through sudo bash as 1787052918.sh does), and the stock kernel is kept as a fallback. No blocking defects in the code.
Blocking dependency
omacom/omarchy-pkgs#422 is still open and held for review (four SKIP checksums on a 13k-line kernel package). Until linux-bcm43602 exists in the repo, omarchy-pkg-add in the leaf fails on the affected machine and the new install/omarchy-other.packages entries break the ISO's offline mirror build for every Mac. This probably wants defer until the package lands.
Things worth a maintainer decision
install/omarchy-other.packages now carries a second full kernel plus headers for one model (MacBookPro12,1). That is the same trade-off already made for linux-t2, so consistent, but it is ISO size for everyone.
The detector matches DMI product MacBookPro12,1 exactly. Other Macs with the same BCM43602 (14e4:43ba, Apple subsystem 106b:0133), for example MacBookPro11,4/11,5 and MacBookAir7,x, will never get the kernel even if they show the same resume bug. Given only 12,1 was live-tested that is a defensible choice, but a comment saying how to extend the allow-list would help the next reporter.
The leaf runs before fix-wifi-resume.sh in install/hardware/all.sh; that script is gated to aarch64 and 14e4:(4425|4433), so no overlap.
Nits
install-bcm43602-kernel.sh ends with an empty line inside the function before the closing brace.
shellcheck (warning level) flags rm -rf "$test_tmp/boot" "$test_tmp/etc" in the test (SC2115); "${test_tmp:?}" would silence it. CI passes at the configured severity, so cosmetic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linux-bcm43602and its matching headers without removing stock LinuxDepends on omacom/omarchy-pkgs#422.
Hardware scope
The integration runs only when all of these match:
x86_64Apple Inc.MacBookPro12,114e4:43ba106b:0133The detector reads live system values through absolute command paths; environment variables cannot override the hardware identity.
Installation behavior
/boothas at least 256 MiB available before changing the systemlinux-bcm43602andlinux-bcm43602-headerslinuxremains installedLive validation
Validated on the affected MacBookPro12,1 with real lid-close
deepS3:7.2.3-arch1-3reproduced 11 firmware command timeouts and lost Wi-Fi7.2.3-arch1-1-bcm43602booted with kernel taint0brcmf_msgbuf_query_dcmdtimeouts, D3 failures, Oopses, or general protection faultsNo sleep hook, post-resume service, module unload/reload, or external reset script was used.
Tests
bash test/shell.d/apple-bcm43602-kernel-test.sh: 13/13 passedbin/omarchy commands --check: 469 commands passedgit diff --check: passedThe repository-wide shell suite still has 14 baseline/environment-sensitive failures also present without this change; the new BCM43602 suite passes within that run.