Fix sync-preparing status classification - #101
Merged
Merged
Conversation
Treat Syncthing's transient sync-preparing state as idle when there is no pending work, while preserving active syncing for pending items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
lgtm thx @dawez was thinking about that too iam doing some ui checks atm but will merge your idea once I find a good entry point in the current changes |
- keep zero item syncing snapshots visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Syncshell classified every Syncthing folder state beginning with
syncas actively syncing. Syncthing can reportsync-preparingwhile it is preparing or processing transient remote updates, even whenneedTotalItemsandneedBytesare zero. The panel therefore flickered between preparing/syncing/scanning and up-to-date despite the folder being synchronized.Change
Only report a folder as syncing when it has pending items or Syncthing reports the concrete
syncingstate. Scanning and activity handling remain unchanged.Testing
sync-preparingwith no pending work.Root cause
The folder projection used
state.indexOf("sync") === 0, which matched bothsyncingand the transientsync-preparingstate. That prefix check was broader than the intended active-sync state.