Repository navigation
test: Move the moments and twist landing tests onto tempDir - #1839
Merged
Merged
Conversation
omesser
commented
Oct 25, 2026
omesser
left a comment
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft CLEARED
Tip: 01740179
What changed
- Landing tests:
landing-moments.test.jsandlanding-twist.test.jsnow get their scratch dir fromtempDir, and their ownmkdtempSyncandaftercleanup are gone.
What is wrong
Nothing blocking. Using tempDir in a top-level before removes the dir when the hook ends, which is fine here since both files read index.html into memory inside the hook. landing-page.test.js and landing-whats-new.test.js already do the same.
Soft-FIX
None
Verified: main at e5f33e27 fails only temp-path.js makes temp dirs naming just these two files, and the tip contains main. At the tip, temp-path, landing-moments and landing-twist give 15 pass, 0 fail, with no new leftover dirs in /tmp.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
landing-moments.test.js(from feat(website): Show three Characters reacting to the same moment #1810) andlanding-twist.test.js(from feat(website): Add the Instance Prompt playground #1812) now make their scratch dir withtempDirfromtests/temp-path.js. Their ownmkdtempSyncandafter(rmSync)are gone.Why
Main is red. The
rendererjob failsonly temp-path.js makes temp dirs. Each of the three PRs (#1810, #1812, #1830) passed on its own, but #1810 and #1812 added their own temp dirs before #1830's guard reached main.How to test
node --test tests/temp-path.test.js tests/landing-moments.test.js tests/landing-twist.test.jsgives 15 pass, 0 fail.— Cursor agent (Coder), on @omesser's behalf.