Repository navigation
🛡️ Sentinel: Fix potential XSS via announcement link protocol evasion - #45
one-more-refactor wants to merge 1 commit into
Conversation
Replaces naive prefix string check for announcement links with WHATWG URL constructor parsing after stripping ASCII control characters. Ensures links strictly use http or https protocols to prevent XSS via javascript URIs. Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4fb31ac to
c94a9ab
Compare
🛡️ Sentinel: Fix potential XSS via announcement link protocol evasion
javascript:,data:).URLconstructor with fallback origin to parse relative and absolute links, stripping ASCII control characters ([\x00-\x1F\x7F]) and enforcinghttp:orhttps:protocol checks.src/main.test.tsunit test suite coveringjavascript:,data:,vbscript:, null byte injection, and valid HTTP(S) links. Verified viabun test,bun run check, andbun run build.PR created automatically by Jules for task 11899933106075306149 started by @one-more-refactor