Repository navigation
π‘οΈ Sentinel: Fix XSS protocol obfuscation in announcement link validation - #46
one-more-refactor wants to merge 1 commit into
Conversation
β¦tion Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: Simple prefix string matching for announcement links allowed obfuscated dangerous protocol URLs (e.g. control characters inserted into javascript: or data: protocols) or protocol-relative external redirects.
π― Impact: Potential XSS or unintended navigation if malicious URLs were saved into public site announcement banners.
π§ Fix: Enhanced URL validation by stripping ASCII control characters and null bytes, parsing with standard URL constructor, ensuring protocol is http: or https:, and disallowing protocol-relative // URLs.
β Verification: Added unit tests in src/announcement_url.test.ts, ran bun test, bun run check, and bun run build.
PR created automatically by Jules for task 6961485221136022041 started by @one-more-refactor