🛡️ Sentinel: [HIGH] Refactor and strengthen URL validation logic - #48
one-more-refactor wants to merge 1 commit into
Conversation
Replace simple string prefix matches with standard URL constructor parsing and ASCII control character stripping to prevent XSS via javascript: links. Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🛡️ Sentinel Security Improvement
src/url.ts.[\x00-\x1F\x7F]) before parsing URLs withnew URL()constructor to prevent parser evasion tricks.http:,https:, and relative paths (/) while blocking protocol-relative URLs (//).src/url.test.ts.PR created automatically by Jules for task 13831369689806800820 started by @one-more-refactor