Skip to content

πŸ›‘οΈ Sentinel: Fix URL protocol validation to prevent XSS in announcement links - #51

Open
one-more-refactor wants to merge 1 commit into
masterfrom
sentinel/fix-url-validation-xss-1720665581646687444
Open

one-more-refactor wants to merge 1 commit into
masterfrom
sentinel/fix-url-validation-xss-1720665581646687444

Conversation

@one-more-refactor

Copy link
Copy Markdown
Owner

This PR addresses a potential XSS vulnerability in announcement link submission.

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Simple prefix string matching for URL validation can be bypassed using embedded ASCII control characters or null bytes (java\x00script:, java\x09script:) or non-standard relative protocol syntax.
🎯 Impact: Attackers could inject executable javascript: links into user-facing announcement banners.
πŸ”§ Fix: Strip control characters (/[\x00-\x1F\x7F]/g), validate allowed link prefixes (http://, https://, /), and parse with new URL(sanitized, base) to ensure strict http: or https: protocol adherence.
βœ… Verification: Created unit tests in src/url.test.ts verifying valid URLs, relative paths, control character stripping, and rejection of dangerous protocols (javascript:, data:, vbscript:). Verified using bun test, bun run check, and bun run build.


PR created automatically by Jules for task 1720665581646687444 started by @one-more-refactor

Strip ASCII control characters and null bytes before parsing URLs using the standard `URL` constructor against `window.location.origin`, and enforce allowed schemes (`http:`, `https:` or relative `/`). Add unit test suite in `src/url.test.ts`.

Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

  • πŸ” Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ec4e72fd-8854-4c5e-aa1c-fa4661b9e48c


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant