π‘οΈ Sentinel: Fix URL protocol validation to prevent XSS in announcement links - #51
one-more-refactor wants to merge 1 commit into
Conversation
Strip ASCII control characters and null bytes before parsing URLs using the standard `URL` constructor against `window.location.origin`, and enforce allowed schemes (`http:`, `https:` or relative `/`). Add unit test suite in `src/url.test.ts`. Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR addresses a potential XSS vulnerability in announcement link submission.
π¨ Severity: HIGH
π‘ Vulnerability: Simple prefix string matching for URL validation can be bypassed using embedded ASCII control characters or null bytes (
java\x00script:,java\x09script:) or non-standard relative protocol syntax.π― Impact: Attackers could inject executable
javascript:links into user-facing announcement banners.π§ Fix: Strip control characters (
/[\x00-\x1F\x7F]/g), validate allowed link prefixes (http://,https://,/), and parse withnew URL(sanitized, base)to ensure stricthttp:orhttps:protocol adherence.β Verification: Created unit tests in
src/url.test.tsverifying valid URLs, relative paths, control character stripping, and rejection of dangerous protocols (javascript:,data:,vbscript:). Verified usingbun test,bun run check, andbun run build.PR created automatically by Jules for task 1720665581646687444 started by @one-more-refactor