π‘οΈ Sentinel: Fix URL protocol validation in announcements - #55
one-more-refactor wants to merge 1 commit into
Conversation
β¦s for announcement links Replace naive string prefix matching in announcement link validation with ASCII control character stripping and standard WHATWG URL parsing. Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: Naive
.startsWith()string matching was used for announcement link protocol validation, which can be bypassed via embedded ASCII control characters (e.g. null bytes\x00) or non-standard protocol formats.π― Impact: Attackers could bypass URL validation to inject malicious client-side protocols (
javascript:,data:, etc.) leading to Cross-Site Scripting (XSS).π§ Fix: Stripped ASCII control characters (
[\x00-\x1F\x7F]) and replaced string prefix checks with standard WHATWGURLconstructor protocol resolution, enforcinghttp:orhttps:.β Verification: Ran
bun run checkandbun run build. Verified that dangerous schemes and obfuscated control characters are reliably rejected.PR created automatically by Jules for task 10567367803435919058 started by @one-more-refactor