Repository navigation
π‘οΈ Sentinel: Fix URL protocol validation to prevent XSS - #56
one-more-refactor wants to merge 1 commit into
Conversation
Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGH
π‘ Vulnerability: Simple prefix string matches allowed obfuscated JS protocols (e.g., via ASCII control characters or null bytes) to bypass URL validation.
π― Impact: Attackers could inject malicious javascript: or data: URIs in announcement links resulting in stored XSS on the user site.
π§ Fix: Stripped ASCII control characters and null bytes ('[\x00-\x1F\x7F]') and validated protocol using the standard URL constructor.
β Verification: Added unit tests in src/url_validation.test.ts and ran bun test, bun run check, and bun run build.
PR created automatically by Jules for task 9654341454508009415 started by @one-more-refactor