🛡️ Sentinel: [HIGH] Harden URL protocol validation in announcement links - #57
one-more-refactor wants to merge 1 commit into
Conversation
- Strip ASCII control characters and null bytes (\x00-\x1F\x7F) from announcement links before checking format. - Prevent protocol-relative URLs (//) to eliminate open-redirect and protocol confusion risks. - Use the standard URL constructor to strictly validate that parsed protocols are restricted to http: and https:. Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🛡️ Sentinel Security Improvement
Severity: HIGH / Security Enhancement
Vulnerability: Weak URL protocol validation in announcement link configuration. Simple prefix checking can be bypassed using null bytes or ASCII control characters (e.g.
java\x00script:,java\tscript:) or protocol-relative URLs (//evil.com).Impact: XSS via
javascript:/data:links or protocol confusion / open redirects on user announcement banners.Fix:
[\x00-\x1F\x7F]) prior to checking and parsing.//).new URL(sanitized, 'http://localhost')and verify the resulting protocol is strictlyhttp:orhttps:.Verification:
bun run check(0 errors) andbun run buildsuccessfully.PR created automatically by Jules for task 5931419066498572005 started by @one-more-refactor