Skip to content

🛡️ Sentinel: [HIGH] Harden URL protocol validation in announcement links - #57

Open
one-more-refactor wants to merge 1 commit into
masterfrom
jules/security-enhance-url-validation-5931419066498572005
Open

one-more-refactor wants to merge 1 commit into
masterfrom
jules/security-enhance-url-validation-5931419066498572005

Conversation

@one-more-refactor

Copy link
Copy Markdown
Owner

🛡️ Sentinel Security Improvement

Severity: HIGH / Security Enhancement
Vulnerability: Weak URL protocol validation in announcement link configuration. Simple prefix checking can be bypassed using null bytes or ASCII control characters (e.g. java\x00script:, java\tscript:) or protocol-relative URLs (//evil.com).
Impact: XSS via javascript: / data: links or protocol confusion / open redirects on user announcement banners.
Fix:

  • Strip ASCII control characters and null bytes ([\x00-\x1F\x7F]) prior to checking and parsing.
  • Explicitly disallow protocol-relative URLs (//).
  • Validate the link using new URL(sanitized, 'http://localhost') and verify the resulting protocol is strictly http: or https:.
    Verification:
  • Ran bun run check (0 errors) and bun run build successfully.
  • Verified test cases covering valid http/https URLs, relative path links, protocol-relative links, and obfuscated control character payloads.

PR created automatically by Jules for task 5931419066498572005 started by @one-more-refactor

- Strip ASCII control characters and null bytes (\x00-\x1F\x7F) from announcement links before checking format.
- Prevent protocol-relative URLs (//) to eliminate open-redirect and protocol confusion risks.
- Use the standard URL constructor to strictly validate that parsed protocols are restricted to http: and https:.

Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 03361465-6864-4207-89bb-a6fe196a84ff


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant