Repository navigation
🛡️ Sentinel: [HIGH] Fix URL protocol validation XSS vulnerability - #58
one-more-refactor wants to merge 1 commit into
Conversation
…fuscation - Replace prefix matching with URL parsing and control character stripping - Reject javascript:, data:, vbscript:, and other dangerous schemes - Add unit tests verifying valid and obfuscated URLs Co-authored-by: one-more-refactor <297687349+one-more-refactor@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚨 Severity
HIGH
💡 Vulnerability
The announcement link validation previously used basic string prefix checks (
startsWith). Attackers could potentially obfuscate URI schemes (e.g. inserting ASCII control characters or null bytes likejava\x01script:) to bypass simple prefix filters.🎯 Impact
If exploited, malicious links could execute arbitrary JavaScript in the victim operator/user's browser context (XSS).
🔧 Fix
[\x00-\x1F\x7F]).new URL(clean, origin).http:orhttps:.✅ Verification
Ran
bun testwith 5 unit test cases insrc/url.test.tscovering valid URLs, relative paths, and obfuscatedjavascript:,data:, andvbscript:payloads. All tests passed. Also verified withbun run checkandbun run build.PR created automatically by Jules for task 17624849589202118736 started by @one-more-refactor