Skip to content

Release 1.8.0 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Subterrane merged 1 commit into from
Aug 4, 2026
Merged

Release 1.8.0 #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/onelogin/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module OneLogin
VERSION = "1.7.0"
VERSION = "1.8.0"

@Subterrane Subterrane Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a mismatch — this is a release PR, so the one-line diff and the description are describing different things by design.

Everything listed is already merged on main. The version bump is the only thing left to do before those changes can be published, because RubyGems keys releases off OneLogin::VERSION. Verified against main's tree just now:

description item on main
Cursor non-JSON guard is_a?(Hash) in cursor.rb
ApiException#code attr_reader :code present
Symbol-key params stringify_param_keys, 4 references
create_app guard if !app_params.has_key?('connector_id')
Ruby floor required_ruby_version = '>= 3.2'
CI matrix ruby: ['3.2', '3.3', '3.4']
Sorting docs 2 sort: examples in README
Specs 48 examples, 0 failures on Ruby 3.2

They landed via #98, #107, #111, #112, #113, #115, #118, #119, #120, #121, #122 and #123.

The description is the changelog for 1.8.0, not for this diff — it's what becomes the GitHub release notes and what a consumer reads to decide whether to upgrade. Trimming it to "bump VERSION to 1.8.0" would leave the release undocumented, which is the opposite of accurate.

This matches how 1.7.0 was cut in #110, and keeps release PRs trivially reviewable: the diff is one line, so the only question is whether the version number is right.

On that: 1.8.0 rather than 1.7.1 because ApiException#code is new public API, and rather than 2.0.0 because the required_ruby_version raise doesn't break existing builds — RubyGems' resolver filters by compatibility, so Ruby 3.0 users resolve to 1.7.0 instead of failing.

end
Loading