Skip to content

[FIX] fix aux loss incorrectly scaling with CP - #520

Merged
mayank31398 merged 1 commit into
mainfrom
l1p
Sep 25, 2026
Merged

mayank31398 merged 1 commit into
mainfrom
l1p

Conversation

@mayank31398

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Mayank Mishra <mayank31398@gmail.com>
@mayank31398
mayank31398 merged commit 34a6659 into main Sep 25, 2026
1 of 3 checks passed
@mayank31398
mayank31398 deleted the l1p branch September 25, 2026 04:04
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 776e6d7a-b8ea-488c-8906-c3c6c2b1854c

📥 Commits

Reviewing files that changed from the base of the PR and between abb9092 and de6e901.

📒 Files selected for processing (1)
  • lm_engine/training/modeling_utils/mlp_blocks/moe/module.py
 _____________________________________________________________________________________________________________________________________________________
< Progress in a fixed context is almost always a form of optimization. Creative acts generally don't stay in the context that they are in. - Alan Kay >
 -----------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant