Skip to content

Fix s3 readme with refined metrics - #484

Open
plyfager wants to merge 3 commits into
open-mmlab:masterfrom
plyfager:plyfager/master-s3-readme
Open

Fix s3 readme with refined metrics#484
plyfager wants to merge 3 commits into
open-mmlab:masterfrom
plyfager:plyfager/master-s3-readme

Conversation

@plyfager

Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@plyfager plyfager changed the title fix s3 readme Fix s3 readme Nov 24, 2022
@plyfager plyfager changed the title Fix s3 readme Fix s3 readme with refined metrics Nov 24, 2022
@plyfager
plyfager requested a review from LeoXing1996 November 24, 2022 03:47
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.81%. Comparing base (d1039e0) to head (4b43138).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   74.81%   74.81%           
=======================================
  Files         145      145           
  Lines       11015    11015           
  Branches     2097     2097           
=======================================
  Hits         8241     8241           
  Misses       2233     2233           
  Partials      541      541           
Flag Coverage Δ
unittests 74.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants