Skip to content

docs(adr): fix stale 0006/0031, add 0032 (sub-workflows) + 0033 (DI), Proposed-backlog roadmap note - #92

Merged
gustavobertoi merged 1 commit into
mainfrom
docs/adr-review-fixes
Jun 4, 2026
Merged

gustavobertoi merged 1 commit into
mainfrom
docs/adr-review-fixes

Conversation

@gustavobertoi

Copy link
Copy Markdown
Collaborator

Follow-ups from an ADR review of the full corpus (31 ADRs).

Stale fixes

  • 0006 (LLM provider abstraction) — the "registry built once at startup, keys static per
    process" consequence was stale: ADR-0031 made provider construction dynamic (per-provider
    llm.ProviderFactory closures resolving {{secret:}}/{{credential:}} per environment). Updated
    the consequence and retargeted the two references to the now-superseded ADR-0008 → ADR-0031.
  • 0031 (settings/secrets/environments) — its More Info said credential objects "remain
    scheduled," but Phase 2 credentials shipped (domain, repo, migration 000011,
    /v1/credentials CRUD, fuse credentials CLI, and the three reference forms over the reserved
    cred/<id>/<field> namespace). Marked shipped; only Infisical remains scheduled. Noted
    SourceCredential.

New ADRs (documenting existing, costly-to-reverse decisions)

  • 0032 — Sub-workflow composition: child workflows as first-class instances linked by a durable
    SubWorkflowRef (sync/async, journal subworkflow:*, HA cross-node completion). Previously only
    mentioned in passing.
  • 0033 — Dependency injection & app composition with uber-go/fx: the fx.Module/AllModules
    composition root, driver selection, optional deps, lifecycle, and partial graphs for CLI/tests.
    ADR-0002 covers the ergo runtime, not app assembly.

Index hygiene

  • README rows for 0032/0033, and a roadmap note clarifying that Proposed ADRs 0026–0030
    are a cohesive agent-capabilities backlog (none implemented), and 0025 (browser automation) is
    a separate parallel stream.

Docs-only; all intra-ADR links verified to resolve.

🤖 Generated with Claude Code

…dmap note

ADR review follow-ups:
- 0006 (LLM provider): the "static at startup" registry consequence was stale —
  0031 made provider construction dynamic (per-provider factories resolving
  secret/credential refs per environment). Updated the consequence and retargeted
  the superseded ADR-0008 references to ADR-0031.
- 0031: mark Phase 2 credential objects as shipped (domain, repo, migration
  000011, /v1/credentials CRUD, fuse credentials CLI, and the three reference
  forms over the reserved cred/<id>/<field> namespace); only Infisical remains
  scheduled. Note SourceCredential.
- New 0032: sub-workflow composition (child workflows as first-class instances
  linked by a durable SubWorkflowRef; sync/async; journal + HA) — previously
  undocumented.
- New 0033: dependency injection & app composition with uber-go/fx modules —
  previously undocumented.
- README: index rows for 0032/0033 + a roadmap note clarifying the Proposed
  agent-capabilities backlog (0026-0030) and that browser automation (0025) is a
  separate stream.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gustavobertoi
gustavobertoi merged commit eed63c1 into main Jun 4, 2026
5 checks passed
@gustavobertoi
gustavobertoi deleted the docs/adr-review-fixes branch June 4, 2026 06:19

This branch was previously deployed

1 inactive deployment
prod — 953e6e69 Deployed Jun 3, 2026 by gustavobertoi via pr-image #316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant