Skip to content

opamp: avoid enabling heartbeats after connection failure - #5064

Open
saichowdary007 wants to merge 11 commits into
open-telemetry:mainfrom
saichowdary007:fix/opamp-heartbeat-after-failed-initial-connection
Open

saichowdary007 wants to merge 11 commits into
open-telemetry:mainfrom
saichowdary007:fix/opamp-heartbeat-after-failed-initial-connection

Conversation

@saichowdary007

Copy link
Copy Markdown

Description

Fixes #5053. Only run the OpAMP initial-state completion callback after a response was received successfully. Retry exhaustion and shutdown during backoff now leave heartbeat scheduling disabled.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • PYTHONPATH=src uvx --from uv==0.12.1 uv run --directory opamp/opentelemetry-opamp-client --with pytest --with pytest-vcr pytest tests/opamp/test_agent.py (22 passed)
  • uvx ruff check and uvx ruff format --check on the changed files
  • git diff --check

Does This PR Require a Core Repo Change?

  • No.

Checklist

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated (not applicable)

AI assistance was used during implementation; the contributor reviewed the focused diff and test results and remains responsible for the contribution.

Assisted-by: ChatGPT 5.2
Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>
@saichowdary007
saichowdary007 requested a review from a team as a code owner September 14, 2026 23:03
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

CLA Not Signed

Assisted-by: ChatGPT 5.2
Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac160ca533

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread opamp/opentelemetry-opamp-client/tests/opamp/test_agent.py Outdated
Assisted-by: ChatGPT 5.2
Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-10-04 00:14 UTC

Two things need attention:

  • Required checks are failing — investigate the failures.
  • 1 review item — respond to each (e.g. link a commit, explain why not, ask a follow-up):
    • Top-level threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

Hi @saichowdary007 — just a friendly reminder that this pull request is waiting on you. The dashboard status comment has the open items and is kept current.

  • Replying is enough to hand it off — answer, explain why no change is needed, or ask a follow-up. The dashboard routes it onward once nothing on the list is waiting on you.
  • To hand it back for any other reason, including the dashboard getting this wrong, comment /dashboard route:reviewers.

@lzchen

lzchen commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@saichowdary007

Please sign the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

opamp: do not enable heartbeats after the initial connection job fails

2 participants