opamp: avoid enabling heartbeats after connection failure - #5064
Open
saichowdary007 wants to merge 11 commits into
Open
saichowdary007 wants to merge 11 commits into
saichowdary007 wants to merge 11 commits into
Conversation
Assisted-by: ChatGPT 5.2 Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>
|
Assisted-by: ChatGPT 5.2 Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac160ca533
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Assisted-by: ChatGPT 5.2 Signed-off-by: Saikumar Ch <saichowdary007@users.noreply.github.com>
Pull request dashboard statusWaiting on the author · refreshed 2026-10-04 00:14 UTC Two things need attention:
Status above doesn't look right?
|
|
Hi @saichowdary007 — just a friendly reminder that this pull request is waiting on you. The dashboard status comment has the open items and is kept current.
|
Contributor
|
Please sign the CLA. |
lzchen
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5053. Only run the OpAMP initial-state completion callback after a response was received successfully. Retry exhaustion and shutdown during backoff now leave heartbeat scheduling disabled.
Type of change
How Has This Been Tested?
PYTHONPATH=src uvx --from uv==0.12.1 uv run --directory opamp/opentelemetry-opamp-client --with pytest --with pytest-vcr pytest tests/opamp/test_agent.py(22 passed)uvx ruff checkanduvx ruff format --checkon the changed filesgit diff --checkDoes This PR Require a Core Repo Change?
Checklist
AI assistance was used during implementation; the contributor reviewed the focused diff and test results and remains responsible for the contribution.