Fix BoundedAttributes to log drop warning only once per record - #5727
Open
codedbyadiiii wants to merge 3 commits into
Open
codedbyadiiii wants to merge 3 commits into
codedbyadiiii wants to merge 3 commits into
Conversation
Pull request dashboard statusWaiting on maintainers · refreshed 2026-10-04 19:43 UTC Merge when ready. Status above doesn't look right?
|
herin049
approved these changes
Oct 3, 2026
herin049
left a comment
herin049
left a comment
Contributor
There was a problem hiding this comment.
Please add a changelog fragment.
Author
"Added the changelog fragment! Thank you for the review." |
herin049
reviewed
Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
BoundedAttributesto log the 'Attributes dict is full' warning only on the first dropped attribute (self.dropped == 0). This reduces excessive log spam when many attributes are dropped, while maintaining an accuratedroppedcount.Fixes #5726
Type of change
How Has This Been Tested?
BoundedAttributescapacity triggers exactly one warning and accurately tracks the total number of dropped attributes.test_attributes.pyto ensure no regressions.