Skip to content

test: remove duplicate launcher and runtime coverage - #398

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-duplicate-runtime-tests
Aug 14, 2026
Merged

test: remove duplicate launcher and runtime coverage#398
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/remove-duplicate-runtime-tests

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove duplicate SDK integration tests without dropping their behavioral assertions.

Changes

  • Keep the Windows-aware installed-launcher integration test and move the duplicate compiler-stderr assertion into it.
  • Delete the repeated npm-style launcher setup and its now-unused imports.
  • Keep one copy of the identical trusted-output-owner permission test.

Testing

  • bun test tests-ts/cli.test.ts tests-ts/cli-launcher.test.ts tests-ts/runtime.test.ts --timeout 30000 — passed.
  • pnpm run types — passed.
  • prettier --check tests-ts/cli.test.ts tests-ts/cli-launcher.test.ts tests-ts/runtime.test.ts — passed.
  • git diff --check — passed.

Risk and rollout

Production code is unchanged. The retained launcher test includes Windows junction handling, installed-bin execution, startup failure handling, and the migrated compiler-stderr assertion. The remaining owner test preserves every user-ID and permission case.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: a5c5483b65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: a5c5483b65

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Removes duplicate integration tests while retaining launcher, Windows junction, and trusted-owner coverage.

@mldangelo-oai
mldangelo-oai merged commit 1b85a01 into main Aug 14, 2026
55 of 58 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-duplicate-runtime-tests branch August 14, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants