feat: demonstrate natural-key DELETE in example scripts - #2
Open
KicksTV wants to merge 1 commit into
Open
Conversation
The natural-key detail endpoints now support DELETE, so the example scripts no longer need to fall back to the generic /api/events/ endpoint: - update_competitor.py: creates a throwaway competitor, DELETEs it via the natural-key URL, verifies 404 - update_events.py: DELETEs via the natural-key URL instead of the generic endpoint (the event is re-created afterwards as before) - update_units.py: creates a throwaway event/unit, DELETEs the unit via the natural-key URL, verifies 404 Each DELETE example only ever removes the resource it just created, so the scripts remain repeatable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1 (merged): the natural-key detail endpoints now support DELETE, so the example scripts no longer need to fall back to the generic endpoint.
update_competitor.py: creates a throwaway competitor, DELETEs it via the natural-key URL, verifies 404update_events.py: DELETEs via the natural-key URL instead of the generic/api/events/endpoint (the event is re-created afterwards as before)update_units.py: creates a throwaway event/unit, DELETEs the unit via the natural-key URL, verifies 404Each DELETE example only ever removes the resource it just created, so the scripts remain repeatable.