refactor(config): extract BindSourcesToStructs into pkg/config/binder - #3270
Open
dschmidt wants to merge 1 commit into
Open
refactor(config): extract BindSourcesToStructs into pkg/config/binder#3270dschmidt wants to merge 1 commit into
dschmidt wants to merge 1 commit into
Conversation
New leaf package (only gookit + pkg/config/defaults) so callers can bind a yaml config file without importing the aggregate service config. pkg/config keeps a backward-compatible re-export.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 10 |
| Duplication | 0 |
🟢 Coverage 69.23% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ 69.23% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (1c138ef) 84010 19259 22.92% Head commit (1af19e3) 84010 (+0) 19271 (+12) 22.94% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3270) 26 18 69.23% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
marked this pull request as ready for review
August 7, 2026 23:33
dschmidt
added a commit
to dschmidt/libre-graph-adapter-kit
that referenced
this pull request
Aug 7, 2026
dschmidt
added a commit
to dschmidt/immichframe-opencloud
that referenced
this pull request
Aug 8, 2026
Load the yaml config file via opencloud/pkg/config.BindSourcesToStructs (env vars still via opencloud/pkg/config/envdecode), so immichframe depends only on regular released opencloud (pinned to the v7.4.0 commit) and not on the adapter kit. This pulls in opencloud's service configs; opencloud-eu/opencloud#3270 extracts BindSourcesToStructs into a leaf package to drop those again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
BindSourcesToStructsinto a new leaf packagepkg/config/binder(depends only on gookit +pkg/config/defaults), so code that only needs to bind a yaml config file can import it without pulling in the aggregate service config inpkg/config.pkg/configkeeps a backward-compatible re-export, so existing callers are unchanged.Why
This lets third-party services, like my opencloud-music, adopt the exact same config pattern as OpenCloud itself (config structs + yaml/env binding) without pulling in the whole OpenCloud dependency tree.