Skip to content

Fix CI: golangci-lint tmpfs quota, KNE topology deploy failures, presubmit apt lock #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bstoll wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fix CI: golangci-lint tmpfs quota, KNE topology deploy failures, presubmit apt lock #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6818ae
Move Go build temp dir off tmpfs /tmp for golangci-lint
bstoll Oct 27, 2026
a8c7e8f
Remove disk usage debug step
bstoll Oct 27, 2026
77ce33e
Remove GOTMPDIR comment
bstoll Oct 28, 2026
5659077
Bump github.com/openconfig/kne to v0.3.4
bstoll Oct 30, 2026
48032b6
binding: delete partially created topology when Create fails
bstoll Oct 30, 2026
7946e4c
presubmit: wait for dpkg lock before installing packages
bstoll Oct 30, 2026
8b0f771
presubmit: fix super-linter findings (shfmt, SC2329, codespell)
bstoll Oct 30, 2026
bc2e09f
Merge remote-tracking branch 'origin/main' into fix-lint-gotmpdir
bstoll Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9.3.0
env:
CGO_ENABLED: 1
GOTMPDIR: ${{ runner.temp }}
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest
Expand Down
26 changes: 13 additions & 13 deletions cloudbuild/presubmit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@

set -xe

# shellcheck disable=SC2317
# shellcheck disable=SC2317,SC2329
function dumpinfo {
if [ -d "/tmp/cluster-log" ]; then
gcloud storage cp --recursive --gzip-local-all /tmp/cluster-log "gs://lemming-test-logs/$BUILD"
fi
if [ -d "/tmp/cluster-log" ]; then
gcloud storage cp --recursive --gzip-local-all /tmp/cluster-log "gs://lemming-test-logs/$BUILD"
fi
}

sudo tee /etc/google-cloud-ops-agent/config.yaml << EOF
sudo tee /etc/google-cloud-ops-agent/config.yaml <<EOF
logging:
receivers:
kne-pods:
Expand All @@ -38,19 +38,19 @@ EOF
sudo service google-cloud-ops-agent restart

echo "$BUILD"
cat << EOF > ~/.bazelrc
cat <<EOF >~/.bazelrc
build --remote_cache https://storage.googleapis.com/lemming-bazel-cache
build --google_default_credentials
EOF

export PATH=${PATH}:/usr/local/go/bin
gopath=$(go env GOPATH)
export PATH=${PATH}:$gopath/bin
curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 && \
sudo install skaffold /usr/local/bin/
curl -Lo bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.16.0/bazelisk-linux-amd64 && \
sudo install bazel /usr/local/bin/
sudo apt-get -y install libpcap-dev libnl-genl-3-dev libnl-3-dev
curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 &&
sudo install skaffold /usr/local/bin/
curl -Lo bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.16.0/bazelisk-linux-amd64 &&
sudo install bazel /usr/local/bin/
sudo apt-get -o DPkg::Lock::Timeout=600 -y install libpcap-dev libnl-genl-3-dev libnl-3-dev

cd /tmp/workspace
kne deploy ~/kne-internal/deploy/kne/kind-bridge.yaml
Expand All @@ -65,7 +65,7 @@ trap dumpinfo EXIT
trap 'rc=$?' ERR

make itest
# Reenable these tests once not flaky.
# Re-enable these tests once not flaky.
# cd cloudbuild && ./fp-test.sh

exit "${rc}"
exit "${rc}"
72 changes: 36 additions & 36 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.26.3
toolchain go1.27.1

require (
cloud.google.com/go/cloudbuild v1.34.0
cloud.google.com/go/cloudbuild v1.36.0
cloud.google.com/go/logging v1.20.0
cloud.google.com/go/monitoring v1.31.0
cloud.google.com/go/trace v1.17.0
Expand All @@ -21,17 +21,17 @@ require (
github.com/grpc-ecosystem/go-grpc-middleware/v2 v2.3.4
github.com/kentik/patricia v1.2.2
github.com/mdlayher/genetlink v1.4.0
github.com/open-traffic-generator/snappi/gosnappi v1.61.1
github.com/open-traffic-generator/snappi/gosnappi v1.62.0
github.com/openconfig/gnmi v0.14.1
github.com/openconfig/gnoi v0.8.0
github.com/openconfig/gnoigo v0.0.0-20250918224707-fee0fe3eee56
github.com/openconfig/gnsi v1.9.1
github.com/openconfig/goyang v1.6.3
github.com/openconfig/gribi v1.9.1
github.com/openconfig/gribigo v0.1.3
github.com/openconfig/kne v0.3.2
github.com/openconfig/kne v0.3.4
github.com/openconfig/magna v0.0.0-20260408002632-b210de0f7ba8
github.com/openconfig/ondatra v0.14.8
github.com/openconfig/ondatra v0.14.9
github.com/openconfig/testt v0.0.0-20251119232631-fbbd49c39452
github.com/openconfig/ygnmi v0.15.0
github.com/openconfig/ygot v0.35.0
Expand All @@ -44,26 +44,26 @@ require (
github.com/stoewer/go-strcase v1.3.1
github.com/vishvananda/netlink v1.3.1
go.opentelemetry.io/contrib/detectors/gcp v1.46.0
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.71.0
go.opentelemetry.io/otel v1.46.0
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.72.0
go.opentelemetry.io/otel v1.47.0
go.opentelemetry.io/otel/exporters/stdout/stdoutlog v0.22.0
go.opentelemetry.io/otel/log v0.22.0
go.opentelemetry.io/otel/sdk v1.46.0
go.opentelemetry.io/otel/log v1.47.0
go.opentelemetry.io/otel/sdk v1.47.0
go.opentelemetry.io/otel/sdk/log v0.22.0
go.opentelemetry.io/otel/sdk/metric v1.46.0
go.opentelemetry.io/otel/trace v1.46.0
go.opentelemetry.io/otel/sdk/metric v1.47.0
go.opentelemetry.io/otel/trace v1.47.0
go.uber.org/mock v0.6.0
golang.org/x/oauth2 v0.37.0
golang.org/x/sys v0.48.0
google.golang.org/api v0.300.0
golang.org/x/sys v0.49.0
google.golang.org/api v0.309.0
google.golang.org/genproto/googleapis/api v0.0.0-20260928230214-8a89bd6388cc
google.golang.org/genproto/googleapis/rpc v0.0.0-20260928230214-8a89bd6388cc
google.golang.org/grpc v1.84.0
google.golang.org/genproto/googleapis/rpc v0.0.0-20261019180522-ce908d29299b
google.golang.org/grpc v1.85.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.6.2
google.golang.org/protobuf v1.36.12
gopkg.in/yaml.v3 v3.0.1
k8s.io/apimachinery v0.37.0
k8s.io/client-go v0.37.0
k8s.io/apimachinery v0.37.1
k8s.io/client-go v0.37.1
k8s.io/klog v1.0.0
k8s.io/klog/v2 v2.140.0
modernc.org/cc/v4 v4.29.7
Expand All @@ -72,12 +72,12 @@ require (
require (
bitbucket.org/creachadair/stringset v0.0.14 // indirect
cloud.google.com/go v0.123.0 // indirect
cloud.google.com/go/auth v0.24.0 // indirect
cloud.google.com/go/auth v0.24.1-0.20261001053825-dbc26066f70a // indirect
cloud.google.com/go/auth/oauth2adapt v0.3.0 // indirect
cloud.google.com/go/compute/metadata v0.10.0 // indirect
cloud.google.com/go/iam v1.12.0 // indirect
cloud.google.com/go/longrunning v1.2.0 // indirect
cloud.google.com/go/pubsub/v2 v2.7.0 // indirect
cloud.google.com/go/pubsub/v2 v2.8.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.36.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.62.0 // indirect
github.com/Masterminds/semver/v3 v3.5.0 // indirect
Expand Down Expand Up @@ -114,8 +114,8 @@ require (
github.com/go-test/deep v1.1.1 // indirect
github.com/go-viper/mapstructure/v2 v2.5.0 // indirect
github.com/google/gnostic-models v0.7.1 // indirect
github.com/google/s2a-go v0.1.10 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.22 // indirect
github.com/google/s2a-go v0.1.11 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.23 // indirect
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.31.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
Expand All @@ -133,12 +133,12 @@ require (
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/open-traffic-generator/keng-operator v0.4.2 // indirect
github.com/open-traffic-generator/keng-operator v0.4.4 // indirect
github.com/openconfig/attestz v0.6.15 // indirect
github.com/openconfig/bootz v0.7.1 // indirect
github.com/openconfig/gnpsi v0.3.2 // indirect
github.com/openconfig/gocloser v0.0.0-20251119232641-34bca749fdb3 // indirect
github.com/openconfig/kne/third_party/meshnet v0.5.1 // indirect
github.com/openconfig/kne/third_party/meshnet v0.5.4 // indirect
github.com/openconfig/lemming/operator v0.2.9 // indirect
github.com/patrickmn/go-cache v2.1.0+incompatible // indirect
github.com/pborman/uuid v1.2.1 // indirect
Expand All @@ -148,7 +148,7 @@ require (
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
github.com/rogpeppe/go-internal v1.14.1 // indirect
github.com/sagikazarmark/locafero v0.12.0 // indirect
github.com/scrapli/scrapligo v1.4.1 // indirect
github.com/scrapli/scrapligo v1.4.3 // indirect
github.com/scrapli/scrapligocfg v1.0.0 // indirect
github.com/sirikothe/gotextfsm v1.0.1-0.20200816110946-6aa2cfd355e4 // indirect
github.com/spf13/afero v1.15.0 // indirect
Expand All @@ -160,31 +160,31 @@ require (
github.com/x448/float16 v0.8.4 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/auto/sdk v1.2.1 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.71.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.46.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.46.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.46.0 // indirect
go.opentelemetry.io/otel/metric v1.46.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.72.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.47.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.47.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.47.0 // indirect
go.opentelemetry.io/otel/metric v1.47.0 // indirect
go.opentelemetry.io/proto/otlp v1.11.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.yaml.in/yaml/v2 v2.4.4 // indirect
go.yaml.in/yaml/v3 v3.0.5 // indirect
golang.org/x/crypto v0.57.0 // indirect
golang.org/x/crypto v0.58.0 // indirect
golang.org/x/exp v0.0.0-20260908205506-85c1c2202aba // indirect
golang.org/x/net v0.60.0 // indirect
golang.org/x/sync v0.23.0 // indirect
golang.org/x/term v0.46.0 // indirect
golang.org/x/text v0.42.0 // indirect
golang.org/x/net v0.61.0 // indirect
golang.org/x/sync v0.24.0 // indirect
golang.org/x/term v0.47.0 // indirect
golang.org/x/text v0.43.0 // indirect
golang.org/x/time v0.16.0 // indirect
google.golang.org/genproto v0.0.0-20260715232425-e75dac1f907d // indirect
gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
k8s.io/api v0.37.0 // indirect
k8s.io/api v0.37.1 // indirect
k8s.io/kube-openapi v0.0.0-20260721132016-d427ff9ee9ad // indirect
k8s.io/streaming v0.37.0 // indirect
k8s.io/utils v0.0.0-20260707023825-cf1189d6abe3 // indirect
k8s.io/streaming v0.37.1 // indirect
k8s.io/utils v0.0.0-20261023123148-ca04ba58ecab // indirect
lukechampine.com/uint128 v1.3.0 // indirect
modernc.org/mathutil v1.7.1 // indirect
modernc.org/opt v0.2.0 // indirect
Expand Down
Loading
Loading