Repository navigation
Switch to use an in memory port interface when creating dummy ports - #780
Open
gavinz-ship-it wants to merge 7 commits into
Open
gavinz-ship-it wants to merge 7 commits into
gavinz-ship-it wants to merge 7 commits into
Conversation
Switch to use PortType_PORT_TYPE_GENETLINK when creating dummy ports.
Remove code to handle tap ports since dummy ports will use PortType_PORT_TYPE_GENETLINK.
Update genetlink so that it can be used to create dummy ports.
Fix minor bug in the string function
Update GenetlinkPortDesc
Update GenetlinkPortDesc
Update comments
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code creates a tap port when an interface does not exist to avoid errors due to non-existent ports.
This change switches the tap ports to a genetlink port that is stored in memory.
Using tap ports creates some issues, since tap ports open a /dev/net/tun handle, if Lucius opens too many of these handles, the buffer will be full and subsequent operations will fail.
This change also greatly improves the performance since the dummy port is completely in memory.