Repository navigation
[WIP] feat: add optional ordering param to exam query functions - #1324
brianjbuck-wgu wants to merge 3 commits into
Conversation
|
Thanks for the pull request, @brianjbuck-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @brianjbuck-wgu! Is this still in progress? |
Hi @mphilbrick211, Yes, let me keep this one open and put it on the schedule next week to finish up. |
7758d54 to
3776a7e
Compare
|
Hi @mphilbrick211, I've rebased this onto master. Who would be a good option to tag for review on this repo? |
|
@openedx/axim-engineering would someone be able to take a look at this for us? Thanks! |
|
@openedx/axim-engineering Can I get a review on this PR? 🙏 |
feanil
left a comment
There was a problem hiding this comment.
A couple of small things and a rebase before we can land this. Also the PR title still say "WIP" is that still true?
|
|
||
|
|
||
| def get_allowances_for_course(course_id): | ||
| def get_allowances_for_course(course_id, ordering=None): |
There was a problem hiding this comment.
Can you add ordering to the docstring here and on the other three functions? These are the public API so the argument should be documented where people look for it.
| Returns all the exam attempts for the course id. | ||
| """ | ||
| exam_attempts = ProctoredExamStudentAttempt.objects.get_all_exam_attempts(course_id) | ||
| if ordering: |
There was a problem hiding this comment.
order_by takes any number of fields, and the platform side will get a list from DRF's ordering param, so I think this should accept an iterable and do order_by(*ordering). If you'd rather keep it a single string, say so in the docstring since it's a Django field expression (user__username), not the dotted path the dashboard uses today.
Description:
Fixes: #1320
JIRA:
XXX-XXXX
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: